The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Commit Message changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after
hostname resets.
In
a custom VPC for every run. All resources will
be tagged with the ec2 tag, 'cii', and the date (e.g. cii-20171220-102452).
The VPC is setup with both IPv4 and IPv6 capabilities, but will only hand out
IPv4 addresses by default. Instances will have complete Internet access and
have full ingress
Chad Smith has proposed merging ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master with ~james-hogarth/cloud-init:net-tools-deprecation as a
prerequisite.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Description changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after hostname
resets.
In
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335465
--
Your team cloud-init commiters is requested
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index e73b57b..a56ced2 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -591,6 +591,18 @@ def
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:c092c12f606dd5a92e0f80db35a1cb4b8b5c1dcb
https://jenkins.ubuntu.com/server/job/cloud-init-ci/649/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
FAILED: Ubuntu LTS: Build
Click here to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:322b9f9de21d796956684cd07178d2256e8fca2a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/646/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Chad Smith has proposed merging ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master with ~james-hogarth/cloud-init:net-tools-deprecation as a
prerequisite.
Commit message:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:74f546422a0382e5b5782762b0db8be8339d48e3
https://jenkins.ubuntu.com/server/job/cloud-init-ci/648/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Chad Smith has proposed merging ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335470
azure: Don't bounce network with
* (from the commit message).
"The default instance type is set to t2.micro. This is the smallest type
that will work for both ebs and instance-store."
that is not true. per https://aws.amazon.com/ec2/instance-types/
t2.* are 'EBS-only'.
* user-data, I think probably you should pass
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Commit Message changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after
hostname resets.
In
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Description changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after
hostname resets.
In
Review: Approve continuous-integration
PASSED: Continuous integration, rev:0b61ef9c2353cdb14f5a9b0ae9c9e2001ca2bf3a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/647/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
One inline comment about a potential alternative that may be more
palatable/specific.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index e73b57b..a56ced2 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:74fb5bb7fdd46d7067e371833499131dfde14b30
https://jenkins.ubuntu.com/server/job/cloud-init-ci/650/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
FAILED: Ubuntu LTS: Build
Click here to
Review: Approve
Diff comments:
> diff --git a/tests/unittests/test_distros/test_netconfig.py
> b/tests/unittests/test_distros/test_netconfig.py
> index 8d0b263..9a62b71 100644
> --- a/tests/unittests/test_distros/test_netconfig.py
> +++ b/tests/unittests/test_distros/test_netconfig.py
> @@
Review: Approve continuous-integration
PASSED: Continuous integration, rev:6d567fe2e563f27412b4c6527eb12f57c81aeeea
https://jenkins.ubuntu.com/server/job/cloud-init-ci/651/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Commit Message changed to:
escription of the Change
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Commit Message changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after
hostname resets.
In
The proposal to merge ~chad.smith/cloud-init:azure-no-ifupdown into
cloud-init:master has been updated.
Description changed to:
azure: Don't bounce network with ifdown ifup when those tools don't exist
This fixes a traceback when attempting to bounce the network after
hostname resets.
In
CLA Signed, thanks!
--
https://code.launchpad.net/~penick/cloud-init/+git/cloud-init/+merge/335286
Your team cloud-init commiters is requested to review the proposed merge of
~penick/cloud-init:handle_uppercase_labels into cloud-init:master.
___
The proposal to merge ~rjschwei/cloud-init:baseNetConfTestSUSE into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772
--
Your team cloud-init commiters is requested to
The proposal to merge ~rjschwei/cloud-init:baseNetConfTestSUSE into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772
--
Your team cloud-init commiters is requested to review
25 matches
Mail list logo