Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master

2018-05-15 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py > index f14a4fc..6bd713a 100644 > --- a/cloudinit/config/cc_mounts.py > +++ b/cloudinit/config/cc_mounts.py > @@ -337,7 +337,7 @@ def handle(_name, cfg, cloud, log, _args): > start =

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-05-15 Thread Chad Smith
Couple nits on this approach Josh, then I think it looks good. Diff comments: > diff --git a/tests/cloud_tests/platforms/instances.py > b/tests/cloud_tests/platforms/instances.py > index 3bad021..3b2fe1c 100644 > --- a/tests/cloud_tests/platforms/instances.py > +++

[Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master

2018-05-15 Thread Chad Smith
The proposal to merge ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~thenarcotk/cloud-init/+git/cloud-init/+merge/345608 -- Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master

2018-05-15 Thread Chad Smith
Stephen, thank you so much for this patch and making cloud-init better. This project is governed by the contributor's license agreement. Once you are able to confirm signing the CLA, we'll land this branch immediately. Here are the details below. I've marked this branch 'work in progress' and

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1fdf14ea023a095f4de928e3662c655509fe3ced https://jenkins.ubuntu.com/server/job/cloud-init-ci/1126/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

[Cloud-init-dev] [recipe build #1579003] of ~cloud-init-dev cloud-init-daily-artful in artful: Failed to build

2018-05-15 Thread noreply
* State: Failed to build * Recipe: cloud-init-dev/cloud-init-daily-artful * Archive: ~cloud-init-dev/ubuntu/daily * Distroseries: artful * Duration: 1 minute * Build Log: https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/1579003/+files/buildlog.txt.gz * Upload Log:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:feature/run-container into cloud-init:master. Commit message: tools/run-container: replace tools/run-centos with more generic. tools/run-container is like tools/run-centos, but currently supports the following images from lxc-images

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2825748072db0f1c03dba1db5a2995eeda8d2dc5 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1127/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

[Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master

2018-05-15 Thread Stephen Ford
Stephen Ford has proposed merging ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master. Commit message: Fix a spelling mistake in a cc_mounts.py error message The error message has a spelling mistake when a nonexistent named mount is used. Requested reviews: cloud-init

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Joshua Powers
Before looking at this, one thing to note is that CI will obviously need to be updated before this is landed and unless someone rebases re-runs will fail -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345627 Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:85ada88e35930d2ab2cbb9a7a436bcfd992f9a71 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1128/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/opensuse-skip-on-httpretty-ssl-error into cloud-init:master

2018-05-15 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/opensuse-skip-on-httpretty-ssl-error into cloud-init:master. Commit message: tests: SkipTest some errors found in httpretty in OpenSuSE 42.3. In OpenSuSE 42.3, with python-httpretty=0.8.8-7.1 python-ndg-httpsclient=0.4.0-3.2

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/opensuse-skip-on-httpretty-ssl-error into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:90373bf66956e03cc972aaf29b6444f244299375 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1129/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:bfbc0ea14deffa7239b22d9c43f02c47d878fdfc https://jenkins.ubuntu.com/server/job/cloud-init-ci/1130/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~jacobbednarz/cloud-init:allow-false-in-sudo-directive into cloud-init:master

2018-05-15 Thread Jacob Bednarz
Jacob Bednarz has proposed merging ~jacobbednarz/cloud-init:allow-false-in-sudo-directive into cloud-init:master. Commit message: Explicitly prevent `sudo` access for user module To deny a user elevated access, you can omit the `sudo` key from the `users` dictionary. This works fine however