Kurt, thanks for the work on this, your work has landed in 18.2 cloud-init
version 18.2 and is currently present in bionic (and xenial-proposed pocket).
If you wish to test it out cloud-init 18.2 or greater will have the
functionality you need as the branch which landed your functionality is her
The proposal to merge ~kgarloff/cloud-init:detect_otc_as_openstack_ds into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845
--
Your team cloud-init commiters is requested
Kurt.
Looks good. thanks.
I still have to think about this more. But you've done the right bits in the
MP.
Thanks.
--
https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845
Your team cloud-init commiters is requested to review the proposed merge of
~kgarloff/cloud-init
Hi Scott,
thanks for the hint!
Better now?
-- Kurt
On 23.03.2018 17:32, Scott Moser wrote:
> Kurt I suspect you didn't push without --force.
>
> you have to push --force because you have a non-fastforward locally after the
> rebase.
>
--
Kurt Garloff , Cologne, DE
https://code.launchpad.
Kurt I suspect you didn't push without --force.
you have to push --force because you have a non-fastforward locally after the
rebase.
--
https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845
Your team cloud-init commiters is requested to review the proposed merge of
~kg
Rebase done. (I hope I have not screwed up the git commands.)
--
https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845
Your team cloud-init commiters is requested to review the proposed merge of
~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master.
_
the other is merged now, so you can rebase and push then the diff will get
updated.
Diff comments:
> diff --git a/tools/ds-identify b/tools/ds-identify
> index e3f93c9..9c69786 100755
> --- a/tools/ds-identify
> +++ b/tools/ds-identify
> @@ -875,23 +875,29 @@ dscheck_GCE() {
> dscheck_OpenStac
Kurt,
I put up just the 'Identify OpenTelecomcloud' commit as
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341851
and added a ds-identify unit test for it.
After that lands (I hope shortly) we can look at the second one here.
--
https://code.launchpad.net/~kgarloff/clou
Hi Scott,
On 21.03.2018 19:34, Scott Moser wrote:
> Hi Kurt, Thanksk for the merge proposal.
>
> I'd like to make a suggestion
> a.) split the 'a' and 'b' to different merge requests.
I intentionally did two commits to the branch, not just one, so they can
be treated as separate entities ...
Yo
Hi Kurt, Thanksk for the merge proposal.
I'd like to make a suggestion
a.) split the 'a' and 'b' to different merge requests.
'a' is straight forward win
b.) could have side effects.
we can discuss that more on its own MP, but I think that as it is right now
config-drive would always end up t
Kurt Garloff has proposed merging
~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1756471 in cloud-init: "ds-identify does not identify openstack Open
Telecom Cloud"
https://bugs.launchpad.
11 matches
Mail list logo
