Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:6d567fe2e563f27412b4c6527eb12f57c81aeeea https://jenkins.ubuntu.com/server/job/cloud-init-ci/651/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:74fb5bb7fdd46d7067e371833499131dfde14b30 https://jenkins.ubuntu.com/server/job/cloud-init-ci/650/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c092c12f606dd5a92e0f80db35a1cb4b8b5c1dcb https://jenkins.ubuntu.com/server/job/cloud-init-ci/649/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index e73b57b..a56ced2 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -591,6 +591,18 @@ def

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:74f546422a0382e5b5782762b0db8be8339d48e3 https://jenkins.ubuntu.com/server/job/cloud-init-ci/648/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

2017-12-20 Thread Chad Smith
One inline comment about a potential alternative that may be more palatable/specific. Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index e73b57b..a56ced2 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++