Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-02 Thread do3meli
hi scott, i have just updated this branch with what i think looks much better than before. as an additional feature users can now configure those 3 variables if they have their own service names / packages / config paths. i haven't tested this yet. will do so on Monday and give feedback again

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-02 Thread Scott Moser
Dom, Yeah, we have knowledge of ssh in the distro module. It more qualifies as a "basic service". Similarly, recent work is being done to do ntp configuration. ntp also seems "basic". So yeah, I like your suggestion in the link you provided. Some thing like the PuppetConstants might be helpf

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-02 Thread do3meli
hi scott, from a theoretical point of view i totally agree with you. the reason why i added those 3 cfg variables to the distro module was that it is currently not maintained like this everywhere. for example the variable cfg['ssh_svcname'] is also configured in the distro classes instead of th

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-01 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev: https://jenkins.ubuntu.com/server/job/cloud-init-ci/801/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu LTS: Integration SUCCESS: MAAS Compa

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-01 Thread Scott Moser
This is an interesting set of changes. In order to configure salt, you have to know details of 2 things a.) the distribution b.) salt software Generally knowledge of the distribution has been in the distribution class and the software in the 'config module' (cc_salt). You've mostly maintained th

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master

2018-03-01 Thread do3meli
can anyone of the jenkins team please have a look at the failed integration test. the error is: 2018-02-28 15:17:37,740 - tests.cloud_tests - ERROR - stage part: setup func for --deb, install deb encountered error: install deb version "17.1-46-g7acc9e68-0ubuntu1~16.04.1" does not match expected