Review: Approve
LGTM thanks for this!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into
cloud-init:master.
___
Josh, please see new commit. I think this is sane.
On Mon, Feb 12, 2018 at 12:03 PM, Scott Moser
wrote:
> You're correct that it will not bring in un-committed code. I can address
> that. I dont think its all that big of a deal really, the git work flow is
> generally "git commit"... git ammend
You're correct that it will not bring in un-committed code. I can address
that. I dont think its all that big of a deal really, the git work flow is
generally "git commit"... git ammend. other parts of cloud-init also do
not pick up uncommitted changes.
On Mon, Feb 12, 2018 at 11:51 AM, Joshua
thinking about this some more, this will not pull in uncommitted code. Do we
want to have a message print a warning to the user that they have uncommitted
code and it won't be pulled in?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters
Review: Approve
LGTM and tested locally seems to make execution go faster. Thanks!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone
Review: Approve continuous-integration
PASSED: Continuous integration, rev:dd2a9f2c8e7b006e3dfee01e4ff5bde0e9e33613
https://jenkins.ubuntu.com/server/job/cloud-init-ci/768/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Josh, yeah, I had wrong base branch.
that is fixed.
Also fixed, now we dont use a temp dir, so it is basically
tar -cf .git | tar -xf
that means ~ 42M which is an improvement over the current solution.
Espeically when my .tox is now 316M.
--
https://code.launchpad.net/~smoser/cloud-init/+git/
Did you push for the right branch? This looks like packaging of a new release.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into
Review: Approve continuous-integration
PASSED: Continuous integration, rev:bca132c1b66d7f9f53a2120b8155a984de4fd95f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/767/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
9 matches
Mail list logo
