Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master
I have now signed the Canonical Contributor Agreement. -- https://code.launchpad.net/~thenarcotk/cloud-init/+git/cloud-init/+merge/345608 Your team cloud-init commiters is requested to review the proposed merge of ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master
Thanks Chad for the feedback, a couple more spelling or wording mistakes too have been corrected. -- https://code.launchpad.net/~thenarcotk/cloud-init/+git/cloud-init/+merge/345608 Your team cloud-init commiters is requested to review the proposed merge of ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master
Stephen, thank you so much for this patch and making cloud-init better. This project is governed by the contributor's license agreement. Once you are able to confirm signing the CLA, we'll land this branch immediately. Here are the details below. I've marked this branch 'work in progress' and you can click it back to 'Needs review' when the CLA is done. Again thanks for working with us. To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group [2]. Unfortunately there is no easy way to check if an organization or company you are doing work for has signed. If you are unsure or have questions, email scott.mo...@canonical.com or ping smoser in #cloud-init channel via freenode. For information on how to sign, please see the HACKING document [3]. Thanks again, and please feel free to reach out with any questions. – [1] https://launchpad.net/~contributor-agreement-canonical/+members [2] https://launchpad.net/~contributor-agreement-canonical/+members [3] http://cloudinit.readthedocs.io/en/latest/topics/hacking.html -- https://code.launchpad.net/~thenarcotk/cloud-init/+git/cloud-init/+merge/345608 Your team cloud-init commiters is requested to review the proposed merge of ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master
Diff comments:
> diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py
> index f14a4fc..6bd713a 100644
> --- a/cloudinit/config/cc_mounts.py
> +++ b/cloudinit/config/cc_mounts.py
> @@ -337,7 +337,7 @@ def handle(_name, cfg, cloud, log, _args):
> start = str(cfgmnt[i][0])
> sanitized = sanitize_devname(start, cloud.device_name_to_device, log)
> if sanitized is None:
> -log.debug("Ignorming nonexistant named mount %s", start)
> +log.debug("Ignoring nonexistant named mount %s", start)
While fixing this spelling, we should also fix nonexistent :)
> continue
>
> if sanitized != start:
--
https://code.launchpad.net/~thenarcotk/cloud-init/+git/cloud-init/+merge/345608
Your team cloud-init commiters is requested to review the proposed merge of
~thenarcotk/cloud-init:fix-spelling-error-cc-mounts into cloud-init:master.
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
