Re: [Cluster-devel] [PATCH] qdiskd: Make multipath issues go away [RHEL6, take2]

Signed-Off. I also sent a very small cleanup after ionanny/178 port to STABLE32. Thanks Fabio On 02/17/2012 10:39 PM, Lon Hohberger wrote: Qdiskd hsitorically has required significant tuning to work around delays which occur during multipath failover, overloaded I/O, and LUN trespasses in

Re: [Cluster-devel] [PATCH] qdiskd: Make multipath issues go away

The patch looks good and ACK, with one minor nitpick. that 178 port value in cman_recv/send_data is rather cryptic. I would prefer to see it defined as others in cman/cnxman-socket.h for documentation purposes (so we know it's QDISK). Fabio On 02/16/2012 12:53 AM, Lon Hohberger wrote: Qdiskd

Re: [Cluster-devel] [PATCH] fencing: Missing password is not reported properly

Looks good. Fabio On 1/30/2012 3:58 PM, Marek 'marx' Grac wrote: When username is entered and password is missing then it is possible that fence code will end with exception. Resolves: rhbz#785091 --- fence/agents/lib/fencing.py.py | 11 --- 1 files changed, 8 insertions(+), 3

Re: [Cluster-devel] dlm: master - libdlm: install udev rules in /etc not /lib

David, this is incorrect. /lib/udev/rules.d is used for packages that ship rules (such as dlm) /etC/udev/rules.d are for users override and packages should not add anything there. You might notice on any recent system that /etc/udev/rules.d is virtually empty and /lib/udev/rules.d is populated

[Cluster-devel] commit emails are back

Hi all, after an upgrade on fedorahosted, our git2email gateway broke. The gateway is working again as of this morning. Please let me know if you notice any issue. Fabio

[Cluster-devel] STABLE32 branch open for business

Hi all, as previously announced, STABLE31 branch is now read only. commits to this branch will be automatically rejected. STABLE32 branch is now open and contains coverity fixes for common/ config/ and cman/ Once we will complete running coverity scan across the other subsystems, we will

Re: [Cluster-devel] checkquorum script for self fencing

On 12/21/2011 08:28 PM, Dietmar Maurer wrote: I recently detected that checkquorum script for self fencing. That seems to work reliable, but the remaining nodes (with quorum) does not get any fence acknowledge. I wonder if it would be possible to extend the checkquorum script so that it

Re: [Cluster-devel] [PATCH] gfs2-utils: Add gfs2-cluster systemd unit

On 12/13/2011 3:20 PM, Andrew Price wrote: Adds a systemd unit file to start gfs_controld at the correct point in the boot sequence. I've tested this as much as I can on Fedora 16 but it may require some more tweaking once the init scripts for cman, clvmd, etc. have been migrated. The gfs2

Re: [Cluster-devel] [PATCH] gfs2-utils: Add gfs2-cluster systemd unit

On 12/13/2011 4:00 PM, Andrew Price wrote: On 13/12/11 14:36, Fabio M. Di Nitto wrote: cman will not migrate to systemd Just curious, but why? Wouldn't it risk getting cman blocked from fedora? ( https://lists.fedoraproject.org/pipermail/devel/2011-November/159157.html ) Andy

Re: [Cluster-devel] Fix fence-agents manpages

On 12/7/2011 9:53 AM, Arnaud Quette wrote: ok, that confirms the POD style approach. I wasn't sure if you were standardizing on this, or going away from. The patch will be obsoleted in the fence-agents release or max two. thanks for these info. I take it as this

Re: [Cluster-devel] Fix fence-agents manpages

On 12/6/2011 2:27 PM, Arnaud Quette wrote: Hi Cluster-devel list, You will find attached a patch originating from Ubuntu (Andres Rodriguez), that fixes a few issues in manpages (namely fence_drac and fence_scsi). I wonder why the ubuntu/canonical maintainers can´t post patches directly for

Re: [Cluster-devel] Fix fence-agents manpages

On 12/6/2011 4:05 PM, Arnaud Quette wrote: Hi Fabio, 2011/12/6 Fabio M. Di Nitto fabbi...@fabbione.net: On 12/6/2011 2:27 PM, Arnaud Quette wrote: Hi Cluster-devel list, You will find attached a patch originating from Ubuntu (Andres Rodriguez), that fixes a few issues in manpages (namely

Re: [Cluster-devel] 3.1.8 rc fails to validate IP resources

On 12/03/2011 11:34 PM, Digimer wrote: Looks like the IP section was not added to cluster.rng. You need to install latest and greatest resource-agents :) Fabio

Re: [Cluster-devel] cluster: STABLE31 - Changes the kernel version check to handle 3.x.y kernels. Now if the 'x' version of the running kernel is higher than the 'x' version of the minimum kernel, the

On 12/03/2011 07:48 PM, Madison Kelly wrote: Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=9be00f89c9b3d9670cbd73525d4c41440a37b08a Commit:9be00f89c9b3d9670cbd73525d4c41440a37b08a Parent:991bfb0b1f547da5314141fcd79e0ea2253f78f4

Re: [Cluster-devel] 3.1.8 rc fails to validate IP resources

On 12/04/2011 06:52 PM, Digimer wrote: On 12/04/2011 03:12 AM, Fabio M. Di Nitto wrote: On 12/03/2011 11:34 PM, Digimer wrote: Looks like the IP section was not added to cluster.rng. You need to install latest and greatest resource-agents :) Fabio Now *that's* just embarrassing! :P

[Cluster-devel] [PATCH] config: drastically improve cman RRP configuration handling

From: Fabio M. Di Nitto fdini...@redhat.com - don't allow configuration of more than 2 rings - allow overrided of alternate mcast address and port via envars - when using broadcast, set different ports on second ring. this also required a substantial change in transport handling - add support

Re: [Cluster-devel] [PATCH 32/41] qdiskd: clean code around case

On 11/29/2011 06:59 PM, Lon Hohberger wrote: On 11/23/2011 05:15 AM, Fabio M. Di Nitto wrote: Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nittofdini...@redhat.com --- :100644 100644 c4db713... 51d9a39... Mcman/qdisk/main.c cman/qdisk/main.c |2 ++ 1 files changed, 2

[Cluster-devel] [PATCH] config: make altname validation position indipendent

From: Fabio M. Di Nitto fdini...@redhat.com Resolves: rhbz#740552 Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- config/tools/xml/cluster.rng.in.head | 55 +++--- 1 files changed, 31 insertions(+), 24 deletions(-) diff --git a/config/tools/xml

Re: [Cluster-devel] [PATCH] fence_rackswitch: Add metadata output for fence_rackswitch agent

On 11/28/2011 12:07 PM, Marek 'marx' Grac wrote: Adding this feature allow us to generate manual pages directly from XML, so both GUI tools and manual pages can see same feature. Resolves: rhbz#714841 (partial) --- fence/agents/rackswitch/Makefile.am|8 +++

[Cluster-devel] Upcoming changes in cluster releases/branches

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi all, first of all I am very happy to announce that Digimer is going to be our new release manager. Digimer has been contributing to the cluster project in many many different ways, very active and helpful in the community, with a strong

[Cluster-devel] [coverity] cman

Before: Analysis summary report: Files analyzed : 27 Total LoC input to cov-analyze : 32029 Functions analyzed : 380 Paths analyzed : 52124 New defects found : 315 Total 3

[Cluster-devel] [PATCH 01/41] libcman: fix bad flags check

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 a89c731... 9ea82c1... M cman/lib/libcman.c cman/lib/libcman.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c index a89c731

[Cluster-devel] [PATCH 07/41] cman_tool: make cman_error static and make it use it's arg instead of global errno

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 e1250ee... 60091c9... M cman/cman_tool/cman_tool.h :100644 100644 a33c8b4... 872528b... M cman/cman_tool/join.c :100644 100644 88612c4... a336c42... M cman/cman_tool/main.c cman/cman_tool

[Cluster-devel] [PATCH 10/41] cman_tool: check that memory is allocated

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 5a5aa7b... 46c315d... M cman/cman_tool/main.c cman/cman_tool/main.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/cman/cman_tool/main.c b/cman/cman_tool/main.c index

[Cluster-devel] [PATCH 03/41] libcman: fix variable type

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 46f5c89... fbf5bf8... M cman/lib/libcman.c cman/lib/libcman.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c index 46f5c89..fbf5bf8

[Cluster-devel] [PATCH 02/41] libcman: fix fd usage

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 9ea82c1... 46f5c89... M cman/lib/libcman.c cman/lib/libcman.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c index 9ea82c1

[Cluster-devel] [PATCH 04/41] libcman: fix possible memory leak

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 fbf5bf8... 5b015f0... M cman/lib/libcman.c cman/lib/libcman.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c index

[Cluster-devel] [PATCH 05/41] libcman: correctly check for vars before using them

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 5b015f0... ae6c709... M cman/lib/libcman.c cman/lib/libcman.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c index

[Cluster-devel] [PATCH 11/41] cman_tool: drop unused vars and fix value check

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 b92090c... a1c1c14... M cman/cman_tool/join.c :100644 100644 46c315d... 0e8876a... M cman/cman_tool/main.c cman/cman_tool/join.c | 10 +- cman/cman_tool/main.c |6 ++ 2 files

[Cluster-devel] [PATCH 12/41] cman: add check to guarantee we found our own node name

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 16ef65f... f23f386... M cman/daemon/cmanconfig.c cman/daemon/cmanconfig.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/cman/daemon/cmanconfig.c b/cman/daemon

[Cluster-devel] [PATCH 15/41] cman: fix a few var checks and types

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 fb534a9... 9d52fde... M cman/daemon/cman-preconfig.c :100644 100644 f23f386... d3009d0... M cman/daemon/cmanconfig.c :100644 100644 02fe88d... 1489f7c... M cman/daemon/commands.c :100644 100644

[Cluster-devel] [PATCH 24/41] notifyd: fix virtually impossible buffer overflows

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 7b625c9... 3091d2f... M cman/notifyd/main.c cman/notifyd/main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cman/notifyd/main.c b/cman/notifyd/main.c index 7b625c9

[Cluster-devel] [PATCH 08/41] cman_tool: don't use envp from main

according to wikipedia it is a microsoft extensions. Use __environ directly from unistd.h Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 60091c9... 6c5744e... M cman/cman_tool/cman_tool.h :100644 100644 872528b... b92090c... M cman/cman_tool

[Cluster-devel] [PATCH 18/41] cman: move check of null at beginning

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 7fb3005... 37283ba... M cman/daemon/barrier.c cman/daemon/barrier.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cman/daemon/barrier.c b/cman/daemon/barrier.c index

[Cluster-devel] [PATCH 16/41] cman: drop unrequired/unused vars and functions

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 1489f7c... 7641294... M cman/daemon/commands.c :100644 100644 bbf2628... 4851387... M cman/daemon/nodelist.h cman/daemon/commands.c | 18 -- cman/daemon/nodelist.h |4 +--- 2

[Cluster-devel] [PATCH 06/41] libcman: switch to strncpy to avoid possible buffer overflows

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 ae6c709... b49cf6f... M cman/lib/libcman.c cman/lib/libcman.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/cman/lib/libcman.c b/cman/lib

[Cluster-devel] [PATCH 21/41] cman: fix free handle logic

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 284b351... 6b61332... M cman/daemon/commands.c cman/daemon/commands.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cman/daemon/commands.c b/cman/daemon/commands.c

[Cluster-devel] [PATCH 27/41] qdiskd: check for sscanf return codes

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 20a77f2... 6bbf311... M cman/qdisk/scandisk.c cman/qdisk/scandisk.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/cman/qdisk/scandisk.c b/cman/qdisk

[Cluster-devel] [PATCH 19/41] cman: init structs before use

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 522994b... d632c17... M cman/daemon/cman-preconfig.c cman/daemon/cman-preconfig.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cman/daemon/cman-preconfig.c b/cman

[Cluster-devel] [PATCH 23/41] notifyd: check for pid errors and report them

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 133706f... 7b625c9... M cman/notifyd/main.c cman/notifyd/main.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cman/notifyd/main.c b/cman/notifyd/main.c index 133706f

[Cluster-devel] [PATCH 25/41] qdiskd: use correct sizeof for memb_mask_t

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 d613d84... 01aa199... M cman/qdisk/main.c cman/qdisk/main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c index d613d84..01aa199

[Cluster-devel] [PATCH 28/41] qdisk: fix scandisk eval check

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 6bbf311... e962f74... M cman/qdisk/scandisk.c cman/qdisk/scandisk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cman/qdisk/scandisk.c b/cman/qdisk/scandisk.c index

[Cluster-devel] [PATCH 26/41] qdiskd: report errors on cman_dispatch failures

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 01aa199... 6e9abea... M cman/qdisk/main.c cman/qdisk/main.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c index 01aa199

[Cluster-devel] [PATCH 29/41] qdiskd: add strlen check to avoid memory corruption

and fix a few impossible buffer overflows Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 d5926f9... 929b152... M cman/qdisk/daemon_init.c cman/qdisk/daemon_init.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff

[Cluster-devel] [PATCH 31/41] qdiskd: don�t deference null variable

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 929b152... 3cbac37... M cman/qdisk/daemon_init.c cman/qdisk/daemon_init.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cman/qdisk/daemon_init.c b/cman/qdisk

[Cluster-devel] [PATCH 30/41] qdiskd: warn users when we cannot write eviction notice to disk

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 6e9abea... c4db713... M cman/qdisk/main.c cman/qdisk/main.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c index 6e9abea

[Cluster-devel] [PATCH 32/41] qdiskd: clean code around case

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 c4db713... 51d9a39... M cman/qdisk/main.c cman/qdisk/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c index c4db713..51d9a39

[Cluster-devel] [PATCH 33/41] qdiskd: don't try the impossible if we can't open /dev/null

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 3cbac37... c260cb8... M cman/qdisk/daemon_init.c :100644 100644 51d9a39... d21c209... M cman/qdisk/main.c cman/qdisk/daemon_init.c |2 +- cman/qdisk/main.c|5 + 2 files changed

[Cluster-devel] [PATCH 34/41] qdiskd: avoid a potential crash in case config state is invalid

Spotted by Coverify Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 d21c209... 079af01... M cman/qdisk/main.c cman/qdisk/main.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c index d21c209..079af01

[Cluster-devel] [PATCH 35/41] qdiskd: change variable type

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 9884ea7... d0d05f0... M cman/qdisk/disk.c cman/qdisk/disk.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cman/qdisk/disk.c b/cman/qdisk/disk.c index 9884ea7..d0d05f0

[Cluster-devel] [PATCH 36/41] qdiskd: implement better string handling

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 e962f74... 477b8de... M cman/qdisk/scandisk.c cman/qdisk/scandisk.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/cman/qdisk/scandisk.c b/cman/qdisk

[Cluster-devel] [PATCH 37/41] qdiskd: add failure paths to check_process_running and drop duplicate check

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 c260cb8... 2ba6fa0... M cman/qdisk/daemon_init.c :100644 100644 079af01... 175bdb6... M cman/qdisk/main.c cman/qdisk/daemon_init.c | 27 --- cman/qdisk/main.c

[Cluster-devel] [PATCH 39/41] qdiskd: don't leak memory if we fail to read from disk

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 d0d05f0... 7c6e114... M cman/qdisk/disk.c cman/qdisk/disk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cman/qdisk/disk.c b/cman/qdisk/disk.c index d0d05f0..7c6e114

[Cluster-devel] [PATCH 38/41] qdiskd: fix possible resource leak in scandisk

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 477b8de... b99a672... M cman/qdisk/scandisk.c cman/qdisk/scandisk.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/cman/qdisk/scandisk.c b/cman/qdisk/scandisk.c

[Cluster-devel] [PATCH 41/41] qdiskd: fix more uninizialized values

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 7c6e114... ec47a5f... M cman/qdisk/disk.c cman/qdisk/disk.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/cman/qdisk/disk.c b/cman/qdisk/disk.c index 7c6e114

[Cluster-devel] [PATCH 40/41] qdiskd: fix uninitialized values

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 b99a672... b80046b... M cman/qdisk/scandisk.c cman/qdisk/scandisk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cman/qdisk/scandisk.c b/cman/qdisk/scandisk.c index

[Cluster-devel] [PATCH 22/41] cman: fix several virtually impossible buffer overflows

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 6b5640a... ea5020c... M cman/daemon/ais.c :100644 100644 37283ba... c356abe... M cman/daemon/barrier.c :100644 100644 d632c17... baf94df... M cman/daemon/cman-preconfig.c :100644 100644 d3009d0

Re: [Cluster-devel] cman start error

On 10/28/2011 07:25 PM, Nick Khamis wrote: Hello Fabio, Thank you so much for your response. I am using pacemaker 1.1.6, which is the latest version? I added /usr/lib to the system llibrary path, which contains all the liblogsys.*, and libcoro* libraries, and re-installed cman, but I am

Re: [Cluster-devel] cman start error

Your build is not installed correctly. at least liblogsys cannot be found in the system library path. Using pacemaker.lcrso is deprecated (get a new version of pcmk or build it correctly) Fabio On 10/28/2011 04:07 AM, Nick Khamis wrote: Hello Everyone, I am getting this error with a fresh

Re: [Cluster-devel] [PATCH 2/2] rgmanager: Send events on service stop preserve frozen flag [RHEL5]

ACK both patches. Fabio On 10/28/2011 01:32 AM, Lon Hohberger wrote: The rgmanger FROZEN flag is supposed to persist until disabled explicitly by an administrator or loss of quorum. Resolves: rhbz#722230 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/include/event.h

Re: [Cluster-devel] [PATCH] resource-agents: Handle TREX and Webdispatcher in SAPInstance [RHEL5]

ACK On 10/28/2011 01:45 AM, Lon Hohberger wrote: From: Harald Klein hkl...@redhat.com Note: This patch is not suitable for mainline resource-agents/heartbeat/SAPInstance, alterations must be made separately. Resolves: rhbz#746992 Signed-off-by: Lon Hohberger l...@redhat.com ---

Re: [Cluster-devel] [PATCH] resource-agents: nfsclient: fix wildcard status checks [RHEL5]

ACK Fabio On 10/28/2011 04:26 AM, Lon Hohberger wrote: Several permutations of nfsclients with options were not checked correctly due to bad pattern matching. Resolves: rhbz#700103 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/nfsclient.sh | 20

Re: [Cluster-devel] Error when compiling dlm from cman

(please keep cluster-devel in the CC list, it might be helpful for other people too) On 10/26/2011 3:00 PM, Nick Khamis wrote: Hello Gents, Thank you so much for your responses! There use to be --enable-pacemaker --disable-cman flags. These have since been dropped. So just build everything

Re: [Cluster-devel] Error when compiling dlm from cman

Gents :P (just kidding of course ;) Fabio Thanks Again, Nick. On Wed, Oct 26, 2011 at 2:09 PM, Fabio M. Di Nitto fdini...@redhat.com wrote: (please keep cluster-devel in the CC list, it might be helpful for other people too) On 10/26/2011 3:00 PM, Nick Khamis wrote: Hello Gents

Re: [Cluster-devel] Error when compiling dlm from cman

On Wed, Oct 26, 2011 at 2:12 PM, Nick Khamis sym...@gmail.com wrote: Fabio, I appologize for that. It was unintentional. If you notice, I said Hello Gents. I will upgrade to 1.4.2, and keep everyone posted. Thanks Again, Nick. On Wed, Oct 26, 2011 at 2:09 PM, Fabio M. Di Nitto fdini

Re: [Cluster-devel] Error when compiling dlm from cman

, 2011 at 2:19 PM, Fabio M. Di Nitto fdini...@redhat.com wrote: On 10/26/2011 8:17 PM, Nick Khamis wrote: I forgot to ask: Yes that is correct. dlm_controld.pcmk has been obsoleted in favour of cman support for pacemaker. Does that mean that dlm + fence is provided by cman directly, and thus

Re: [Cluster-devel] Error when compiling dlm from cman

the latest version from git://git.fedorahosted.org/dlm.git. Is it sufficient just to run make make install? Did not see and configure script. Thanks Again, Nick. On Wed, Oct 26, 2011 at 2:19 PM, Fabio M. Di Nitto fdini...@redhat.com wrote: On 10/26/2011 8:17 PM, Nick Khamis wrote: I forgot

Re: [Cluster-devel] Error when compiling dlm from cman

1.4.2 didn´t exist :) I generally update those requirements on a release base. Fabio Cheers, Nick. On Wed, Oct 26, 2011 at 2:36 PM, Fabio M. Di Nitto fdini...@redhat.com wrote: On 10/26/2011 8:34 PM, Nick Khamis wrote: The question is, does the unstable standalone of dlm require cman

[Cluster-devel] [PATCH 06/19] libccs: remove duplicate checks

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 703fa17... 3b2ab4b... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config/libs/libccsconfdb

[Cluster-devel] [PATCH 02/19] ccs_config_dump: remove unnecessary pointer to env

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 74c33c2... 022777f... M config/tools/xml/ccs_config_dump.c config/tools/xml/ccs_config_dump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config/tools/xml

[Cluster-devel] [PATCH 01/19] libccs: check return code consistently

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 577c74a... 703fa17... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/config/libs

[Cluster-devel] [PATCH 10/19] config: fix extremely unlikely buffer overflow

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 541fed7... 12c5320... M config/libs/libccsconfdb/extras.c config/libs/libccsconfdb/extras.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/config

[Cluster-devel] [PATCH 11/19] config: fix a few theoretical buffer overflows

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 12c5320... 12536ae... M config/libs/libccsconfdb/extras.c config/libs/libccsconfdb/extras.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/libs/libccsconfdb

[Cluster-devel] [coverity] config

Original errors/warnings: Analysis summary report: Files analyzed : 21 Total LoC input to cov-analyze : 29195 Functions analyzed : 170 Paths analyzed : 10405 New defects found : 136 Total

[Cluster-devel] [PATCH 07/19] config: fix libccs return codes and errno handling

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 b0cf55b... 541fed7... M config/libs/libccsconfdb/extras.c :100644 100644 3b2ab4b... 6b2e138... M config/libs/libccsconfdb/fullxpath.c :100644 100644 d9cddc0... bfc2d29... M config/libs/libccsconfdb

[Cluster-devel] [PATCH 08/19] config: improve string error checking in tokenizer

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 0a21f85... 710c176... M config/libs/libccsconfdb/xpathlite.c config/libs/libccsconfdb/xpathlite.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/config

[Cluster-devel] [PATCH 18/19] config: remove unused var in ccs_tool

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 a0fee9f... 34c4c1e... M config/tools/ccs_tool/ccs_tool.c config/tools/ccs_tool/ccs_tool.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/config/tools

[Cluster-devel] [PATCH 09/19] config: fix possible memory leak in libccs fullxpath usage

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 6b2e138... 8c4501f... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/config/libs

[Cluster-devel] [PATCH 17/19] config: fix confdb2ldif secure coding

Spotted by Coverify Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 35f8c31... 1f83c2f... M config/tools/ldap/confdb2ldif.c config/tools/ldap/confdb2ldif.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/config/tools/ldap

[Cluster-devel] [PATCH 14/19] config: make sure error reporting does not overflow buffers

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 9479bc2... a25df09... M config/plugins/xml/config.c config/plugins/xml/config.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/plugins/xml/config.c b/config

[Cluster-devel] [PATCH 16/19] config: rng2ldif bug fixes

several differnt memory leaks, missing checks and other minor issues. Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 7607714... dd69401... M config/tools/ldap/rng2ldif/genclass.c :100644 100644 6b24dd2... 635d4c8... M config/tools/ldap/rng2ldif

[Cluster-devel] [PATCH 19/19] config: fix a few checks in ccs_tool edit functionalities

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 fe52665... 9415506... M config/tools/ccs_tool/editconf.c config/tools/ccs_tool/editconf.c | 40 +++-- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git

Re: [Cluster-devel] Error when compiling dlm from cman

On 10/26/2011 03:47 AM, Nick Khamis wrote: Hello Everyone, I am attempting to provide ocfs2 dlm and fencing support for our pacemaker cluster. I recieve an error when configuring using: ./configure --prefix=/usr/local --without_cman You need to drop --without_cman. Those flags have to be

Re: [Cluster-devel] How to provide documentation feedback and patches?

On 10/20/2011 10:09 AM, Arnaud Quette wrote: Hi Fabio and Lon, first, thanks for your answers. 2011/10/19 Fabio M. Di Nitto: Hi Arnaud, On 10/19/2011 1:43 PM, Arnaud Quette wrote: Hi Cluster-devel, A quick question for which I've not found an answer yet: how / where should I send

Re: [Cluster-devel] How to provide documentation feedback and patches?

Hi Arnaud, On 10/19/2011 1:43 PM, Arnaud Quette wrote: Hi Cluster-devel, A quick question for which I've not found an answer yet: how / where should I send contribution or discuss cluster-devel related topics? patches/contribution should go to cluster-devel normal user discussion should

Re: [Cluster-devel] cluster4 gfs_controld

On 10/13/2011 10:30 PM, Lon Hohberger wrote: On 10/13/2011 11:30 AM, David Teigland wrote: On Thu, Oct 13, 2011 at 03:41:31PM +0100, Steven Whitehouse wrote: cluster4 . jid from dlm-kernel slots which will be assigned similarly What is the actual algorithm used to assign these slots? The

Re: [Cluster-devel] [PATCH] rgmanager: Add -F to clusvcadm man page [RHEL5]

ACK On 10/11/2011 8:17 PM, Lon Hohberger wrote: Resolves: rhbz#715052 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/man/clusvcadm.8 |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/rgmanager/man/clusvcadm.8 b/rgmanager/man/clusvcadm.8 index

[Cluster-devel] [PATCH 2/4] liblogthread: make sure there is space for \0 end string

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 4f8354a... 384f042... M common/liblogthread/liblogthread.c common/liblogthread/liblogthread.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/liblogthread

[Cluster-devel] [coverity] liblogthread

This is the first patchset to address some issues spotted by Coverity scan. Original errors/warnings: Analysis summary report: Files analyzed : 1 Total LoC input to cov-analyze : 12453 Functions analyzed : 11 Paths analyzed :

[Cluster-devel] [PATCH 1/4] liblogthread: call to localtime needs return value check

Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto fdini...@redhat.com --- :100644 100644 ba96a2a... 4f8354a... M common/liblogthread/liblogthread.c common/liblogthread/liblogthread.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/common/liblogthread

Re: [Cluster-devel] dlm: master - add license/copyright headers

Hi David, this is going to need another quick pass. The libdlm headers are fine, but for the daemon/tool, we had GPLv2+ in STABLE31 and current header only reflects GPLv2. In theory you need to add a similar header to the Makefile's too. Cheers Fabio

Re: [Cluster-devel] dlm: master - add license/copyright headers

On 10/06/2011 08:12 PM, David Teigland wrote: On Thu, Oct 06, 2011 at 08:02:10PM +0200, Fabio M. Di Nitto wrote: Hi David, this is going to need another quick pass. The libdlm headers are fine, but for the daemon/tool, we had GPLv2+ in STABLE31 and current header only reflects GPLv2. I'm

Re: [Cluster-devel] dlm: master - dlm: clear out old stuff and build system

On 10/03/2011 08:23 PM, David Teigland wrote: dlm/libdlm/libdlm.pc.in | 11 - dlm/libdlm/libdlm_lt.pc.in| 11 - dropping the .pc file is going to break dlm users. pc files are used by different build systems (not just autotools/autoconf) to detect libdlm and

Re: [Cluster-devel] dlm: master - dlm_controld: remove ccs and new Makefile

On 09/30/2011 12:02 AM, David Teigland wrote: add a normal, sane Makefile If you plan to drop autoconf+autotool, that is your call (I disagree for several reasons, but it's your project and I am not going to argue), but you need to do it all over the tree, basically going back to something

Re: [Cluster-devel] dlm: master - dlm: clear out old stuff and build system

Hi David, you have gone a bit too heavy handed on this one :) On 09/30/2011 11:57 PM, David Teigland wrote: dlm: clear out old stuff and build system Signed-off-by: David Teigland teigl...@redhat.com --- dlm/libdlm/libdlm.pc.in | 11 - dlm/libdlm/libdlm_lt.pc.in|

[Cluster-devel] cluster 3.1.7 release

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Welcome to the cluster 3.1.7 release. This release addresses several bugs and especially a serious problem introduced in the 3.1.6 release. If you are currently running 3.1.6, it is highly recommended to upgrade to 3.1.7 as soon as possible. The

Re: [Cluster-devel] [PATCH] fence_scsi: remove unlink of fence_scsi.dev file

Oh cool! that was a nice and quick fix for the BZ. ACK for upstream/master/RHEl, but please hold the cherry pick to RHEL till next tuesday. Thanks Fabio On 09/28/2011 12:21 AM, Ryan O'Hara wrote: This patch removes the call to unlink the fence_scsi.dev file during unfencing (action=on).

Re: [Cluster-devel] use cman_tool leave remove on shutdown/restart

On 09/26/2011 11:05 AM, Dietmar Maurer wrote: in /etc/init.d/cman: I wonder if it would be safe to use the 'remove' option for runlevel 0 and 6. Or is that considered dangerous? if so, why? The leave remove option has to be used only when permanently removing a node from a cluster. The

Re: [Cluster-devel] use cman_tool leave remove on shutdown/restart

On 09/26/2011 12:55 PM, Dietmar Maurer wrote: The leave remove option has to be used only when permanently removing a node from a cluster. The remove code path, totally cancel the knowledge of that node from the cluster, including quorum recalculation. It has to be used very carefully for

Re: [Cluster-devel] dlm: master - dlm_controld: new plock state transfer

On 09/23/2011 10:50 PM, David Teigland wrote: Gitweb: http://git.fedorahosted.org/git/dlm.git?p=dlm.git;a=commitdiff;h=fffedc10167085cb2668e5b86ad4eee38288637e Commit:fffedc10167085cb2668e5b86ad4eee38288637e Parent:a6e07ad59a764effe13bd02bbc22c0e25b2e225b Author:

<    1   2   3   4   5   6   >