Re: [Cluster-devel] How to enable daemon_debug for dlm_controld

2018-06-27 Thread Guoqing Jiang
On 06/27/2018 09:49 PM, David Teigland wrote: On Wed, Jun 27, 2018 at 04:07:18PM +0800, Guoqing Jiang wrote: But by default, seems dlm_controld just run with "-s 0". And I tried to add "daemon_debug=1" to /etc/dlm/dlm.conf, then dlm resource can't start at all. C

[Cluster-devel] How to enable daemon_debug for dlm_controld

2018-06-27 Thread Guoqing Jiang
Hi David, I want enable the option to see why dlm_controld got repeatly launched repeatly by systemd, these logs happened in split brain case. Jun 27 15:40:24 gqj-bsc1098449-2 systemd[1]: Started Process Core Dump (PID 3149/UID 0). Jun 27 15:40:24 gqj-bsc1098449-2 systemd-coredump[3150]:

Re: [Cluster-devel] About locking granularity of gfs2

2018-04-24 Thread Guoqing Jiang
On 04/24/2018 08:54 PM, Steven Whitehouse wrote: Hi, On 24/04/18 04:54, Guoqing Jiang wrote: Hi Steve, Thanks for your reply. On 04/24/2018 11:03 AM, Steven Whitehouse wrote: Hi, On 24/04/18 03:52, Guoqing Jiang wrote: Hi, Since gfs2 can "allow parallel allocation from diff

Re: [Cluster-devel] About locking granularity of gfs2

2018-04-24 Thread Guoqing Jiang
On 04/24/2018 01:13 PM, Gang He wrote: Stripe unit is logical volume concepts, for file system, it should not know this, for file system, the access unit is block (power of disk sector size). IMHO, It is true for typical fs, but I think zfs and btrfs can know about it well, though no

Re: [Cluster-devel] About locking granularity of gfs2

2018-04-23 Thread Guoqing Jiang
Hi Steve, Thanks for your reply. On 04/24/2018 11:03 AM, Steven Whitehouse wrote: Hi, On 24/04/18 03:52, Guoqing Jiang wrote: Hi, Since gfs2 can "allow parallel allocation from different nodes simultaneously as the locking granularity is one lock per resource group" per section

[Cluster-devel] About locking granularity of gfs2

2018-04-23 Thread Guoqing Jiang
Hi, Since gfs2 can "allow parallel allocation from different nodes simultaneously as the locking granularity is one lock per resource group" per section 3.2 of [1]. Could it possible to make the locking granularity also applies to R/W IO? Then, with the help of "sunit" and "swidth", we

[Cluster-devel] [PATCH] dlm/recoverd: recheck kthread_should_stop() before schedule()

2017-09-25 Thread Guoqing Jiang
ours without problem and it happens easily without the change). Signed-off-by: Guoqing Jiang <gqji...@suse.com> --- fs/dlm/recoverd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/dlm/recoverd.c b/fs/dlm/recoverd.c index 6859b4b..9fab490 100644 --- a/fs/dlm/recoverd

Re: [Cluster-devel] [PATCH] dlm: use sock_create_lite inside tcp_accept_from_sock

2017-08-07 Thread Guoqing Jiang
On 08/08/2017 03:10 AM, Bob Peterson wrote: | | Signed-off-by: Guoqing Jiang <gqji...@suse.com> | | --- | | fs/dlm/lowcomms.c | 2 +- | | 1 file changed, 1 insertion(+), 1 deletion(-) | | | | diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c | | index 9382db9..4813d0e 100644 | | --- a/

[Cluster-devel] [PATCH] dlm: use sock_create_lite inside tcp_accept_from_sock

2017-08-07 Thread Guoqing Jiang
raft", it also means newsock->sk is leaked since sock_graft will replace it with a new sk. To resolve the issue, we need to use sock_create_lite instead of sock_create_kern, like commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the accept socket") did. Signed-off-by: Guoq

Re: [Cluster-devel] About dlm_unlock (kernel space)

2016-06-13 Thread Guoqing Jiang
On 06/13/2016 10:56 PM, David Teigland wrote: On Mon, Jun 13, 2016 at 07:15:09AM -0400, Guoqing Jiang wrote: Hi, In case we have set DLM_LKF_CONVERT flag for dlm_lock, is it possible that the convert queue could be NULL or not NULL while perform unlock? I think there are two different cases

[Cluster-devel] About dlm_unlock (kernel space)

2016-06-13 Thread Guoqing Jiang
Hi, In case we have set DLM_LKF_CONVERT flag for dlm_lock, is it possible that the convert queue could be NULL or not NULL while perform unlock? I think there are two different cases would appear when call dlm_unlock: 1. the lock logic is in convert stage. 2. convert queue is null. For 1,

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-16 Thread Guoqing Jiang
Hi David, David Teigland wrote: On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: Do you consider take the following clean up? If yes, I will send a formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread Guoqing Jiang
Hi David, David Teigland wrote: On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: The remove_from_waiters could only be invoked after failed to create_message, right? Since send_message always returns 0, this patch doesn't touch anything about the failure path, and it also

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread Guoqing Jiang
Bob Peterson wrote: - Original Message - We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com --- fs/dlm/lock.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions

[Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com --- fs/dlm/lock.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 35502d4..6fc3de9 100644 --- a/fs/dlm/lock.c

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
Hi Bob, Bob Peterson wrote: - Original Message - We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com --- fs/dlm/lock.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/dlm/lock.c

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
Bob Peterson wrote: - Original Message - Hi Bob, Bob Peterson wrote: - Original Message - We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com --- fs/dlm/lock.c | 10 ++ 1 file