On Fri, May 29, 2020 at 02:09:43PM +0200, Christoph Hellwig wrote:
> No users left.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Marcelo Ricardo Leitner
Thanks.
> ---
> include/linux/net.h | 2 --
> net/socket.c| 31 ---
>
itch the dlm code to use the method instead of going through the
> socket option from kernel space.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Marcelo Ricardo Leitner
Even though checkpatch complained about bad alignment here:
> +static int sctp_bind_add(struct sock *sk
f-by: Christoph Hellwig
Acked-by: Marcelo Ricardo Leitner
> ---
> net/sctp/socket.c | 61 ++-
> 1 file changed, 28 insertions(+), 33 deletions(-)
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 827a9903ee288..6e74
On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote:
> Add a helper to directly set the SCTP_NODELAY sockopt from kernel space
> without going through a fake uaccess.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Marcelo Ricardo Leitner
I'm taking the action
On Thu, May 21, 2020 at 10:42:24AM +0200, Christoph Hellwig wrote:
> On Wed, May 20, 2020 at 08:00:25PM -0300, Marcelo Ricardo Leitner wrote:
> > > + if (err)
> > > + return err;
> > > +
> > > + lock_sock(sk);
> > > + err = sctp_do_bi
On Thu, May 21, 2020 at 10:34:42AM +0200, Christoph Hellwig wrote:
> On Wed, May 20, 2020 at 08:39:13PM -0300, Marcelo Ricardo Leitner wrote:
> > On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote:
> > > From: Marcelo Ricardo Leitner
> > > Date: Wed,
On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote:
> From: Marcelo Ricardo Leitner
> Date: Wed, 20 May 2020 20:10:01 -0300
>
> > The duplication with sctp_setsockopt_nodelay() is quite silly/bad.
> > Also, why have the 'true' hardcoded? It's what dlm uses, yes,
On Wed, May 20, 2020 at 09:55:07PM +0200, Christoph Hellwig wrote:
> Add a helper to directly set the SCTP_NODELAY sockopt from kernel space
> without going through a fake uaccess.
>
> Signed-off-by: Christoph Hellwig
> ---
> fs/dlm/lowcomms.c | 10 ++
> include/net/sctp/sctp.h |
On Wed, May 13, 2020 at 08:26:47AM +0200, Christoph Hellwig wrote:
> Add a helper to directly get the SCTP_PRIMARY_ADDR sockopt from kernel
> space without going through a fake uaccess.
Same comment as on the other dlm/sctp patch.
>
> Signed-off-by: Christoph Hellwig
> ---
> fs/dlm/lowcomms.c
On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote:
> And call it directly from dlm instead of going through kernel_setsockopt.
The advantage on using kernel_setsockopt here is that sctp module will
only be loaded if dlm actually creates a SCTP socket. With this
change, sctp will
e while closing connections")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
---
fs/dlm/lowcomms.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index
963016c8f3d12def89c9803eb9d124caa2385dc4..609998de533e89
From: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
Accepted or peeled off sockets were missing a security label (e.g.
SELinux) which means that socket was in "unlabeled" state.
This patch clones the sock's label from the parent sock and resolves the
issue (similar to AF_BL
Em 13-08-2015 06:37, Steven Whitehouse escreveu:
Hi,
On 12/08/15 17:42, Marcelo Ricardo Leitner wrote:
Em 12-08-2015 12:33, David Laight escreveu:
From: Marcelo Ricardo Leitner
Sent: 12 August 2015 14:16
Em 12-08-2015 07:23, David Laight escreveu:
From: Marcelo Ricardo Leitner
Sent: 11
Em 12-08-2015 07:23, David Laight escreveu:
From: Marcelo Ricardo Leitner
Sent: 11 August 2015 23:22
DLM is using 1-to-many API but in a 1-to-1 fashion. That is, it's not
needed but this causes it to use sctp_do_peeloff() to mimic an
kernel_accept() and this causes a symbol dependency on sctp
If we don't clear that bit, lowcomms_connect_sock() will not schedule
another attempt, and no further attempt will be done.
Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com
---
fs/dlm/lowcomms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm
is still raising the new data event. Probably a bug to be fixed in SCTP.
Reported-by: tan...@zte.com.cn
Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com
---
fs/dlm/lowcomms.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
be able to re-connect as lowcomms_connect_sock() will
check for it.
Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com
---
fs/dlm/lowcomms.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index
.
Many thanks,
Marcelo Ricardo Leitner (6):
dlm: fix connection stealing if using SCTP
dlm: fix race while closing connections
dlm: fix not reconnecting on connecting error handling
dlm: use sctp 1-to-1 API
dlm: replace BUG_ON with a less severe handling
dlm: fix reconnecting
is possible, but it
is intentionally left for a later commit.
Note that for using nodes with this commit, you have to have at least
the early fixes on this patchset otherwise it will trigger some issues
on old nodes.
Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com
---
fs/dlm/lowcomms.c
.
Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com
---
fs/dlm/lowcomms.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index
754fd6c0b7470bab272b071e6ca6e4969e4e4209..bc04f5e3af7ac5fe107a7a26555777364de8bc15
20 matches
Mail list logo
