Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-17 Thread David Teigland
On Thu, Feb 17, 2022 at 01:36:44AM +0100, Andreas Gruenbacher wrote: > On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote: > > > > - spin_lock(_lock); > > > > - if (!list_empty(>list)) { > > > > - log_error(ls, "dlm_posix_lock: op on list %llx", > > > > -

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-17 Thread Andreas Gruenbacher
On Thu, Feb 17, 2022 at 3:03 PM Alexander Aring wrote: > On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher > wrote: > > > > There's also an unnecessary INIT_LIST_HEAD() in send_op(). > > > > please send a patch in a form which makes it easy to apply. Also > please explain exactly why an

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-17 Thread Alexander Aring
Hi, On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher wrote: > > There's also an unnecessary INIT_LIST_HEAD() in send_op(). > please send a patch in a form which makes it easy to apply. Also please explain exactly why an "INIT_LIST_HEAD()" is not needed here rather than just stating that the

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-17 Thread Alexander Aring
Hi, On Wed, Feb 16, 2022 at 7:37 PM Andreas Gruenbacher wrote: > > On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote: > > > > Hi, > > > > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher > > wrote: > > > > > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring > > > wrote: > > > > There

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Andreas Gruenbacher
There's also an unnecessary INIT_LIST_HEAD() in send_op(). Andreas --- fs/dlm/plock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index ce1af7986e16..ff439d780cb1 100644 --- a/fs/dlm/plock.c +++ b/fs/dlm/plock.c @@ -67,7 +67,6 @@ static void

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Andreas Gruenbacher
On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote: > > Hi, > > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher > wrote: > > > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote: > > > There are several sanity checks and recover handling if they occur in > > > the dlm plock

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Alexander Aring
Hi, On Wed, Feb 16, 2022 at 11:25 AM Alexander Aring wrote: > > Hi, > > On Wed, Feb 16, 2022 at 11:16 AM Alexander Aring wrote: > > > > Hi, > > > > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher > > wrote: > > > > > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring > > > wrote: > > > >

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Alexander Aring
Hi, On Wed, Feb 16, 2022 at 11:16 AM Alexander Aring wrote: > > Hi, > > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher > wrote: > > > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote: > > > There are several sanity checks and recover handling if they occur in > > > the dlm plock

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Alexander Aring
Hi, On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher wrote: > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote: > > There are several sanity checks and recover handling if they occur in > > the dlm plock handling. They should never occur otherwise we have a bug > > in the code. To

Re: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON

2022-02-16 Thread Andreas Gruenbacher
On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote: > There are several sanity checks and recover handling if they occur in > the dlm plock handling. They should never occur otherwise we have a bug > in the code. To make such bugs more visible we remove the recover > handling and add a