Re: [Cluster-devel] [GFS2 Patch] GFS2: Add readahead to sequential directory traversal

2011-10-25 Thread Steven Whitehouse
Hi, On Mon, 2011-10-24 at 15:56 -0400, Bob Peterson wrote: > - Original Message - > | Hi, > | > | That looks much better, but why not create & pass a file_ra_state in > | the > | NFS getname function so that you don't have to check for it being > | NULL? > | Since that function always rea

[Cluster-devel] GFS2: Pull request (merge window)

2011-10-25 Thread Steven Whitehouse
Hi, Please consider pulling the following changes. These are at a temporary location pending getting my kernel.org account back again. If thats an issue, please let me know, otherwise I'm hoping that just signing this pull request should be enough for now. I included below what I hope is enough in

[Cluster-devel] [PATCH 03/19] ccs_tool: improve error checking on ccs_connect

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 28bbadc... a0fee9f... M config/tools/ccs_tool/ccs_tool.c config/tools/ccs_tool/ccs_tool.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/config/tools/ccs_tool/ccs_tool.c b/config/tools/

[Cluster-devel] [PATCH 12/19] config: fix return checks in ldap loader

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 fb25af4... 49c30b7... M config/plugins/ldap/configldap.c config/plugins/ldap/configldap.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/config/plugins/ldap/configldap.c b/config/plugins/l

[Cluster-devel] [PATCH 06/19] libccs: remove duplicate checks

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 703fa17... 3b2ab4b... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config/libs/libccsconfdb/fullxpath.c b/config

[Cluster-devel] [PATCH 02/19] ccs_config_dump: remove unnecessary pointer to env

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 74c33c2... 022777f... M config/tools/xml/ccs_config_dump.c config/tools/xml/ccs_config_dump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config/tools/xml/ccs_config_dump.c b/config/tools

[Cluster-devel] [PATCH 13/19] config: make sure error reporting does not overflow buffers

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 49c30b7... c9ba2bf... M config/plugins/ldap/configldap.c config/plugins/ldap/configldap.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config/plugins/ldap/configldap.c b/config/pl

[Cluster-devel] [PATCH 04/19] libccs: fix error checking

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 6a2b143... d9cddc0... M config/libs/libccsconfdb/libccs.c config/libs/libccsconfdb/libccs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/libs/libccsconfdb/libccs.c b/config/libs/l

[Cluster-devel] [PATCH 01/19] libccs: check return code consistently

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 577c74a... 703fa17... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/config/libs/libccsconfdb/fullxpath.c b

[Cluster-devel] [PATCH 10/19] config: fix extremely unlikely buffer overflow

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 541fed7... 12c5320... M config/libs/libccsconfdb/extras.c config/libs/libccsconfdb/extras.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/config/libs/libccsconfdb/extr

[Cluster-devel] [PATCH 05/19] configxml: clear variable usage

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 7dcf8ba... 9479bc2... M config/plugins/xml/config.c config/plugins/xml/config.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/config/plugins/xml/config.c b/config/plugins/xml/config

[Cluster-devel] [PATCH 11/19] config: fix a few theoretical buffer overflows

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 12c5320... 12536ae... M config/libs/libccsconfdb/extras.c config/libs/libccsconfdb/extras.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/libs/libccsconfdb/extras.c b/config/libs

[Cluster-devel] [coverity] config

2011-10-25 Thread Fabio M. Di Nitto
Original errors/warnings: Analysis summary report: Files analyzed : 21 Total LoC input to cov-analyze : 29195 Functions analyzed : 170 Paths analyzed : 10405 New defects found : 136 Total

[Cluster-devel] [PATCH 07/19] config: fix libccs return codes and errno handling

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 b0cf55b... 541fed7... M config/libs/libccsconfdb/extras.c :100644 100644 3b2ab4b... 6b2e138... M config/libs/libccsconfdb/fullxpath.c :100644 100644 d9cddc0... bfc2d29... M config/libs/libccsconfdb/libccs.c config/li

[Cluster-devel] [PATCH 08/19] config: improve string error checking in tokenizer

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 0a21f85... 710c176... M config/libs/libccsconfdb/xpathlite.c config/libs/libccsconfdb/xpathlite.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/config/libs/libccsconfdb/xp

[Cluster-devel] [PATCH 15/19] config: fix rng2ldif null reference

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 1de9181... 7a99417... M config/tools/ldap/rng2ldif/value-list.c config/tools/ldap/rng2ldif/value-list.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/config/tools/ldap/rng2ldif/value-list.c

[Cluster-devel] [PATCH 18/19] config: remove unused var in ccs_tool

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 a0fee9f... 34c4c1e... M config/tools/ccs_tool/ccs_tool.c config/tools/ccs_tool/ccs_tool.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/config/tools/ccs_tool/ccs_tool.c b/

[Cluster-devel] [PATCH 09/19] config: fix possible memory leak in libccs fullxpath usage

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 6b2e138... 8c4501f... M config/libs/libccsconfdb/fullxpath.c config/libs/libccsconfdb/fullxpath.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/config/libs/libccsconfdb/fullxpath

[Cluster-devel] [PATCH 17/19] config: fix confdb2ldif secure coding

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverify Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 35f8c31... 1f83c2f... M config/tools/ldap/confdb2ldif.c config/tools/ldap/confdb2ldif.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/config/tools/ldap/confdb2ldif.c b/config/tools/l

[Cluster-devel] [PATCH 14/19] config: make sure error reporting does not overflow buffers

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 9479bc2... a25df09... M config/plugins/xml/config.c config/plugins/xml/config.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/plugins/xml/config.c b/config/plugins/xml/config.c

[Cluster-devel] [PATCH 16/19] config: rng2ldif bug fixes

2011-10-25 Thread Fabio M. Di Nitto
several differnt memory leaks, missing checks and other minor issues. Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 7607714... dd69401... M config/tools/ldap/rng2ldif/genclass.c :100644 100644 6b24dd2... 635d4c8... M config/tools/ldap/rng2ldif/rng2ldif.c :100644

[Cluster-devel] [PATCH 19/19] config: fix a few checks in ccs_tool edit functionalities

2011-10-25 Thread Fabio M. Di Nitto
Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 fe52665... 9415506... M config/tools/ccs_tool/editconf.c config/tools/ccs_tool/editconf.c | 40 +++-- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git a/config/tools/ccs_t

[Cluster-devel] [PATCH] mount.gfs2: Fix error handlers

2011-10-25 Thread Carlos Maiolino
This patch removes some calls to die(), replacing them with perror(), and also removes some calls to warn(). In both cases, the replacement code aimed to better deal with i18n stuff. Signed-off-by: Carlos Maiolino --- gfs2/mount/mount.gfs2.c | 33 --- gfs2/mount/mtab.c

Re: [Cluster-devel] [PATCH] mount.gfs2: Fix error handlers

2011-10-25 Thread Carlos Maiolino
On Tue, Oct 25, 2011 at 02:22:52PM -0200, Carlos Maiolino wrote: > This patch removes some calls to die(), replacing them with perror(), > and also removes some calls to warn(). > In both cases, the replacement code aimed to better deal with i18n stuff. > mount.gfs2 is deprecated, please disconsid

Re: [Cluster-devel] [Upstream patch] DLM: Convert rsb data from linked list to rb_tree

2011-10-25 Thread David Teigland
Hi Bob, I've made a few minor/cosmetic changes and attached my current version (not tested yet). > static int shrink_bucket(struct dlm_ls *ls, int b) > { > + struct rb_node *n = NULL; > struct dlm_rsb *r; > int count = 0, found; > > for (;;) { > found = 0; >

Re: [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED

2011-10-25 Thread Lon Hohberger
On 09/19/2011 04:32 PM, Lon Hohberger wrote: > On 09/13/2011 04:44 AM, Kazunori INOUE wrote: > >> I attached the patch for this problem. >> >> * Modified to send a SIGHUP to the primary thread from the secondary >> thread detects the start of the VM, and >> the primary thread is modified s

Re: [Cluster-devel] [fence-virt PATCH] backend plugin for Pacemaker

2011-10-25 Thread Lon Hohberger
On 09/20/2011 03:40 AM, Kazunori INOUE wrote: > Hi, > > I created the backend "pm-fence" which has met the following > configurations / requirements. > - Both hosts and VMs, cluster (Pacemaker) have been configured. >* This backend has STONITH (fencing) function of the VM cluster. > - The VMs

Re: [Cluster-devel] [fence-virt PATCH] backend plugin for monitoring a host's status

2011-10-25 Thread Lon Hohberger
On 10/05/2011 04:56 AM, Kazunori INOUE wrote: > Hi all, > > I think that the communication function of fence-virt is flexible, > so I want to use it more effectively. > > Therefore I made backend plugin for a guest to get the host's status > using the communication facility of fence-virt, > and I

[Cluster-devel] Error when compiling dlm from cman

2011-10-25 Thread Nick Khamis
Hello Everyone, I am attempting to provide ocfs2 dlm and fencing support for our pacemaker cluster. I recieve an error when configuring using: ./configure --prefix=/usr/local --without_cman --corosyncincdir=/usr/include/corocync --corosynclibdir=/usr/var/lib/corosync openaisincdir=/usr/include/op

Re: [Cluster-devel] Error when compiling dlm from cman

2011-10-25 Thread Bob Peterson
- Original Message - | Hello Everyone, | | I am attempting to provide ocfs2 dlm and fencing support for our | pacemaker cluster. I recieve an error when configuring using: (snip) | /usr/bin/ld: cannot find -lcman Hi Nick, Sounds like the clusterlib-devel package is missing from your sys

Re: [Cluster-devel] Error when compiling dlm from cman

2011-10-25 Thread Fabio M. Di Nitto
On 10/26/2011 03:47 AM, Nick Khamis wrote: > Hello Everyone, > > I am attempting to provide ocfs2 dlm and fencing support for our > pacemaker cluster. I recieve an error when configuring using: > > ./configure --prefix=/usr/local --without_cman You need to drop --without_cman. Those flags have t