Re: [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory

2011-03-23 Thread Steven Whitehouse
Hi, On Wed, 2011-03-23 at 09:55 -0400, Bob Peterson wrote: > - Original Message - > | Hi, > | > | We still need that, it is the generation number for NFS. Although it > | is > | also identical to the no_formal_ino in recent kernels, > | > | Steve. > > Are you saying that nfs manipulates

Re: [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory

2011-03-23 Thread Bob Peterson
- Original Message - | Hi, | | We still need that, it is the generation number for NFS. Although it | is | also identical to the no_formal_ino in recent kernels, | | Steve. Are you saying that nfs manipulates gfs2's i_generation value in the incore gfs2_inode structure? If so, that scar

Re: [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory

2011-03-23 Thread Steven Whitehouse
Hi, We still need that, it is the generation number for NFS. Although it is also identical to the no_formal_ino in recent kernels, Steve. On Wed, 2011-03-23 at 09:37 -0400, Bob Peterson wrote: > Hi, > > Since GFS2 doesn't rely upon generation numbers like GFS1, we do not > need to copy the gene

[Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory

2011-03-23 Thread Bob Peterson
Hi, Since GFS2 doesn't rely upon generation numbers like GFS1, we do not need to copy the generation number into memory and out of memory. This patch eliminates the variable from the in-core structure and will reduce the memory requirements of GFS2. Regards, Bob Peterson Red Hat File Systems Si

[Cluster-devel] [PATCH] Updates to fencing.py to allow for virtual machine fencing.

2011-03-23 Thread mattjclark0407
From: Matt Clark Added all_opt parameters to aid in the fencing of virtual machines. Specifically this is for the fencing of machines through the XenAPI (Citrix XenServer or Xen Cloud Platform). New parameters are session_url, vm_name and uuid. Updated logic to now check if either an IP addre

Re: [Cluster-devel] [GFS2 PATCH] gfs2: move function foreach_leaf to gfs2_dir_exhash_dealloc

2011-03-23 Thread Steven Whitehouse
Hi, Ah, I see. I should have read this patch before replying to the first :-) This patch set looks very good. I'll push them into -nmw just as soon as -rc1 is out, Steve. On Tue, 2011-03-22 at 13:56 -0400, Bob Peterson wrote: > Hi, > > gfs2: move function foreach_leaf to gfs2_dir_exhash_dealloc

Re: [Cluster-devel] [GFS2 PATCH] gfs2: pass leaf_bh into leaf_dealloc

2011-03-23 Thread Steven Whitehouse
Hi, Looks good, Steve. On Tue, 2011-03-22 at 13:55 -0400, Bob Peterson wrote: > Hi, > > Function foreach_leaf used to look up the leaf block address and get > a buffer_head. Then it would call leaf_dealloc which did the same > lookup. This patch combines the two operations by making foreach_l

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Combine transaction from gfs2_dir_exhash_dealloc

2011-03-23 Thread Steven Whitehouse
Hi, Looks good, Steve. On Tue, 2011-03-22 at 13:54 -0400, Bob Peterson wrote: > Hi, > > At the end of function gfs2_dir_exhash_dealloc, it was setting the dinode > type to "file" to prevent directory corruption in case of a crash. > It was doing so in its own journal transaction. This patch ma

Re: [Cluster-devel] [GFS2 PATCH] gfs2: remove *leaf_call_t and simplify leaf_dealloc

2011-03-23 Thread Steven Whitehouse
Hi, Looks good, but a couple of comments... On Tue, 2011-03-22 at 13:52 -0400, Bob Peterson wrote: > Hi, > > Since foreach_leaf is only called with leaf_dealloc as its only possible > call function, we can simplify the code by making it call leaf_dealloc > directly. This simplifies the code and