On Tue, 2007-08-21 at 10:38 -0400, Wendy Cheng wrote:
Trivial change ... Wendy
Wendy / Abhi,
Can we please change this to have 0x in front?
+ print_dbg(gi, Glock 0x%p (%u, 0x%llx)\n, gl, gl-gl_name.ln_type,
That'll make it more user-friendly to paste into gfs2_edit.
Bob
enough to
generate enough debugging information for gdb.
Please ACK or apply.
Fabio
PS The patch depends on the previous Makefile cleanup I posted on the mailing
list right before this one.
ACK, but I only looked at the defaults and the gfs2 userland bits.
Regards,
Bob Peterson
The problem boiled down to a race between the gdlm_init_threads()
function initializing thread1 and its setting of blist = 1.
Essentially, if (current == ls-thread1) was checked by the thread
before the thread creator set ls-thread1.
Since thread1 is the only thread who is allowed to work on the
of the
loop that was recreating the failure and it seems to work.
Dave Teigland brought up the question of whether we should do this
another way. For example, by checking for the task name lock_dlm1
instead. I'm open to opinions.
--
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
diff -pur
name lock_dlm1
instead. I'm open to opinions.
--
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
diff -pur a/fs/gfs2/locking/dlm/thread.c b/fs/gfs2/locking/dlm/thread.c
--- a/fs/gfs2/locking/dlm/thread.c 2007-09-13 17:33:58.0 -0500
+++ b/fs/gfs2/locking/dlm/thread.c 2007-09-14
Hi,
This patch changes the /sys/fs/gfs2/s_id/id file to give the device
id major:minor rather than the s_id. That enables gfs2_tool to
match devices properly (by id, not name) when locating the tuning files.
Regards,
Bob Peterson
--
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2
, would be a NULL string. The quota tool should
be changed to use the same interface as gfs2_tool to determine
the proper path in sysfs. Perhaps I'll open a bugzilla record on it.
Regards,
Bob Peterson
Red Hat Cluster Suite
block operation,
this streamlines the code and makes it a little bit more efficient.
Regards,
Bob Peterson
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/bmap.c|8
fs/gfs2/bmap.h|2 +-
fs/gfs2/log.c |2 +-
fs/gfs2/ops_address.c | 30
fetch the dinode once in block_map
8. Only find indirect pointer buffers once in block_map
9. Move meta_inval to glops.c and declare static, more attach_bufdata
to trans.c and declare static.
10. Function meta_read optimization.
Regards,
Bob Peterson
Red Hat GFS
,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/incore.h | 11 +++-
fs/gfs2/log.c| 22 ++-
fs/gfs2/ops_fstype.c | 68 +-
fs/gfs2/super.c | 13 -
4 files changed, 97
. The compiler
optimizes that quite well and we save some time, especially when running
through full bitmaps (like the bitmaps allocated for the journals).
There's probably a more elegant or optimized way to do this, but I haven't
thought of it yet. I'm open to suggestions.
Regards,
Bob Peterson
Red Hat
Hi,
Function gfs2_block_map was often looking up the disk inode twice.
This optimizes it so that only does it once.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
.../fs/gfs2/bmap.c | 14 +++---
1 files changed, 7
Hi,
This patch doesn't change any code, it just moves it around.
Function gfs2_meta_inval is moved from meta_io.c to glops.c
and function gfs2_attach_bufdata is moved from meta_io,c
to trans.c. Both functions are then declared static.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob
Hi,
This patch optimizes function gfs2_meta_read. Basically, gfs2_meta_wait
was being called regardless of whether a disk read was requested.
This just pulls that wait into the if that triggers the read.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED
at
all, which I assume was the purpose of the mutex in the first place.
I'm not sure this is buying us much anyway, so perhaps we should forget
it.
Regards,
Bob Peterson
for patch3 for the compile
error.
Note that the previous patch3 I sent also had some leftover useless
debug code in it (regarding static int c) which needed to be taken out.
Regards,
Bob Peterson
--
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
.../fs/gfs2/rgrp.c
Hi,
Here is a patch for the latest upstream GFS2 code:
The journal extent map needs to be initialized sooner than it
currently is. Otherwise failed mount attempts (e.g. not enough
journals, etc.) may panic trying to access the uninitialized list.
Regards,
Bob Peterson
Signed-off-by: Bob
will be required. Benchmarks like
iozone should see better performance.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/bmap.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 73dfad7
Hi,
This patch removes a vestigial variable i_spin from the gfs2_inode
structure. This not only saves us memory (30 of these in memory
for the oom test) it also saves us time because we don't have to
spend time initializing it (i.e. slightly better performance).
Regards,
Bob Peterson
Red
.
Regards,
Bob Peterson
Red Hat GFS
Hi,
I spotted this bug while I was digging around. Looks like it could cause
a lockup in some rare error condition.
Regards,
Bob Peterson
--
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/inode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2
Hi,
I noticed that the latest change to i_height got rid of the
value from the inode dump. This patch adds it back.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/inode.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff
only need to call it once,
we can also make it faster by removing it from the generic lops
code and making it a stand-along static function.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/incore.h |1 -
fs/gfs2/log.c | 17
Hi,
This patch contains two small fixups that didn't fit elsewhere.
They are: (1) get rid of temp variable in find_metapath.
(2) Remove vestigial ret variable from gfs2_writepage_common.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/bmap.c
--
fs/gfs2/lops.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 7138737..4390f6f 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd,
unsigned int start,
Hi,
This patch moves the gfs2_rgrpd structure to its own slab
memory. This makes it easier to control and monitor, and
yields less memory fragmentation.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/main.c | 10 ++
fs/gfs2/rgrp.c
Hi,
This patch reduces memory by replacing the int variable
gl_waiters2 by a single bit in the gl_flags.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/glock.c |7 ---
fs/gfs2/incore.h |4 ++--
2 files changed, 6 insertions(+), 5
of routines which scan bitmaps where we can
mark the bitmaps const, plus a couple of call sites that can
be updated too.
Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
ACK fwiw
Regards,
Bob Peterson
function shares the
struct metapath, but currently still frees its own buffers, and
this will change in a future patch.
Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
ACK fwiw
Regards,
Bob Peterson
This is required to enable future changes to the block
mapping code.
Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
ACK fwiw
Regards,
Bob Peterson
are correct, the rest of the code changes are mostly
just direct substitutions.
So take it or leave it as you see fit.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/eattr.c | 19 ++--
fs/gfs2/glock.c | 39
Hi,
This version of the gfs2_bitfit algorithm is up to four
times faster than its predecessor.
Regards,
Bob Peterson
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/rgrp.c | 79 +--
1 files changed, 47 insertions(+), 32 deletions
the right
conditions, I've seen peaks of 20 times faster.
Regards,
Bob Peterson
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/rgrp.c | 93 ---
1 files changed, 61 insertions(+), 32 deletions(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2
On Wed, 2008-03-19 at 06:12 +0100, Fabio M. Di Nitto wrote:
Is this commit suitable for master / STABLE2 branch?
Thanks
Fabio
Hi Fabio,
Done for both fixes; sorry about that. I'm still getting used
to how we are supposed to do things in git.
Regards,
Bob Peterson
by hash-key if the glock in
question is on the reclaim list because you can't guarantee
the thing won't go away at an inconvenient time.
Previous instrumentation indicated this was happening.
Regards,
Bob Peterson
--
diff -pur a/fs/gfs2/glock.c b/fs/gfs2/glock.c
--- a/fs/gfs2/glock.c 2008-02-22
Obviously the subject should read RHEL5, not RHEL4, since
this is gfs2. I'm making this distinction because I don't
want it to be mistaken for a patch to the upstream gfs2.
Hi,
This patch makes the glock dump a little more user-friendly.
My primary goal was to get rid of the very-misleading report
of the glock being (unlocked) based on gl_flag, but it goes
a step further. If it's too verbose, feel free to say no.
Regards,
Bob Peterson
--
fs/gfs2/glock.c | 34
the glock in the hash table,
which involves locking the hash table and possible contention.
Regards,
Bob Peterson
Red Hat Clustering GFS
--
fs/gfs2/dir.c|3 ++-
fs/gfs2/inode.c | 18 --
fs/gfs2/inode.h |3 ++-
fs/gfs2/ops_export.c |2 +-
fs/gfs2
kernel and don't believe this affects RHEL.
Regards,
Bob Peterson
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/ops_super.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/ops_super.c b/fs/gfs2/ops_super.c
index 0b7cc92..6690792 100644
--- a/fs/gfs2
Adrian
Hi,
This appears to be a known bug. There's a Fedora bugzilla record for
it here, which contains a patch to fix the problem:
https://bugzilla.redhat.com/show_bug.cgi?id=448866
The bug does not appear to be in 2.6.25; 2.6.25 is fine afaict.
Regards,
Bob Peterson
Red Hat GFS
Whitehouse, and he is on vacation/holiday until
tomorrow.
I've submitted the patch to cluster-devel, so hopefully he'll push it
as soon as he returns tomorrow.
Regards,
Bob Peterson
Red Hat GFS
This patch fixes a problem whereby simultaneous delete operations
(e.g. rm -fR *) from multiple nodes on the same GFS2 file system
can cause kernel panics, hangs, and/or memory corruption.
Regards,
Bob Peterson
Signed-off-by: Bob Peterson [EMAIL PROTECTED]
--
fs/gfs2/ops_inode.c | 24
list of blocks had been
| fixed.
|
| Regards,
|
| Stewart
Hi Stewart,
You should be able to do: gfs_fsck -y /dev/your/device and it will
answer 'y' to all the questions. This is similar to other fscks.
You can also use -n to answer 'no' to all questions.
Regards,
Bob Peterson
Red Hat GFS
,
An a (all) answer to the yes/no questions is certainly easy to do.
I've thought about doing it, too, but AFAIK, none of the other fscks
allow this response. I'll ask around and see if anyone objects.
Regards,
Bob Peterson
Red Hat GFS
) == 0)
| + continue;
| +
| /* Test for being demotable */
| if (!test_and_set_bit(GLF_LOCK, gl-gl_flags)) {
| gfs2_glock_hold(gl);
Hi,
ACKed by Bob Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
getting rid of the mount.gfs2 helper
altogether upstream.
Bob Peterson
| explained,
|
| Steve.
Hi Steve,
Good writeup. Here are some minor suggestions.
Bob Peterson
--
--- /home/msp/rpeterso/gfs_uevents.orig.txt 2009-08-13 10:02:25.0
-0500
+++ /home/msp/rpeterso/gfs_uevents.bobs.txt 2009-08-13 10:10:33.0
-0500
@@ -1,9 +1,9
7
| --
| 1.6.3.3
Hi,
ACKed by Bob Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
| gfs2_quota *q)
| {
| /* seek to the appropriate offset in the quota file and read the
| --
| 1.6.3.3
Hi,
ACKed by Bob Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
) but this will work.
ACKed by Bob Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
(struct gfs2_sbd *sbp, int block_em)
| {
| if(block_em) {
| /* verify it starts with lock_ */
| --
| 1.6.3.3
Hi,
ACKed by Bob Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
-serious gfs2 file
system error occurs. This may be useful, for example, where
fabric-level fencing is used that has no way to reboot (such as
fence_scsi).
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/incore.h |7 +++
fs/gfs2/ops_fstype.c
nuked.
Just a theory at this point but perhaps Steve Whitehouse can tell.
Regards,
Bob Peterson
Red Hat File Systems
--
fs/gfs2/aops.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 7ebae9a..6a23ba2 100644
--- a/fs/gfs2/aops.c
+++ b
Hi,
This patch changes glock numbers from printing in decimal to hex.
Since DLM prints corresponding resource IDs in hex, it makes debugging
easier.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/glock.c |2 +-
1 files changed, 1 insertions
to update your clusters.
Sorry, guys, but we've discovered a problem with mkfs.gfs2 that makes
it impossible to create gfs2 file systems. The problem has been fixed
in the STABLE3 and master branches of the git repos, and 3.0.9 will be
released very soon.
Regards,
Bob Peterson
Red Hat File
Peterson rpete...@redhat.com
Regards,
Bob Peterson
Red Hat File Systems
Hi,
Here is a patch for bugzilla bug #570182. Explanation in the
patch.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
Author: Bob Peterson b...@krishna.(none)
Date: Tue Apr 13 08:49:33 2010 -0500
GFS2: glock livelock
This patch fixes
Hi,
This patch removes an unneeded err variable that is always
returned as zero.
Regards,
Bob Peterson
Red Hat File Systems
--
fs/gfs2/meta_io.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index abafda1..18176d0 100644
Hi,
This patch changes the lock ordering when gfs2 reclaims
unlinked dinodes, thereby avoiding a livelock.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
GFS2: stuck in inode wait, no glocks stuck
This patch changes the lock ordering when gfs2 reclaims
Hi,
The previous patch I wrote for reclaiming unlinked dinodes
had some shortcomings and did not prevent all hangs.
This version is much cleaner and more logical, and has
passed very difficult testing. Sorry for the churn.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete
memory for the
glock. In some circumstances, it would cause dlm's dlm_astd daemon
to try to call the bast function for the freed lock_dlm memory,
which resulted in a NULL pointer dereference.
This problem was discovered while testing bugzilla bug #595397.
Regards,
Bob Peterson
Red Hat GFS
Signed
- Steven Whitehouse swhit...@redhat.com wrote:
| Hi,
|
| Now in the -nmw GFS2 tree. Thanks,
|
| Steve.
|
| On Tue, 2010-06-15 at 12:07 -0400, Bob Peterson wrote:
| Hi,
|
| This patch fixes a problem in an error path when looking
| up dinodes. There are two sister-functions
Hi,
This patch replaces a statement that got dropped out by accident.
Without the patch, truncates on stuffed (very small) files cause
those files to have an unpredictable size.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/bmap.c
passing
that value in, which in turn simplifies a bunch of error checking.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/aops.c |4 +---
fs/gfs2/bmap.c | 15 +--
fs/gfs2/bmap.h |2 +-
fs/gfs2/file.c |4 +---
fs/gfs2
is
reused, not just the free space portion of it, and therefore
the function gfs2_dirent_find_space should use the value 0
rather than GFS2_DIRENT_SIZE(0) for the actual dirent size.
Fixing this calculation enables the reproducer programs to work
properly.
Regards,
Bob Peterson
Red Hat GFS
Signed-off
with the system statfs file.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/rgrp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 25dbe5c..7293ea2 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2
Hi,
This patch is a performance improvement for GFS2 in a clustered
environment. It makes the glock hold time self-adjusting.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
Bouncing locks in a cluster is slow in GFS2
--
fs/gfs2/glock.c | 89
. It makes the glock hold time self-adjusting.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
Bouncing locks in a cluster is slow in GFS2
--
[Cluster-devel] [PATCH][GFS2] Bouncing locks in a cluster is slow in GFS2
fs/gfs2/glock.c | 39
of the cluster infrastructure.
However, we don't recommend that many nodes for various reasons.
For one thing, your network may be clogged with lots of traffic,
which may interfere with proper cluster communications.
Regards,
Bob Peterson
Red Hat File Systems
unlinks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/bmap.c | 20 +++-
fs/gfs2/rgrp.c | 34 +++---
fs/gfs2/rgrp.h |2 ++
3 files changed, 48 insertions(+), 8 deletions(-)
diff --git a/fs
Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs/gfs2/glock.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 3f45a14..8648409 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
of gfs2_delete_inode
waiting for the glock, which is held by the first. The solution is to
add a new non_block parameter to the gfs2_iget function that causes it
to return -ENOENT if the inode is being freed.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
fs
the directory leaf deallocation code.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 5c356d0..10a4bbe 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -82,11 +82,11 @@
struct qstr gfs2_qdot
the directory dinode at that time anyway.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 10a4bbe..6791e49 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -86,7 +86,7 @@ typedef int (*gfs2_dscan_t
Hi,
Function foreach_leaf used to look up the leaf block address and get
a buffer_head. Then it would call leaf_dealloc which did the same
lookup. This patch combines the two operations by making foreach_leaf
pass the leaf bh to leaf_dealloc.
Regards,
Bob Peterson
Red Hat File Systems
Signed
Hi,
Since GFS2 doesn't rely upon generation numbers like GFS1, we do not
need to copy the generation number into memory and out of memory.
This patch eliminates the variable from the in-core structure and
will reduce the memory requirements of GFS2.
Regards,
Bob Peterson
Red Hat File Systems
by only transitioning the
Pending demote bit to the demote flag once we know the
other conditions (not unlocked and not exclusive) are met.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
--
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index a2a6abb
Hi,
This is a rebase of a patch I sent on January 26, 2011.
Now that we've resolved the other pending issues blocking
this one, I'm submitting it again.
This patch is a performance improvement for GFS2 in a clustered
environment. It makes the glock hold time self-adjusting.
Regards,
Bob
-by: Nathan Straz nst...@redhat.com
Hi,
Looks good. ACK.
Bob Peterson
Red Hat File Systems
| Reported-by: Nathan Straz nst...@redhat.com
| ---
Hi,
ACK,
Regards,
Bob Peterson
Red Hat File Systems
by Steve
| ---
Hi Carlos,
Looks good. ACK.
Bob Peterson
Red Hat File Systems
savemeta, gzip the
output, and send me a link where I can download it.
Regards,
Bob Peterson
Red Hat File Systems
From f4326def0744e6a01a5e7665eb4f8261d6996af7 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 08:41:36 -0500
Subject: [PATCH 01/44] fsck.gfs2: Make functions consistently use sdp rather
than sbp
For years, the fsck.gfs2 tool used two different variable names
From e85543c0c03fcaeb4ada7ee7b4ecbef361b16ffc Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 10:48:35 -0500
Subject: [PATCH 04/44] libgfs2: Make check_sb and read_sb operate on gfs1
file systems
This patch adds allow_gfs1 parameters to the read_sb
From 32a60225151e08ec6291e43dec2ab8ac7f24db21 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 09:45:36 -0500
Subject: [PATCH 03/44] libgfs1: Add a centralized gfs1 variable to superblock
variables
This patch adds a gfs1 variable to the in-core superblock
From e02f2523bfd3b3cc12b07cabdcc388b88c0ba769 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 11:23:47 -0500
Subject: [PATCH 05/44] libgfs2: add generic risize function, move gfs1
structures to libgfs2
This patch moves a number of gfs1-specific structures
From 7bb269a5158f81c6c5d9190c4f76d73a83e3c9d7 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 12:46:29 -0500
Subject: [PATCH 06/44] fsck.gfs2: Check for blocks wrongly inside resource
groups
It's not enough to range_check blocks in order to call them valid
From a2fc75cad03602f8582a744c6a14ddae3a85cffd Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 12:58:04 -0500
Subject: [PATCH 07/44] fsck.gfs2: Rename function check_leaf to
check_ealeaf_block
This patch renames function check_leaf_block to check_ealeaf_block
From dfa63a3b56e71b8607098cb02e5162fc01aa8bab Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 13:28:08 -0500
Subject: [PATCH 08/44] fsck.gfs2: eliminate vestigial buffer_head variable in
check_leaf
This patch eliminates a variable bh from all the check_leaf
From 55e442c79adec0fa7f6d4e7f6700f14a630d4e3e Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:01:18 -0500
Subject: [PATCH 09/44] fsck.gfs2: Rename the nlink functions to make them
more intuitive
Part of fsck's checks is to verify the count of links
From da57639e65b148bb4d2a3c6a9d98623b8ad18b04 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:21:06 -0500
Subject: [PATCH 10/44] fsck.gfs2: Keep di_nlink in sync when adding links for
lost+found
When adding a .. entry to a directory newly linked to lost
From 0dc5622515a2e888efd89cb33e7c2fe600f895a5 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:38:19 -0500
Subject: [PATCH 11/44] fsck.gfs2: directory entry count was only 16 bits in
check_entries
When counting directory links, fsck.gfs2 was using a 16-bit
From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:44:46 -0500
Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
This patch changes the logic of the code from being triple-negative
to single
From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:47:49 -0500
Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
This patch adds a call to bmodified to function dirent_repair. Without
From 0307db694e7316ab93071239704428ba5e346fcb Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 15:16:01 -0500
Subject: [PATCH 14/44] fsck.gfs2: Ask to reclaim unlinked meta on a per-rgrp
basis only
Before this patch, fsck.gfs2 would ask for every unlinked
From 37b96d287c82e81b5626948a80b52d62bb2b8612 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 15:44:19 -0500
Subject: [PATCH 15/44] fsck.gfs2: Factor out function to add .. entry when
linking to lost+found
This function factors out a section of code from
From 97b0253e2347b87f29ecf5d5fefbb08655358bb2 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:11:48 -0500
Subject: [PATCH 16/44] libgfs2: Use __FUNCTION__ rather than __FILE__ for
debug messages
This patch changes the debug output of gfs2-utils to use
From 0f424f6c6a2b4fda8c5b9b2bc1cb246d868d3fec Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:20:14 -0500
Subject: [PATCH 17/44] fsck.gfs2: Don't stop invalidating blocks if an
invalid one is found
When fsck found a duplicate reference to a block
From 50e59f2cd489e7b0200bb098f1c11c30977d5e28 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:44:47 -0500
Subject: [PATCH 18/44] fsck.gfs2: Find and clear duplicate references that
are leaf blocks
Duplicate references that were in leaf blocks were never
From ce30310b12df03b34d1e430e69e483bf1ee10b64 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 10:08:21 -0500
Subject: [PATCH 21/44] fsck.gfs2: split function check_leaf_blks to make it
more understandable
This patch splits function check_leaf_blks into two
1 - 100 of 2233 matches
Mail list logo
