Re: [Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map" (2)

2018-03-05 Thread Bob Peterson
- Original Message - | It turns out that commit 3229c18c0d6b2 'Fixes to "Implement iomap for | block_map"' introduced another bug in gfs2_iomap_begin that can cause | gfs2_block_map to set bh->b_size of an actual buffer to 0. This can | lead to arbitrary incorrect behavior including

[Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map" (2)

2018-03-05 Thread Andreas Gruenbacher
It turns out that commit 3229c18c0d6b2 'Fixes to "Implement iomap for block_map"' introduced another bug in gfs2_iomap_begin that can cause gfs2_block_map to set bh->b_size of an actual buffer to 0. This can lead to arbitrary incorrect behavior including crashes or disk corruption. Revert the

Re: [Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map"

2018-02-13 Thread Bob Peterson
- Original Message - | It turns out that commit 3974320ca6 "Implement iomap for block_map" | introduced a few bugs that trigger occasional failures with xfstest | generic/476: | | In gfs2_iomap_begin, we jump to do_alloc when we determine that we are | beyond the end of the allocated

[Cluster-devel] [PATCH] gfs2: Fixes to "Implement iomap for block_map"

2018-02-05 Thread Andreas Gruenbacher
It turns out that commit 3974320ca6 "Implement iomap for block_map" introduced a few bugs that trigger occasional failures with xfstest generic/476: In gfs2_iomap_begin, we jump to do_alloc when we determine that we are beyond the end of the allocated metadata (height > ip->i_height). There, we