Re: [Cluster-devel] [PATCH 09/11] gfs2: Read bitmap buffers on demand

2019-01-14 Thread Bob Peterson
- Original Message - > Before this patch, when locking a resource group, gfs2 would read in the > resource group header and all the bitmap buffers of the resource group. > Those buffers would then be locked into memory until the resource group > is unlocked, which will happen when the

Re: [Cluster-devel] [PATCH 10/11] gfs2: Clean up assertion, consistency check, and error reporting functions

2019-01-14 Thread Bob Peterson
- Original Message - > Instead of passing the __func__, __FILE__, and __LINE__ pre-processor macros > to > each of those functions, print the location of the caller via: > > printk(%pS", (void *)_RET_IP_). > > This gives enough context information to locate where in the code an error >

Re: [Cluster-devel] [PATCH 11/11] gfs2: Skip gfs2_metatype_check for cached buffers

2019-01-14 Thread Bob Peterson
- Original Message - > When reading in buffers from disk, set a new BH_Verify buffer head flag. In > gfs2_metatype_check, skip the check if BH_Verify is cleared and clear the > flag > when checking. That way, we'll only check the metatype once when reading > buffers from disk, and not

Re: [Cluster-devel] [PATCH 09/11] gfs2: Read bitmap buffers on demand

2019-01-14 Thread Andreas Gruenbacher
Bob, On Mon, 14 Jan 2019 at 18:12, Bob Peterson wrote: > - Original Message - > > Before this patch, when locking a resource group, gfs2 would read in the > > resource group header and all the bitmap buffers of the resource group. > > Those buffers would then be locked into memory until

Re: [Cluster-devel] [PATCH 09/11] gfs2: Read bitmap buffers on demand

2019-01-14 Thread Andreas Gruenbacher
On Mon, 14 Jan 2019 at 19:41, Andreas Gruenbacher wrote: > > Bob, > > On Mon, 14 Jan 2019 at 18:12, Bob Peterson wrote: > > - Original Message - > > > Before this patch, when locking a resource group, gfs2 would read in the > > > resource group header and all the bitmap buffers of the

Re: [Cluster-devel] [PATCH V13 00/19] block: support multi-page bvec

2019-01-14 Thread Jens Axboe
On 1/11/19 4:01 AM, Ming Lei wrote: > Hi, > > This patchset brings multi-page bvec into block layer: > > 1) what is multi-page bvec? > > Multipage bvecs means that one 'struct bio_bvec' can hold multiple pages > which are physically contiguous instead of one single page used in linux > kernel