Re: [Cluster-devel] [GFS2 PATCH 2/2] gfs2: Use async glocks for rename

2019-08-15 Thread Bob Peterson
I just noticed the parameter comments for gfs2_glock_async_wait are wrong, and I've fixed them in a newer version. I can post the new version after I get people's initial reactions. Bob - Original Message - > Because s_vfs_rename_mutex is not cluster-wide, multiple nodes can > reverse

[Cluster-devel] [GFS2 PATCH 1/2] gfs2: separate holder for rgrps in gfs2_rename

2019-08-15 Thread Bob Peterson
Before this patch, gfs2_rename added a holder for the rgrp glock to its array of holders, ghs. There's nothing wrong with that, but this patch separates it into a separate holder. This was done to ensure it's always locked last as per the proper glock lock ordering, and also to pave the way for a

[Cluster-devel] [GFS2 PATCH 2/2] gfs2: Use async glocks for rename

2019-08-15 Thread Bob Peterson
Because s_vfs_rename_mutex is not cluster-wide, multiple nodes can reverse the roles of which directories are "old" and which are "new" for the purposes of rename. This can cause deadlocks where two nodes can lock old-then-new but since their roles are reversed, they wait for each other. This

[Cluster-devel] [GFS2 PATCH 0/2] gfs2: gfs2_rename lock ordering

2019-08-15 Thread Bob Peterson
These two patches fix a gfs2 deadlock with gfs2_rename. Comments for vfs function vfs_rename() explain situations in which AB-BA deadlocks are possible, but prevented by a mutex, s_vfs_rename_mutex. While that's all true at a single-node level, gfs2 can make processes running on two distinct

Re: [Cluster-devel] [GFS2 PATCH 2/2] gfs2: Use async glocks for rename

2019-08-15 Thread Steven Whitehouse
Hi, On 15/08/2019 14:41, Bob Peterson wrote: I just noticed the parameter comments for gfs2_glock_async_wait are wrong, and I've fixed them in a newer version. I can post the new version after I get people's initial reactions. Bob Overall this looks like a much better approach. We know that

Re: [PATCH v5 03/18] gfs2: add compat_ioctl support

2019-08-15 Thread Bob Peterson
- Original Message - > Out of the four ioctl commands supported on gfs2, only FITRIM > works in compat mode. > > Add a proper handler based on the ext4 implementation. > > Fixes: 6ddc5c3ddf25 ("gfs2: getlabel support") > Signed-off-by: Arnd Bergmann > --- > fs/gfs2/file.c | 24

[Cluster-devel] [PATCH v4] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Mark Salyzyn
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path. This handles the case of a union filesystem driver that is being requested by the security layer to report back the xattr data.

Re: [Cluster-devel] [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Jan Kara
On Wed 14-08-19 07:54:16, Mark Salyzyn wrote: > On 8/14/19 4:00 AM, Jan Kara wrote: > > On Tue 13-08-19 07:55:06, Mark Salyzyn wrote: > > ... > > > diff --git a/fs/xattr.c b/fs/xattr.c > > > index 90dd78f0eb27..71f887518d6f 100644 > > > --- a/fs/xattr.c > > > +++ b/fs/xattr.c > > ... > > >

[GIT PULL] iomap: small fixes for 5.3-rc5

2019-08-15 Thread Darrick J. Wong
Hi Linus, Here's a single update to the MAINTAINERS entry for iomap. I test-merged it with this morning's master and didn't see any conflicts. Please let me know if you encounter any funniness. --D The following changes since commit 609488bc979f99f805f34e9a32c1e3b71179d10b: Linux 5.3-rc2

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread James Morris
On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: > On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > > --- a/include/linux/xattr.h > > +++ b/include/linux/xattr.h > > @@ -30,10 +30,10 @@ struct xattr_handler { > > const char *prefix; > > int flags; /* fs private flags */

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread James Morris
On Thu, 15 Aug 2019, Mark Salyzyn wrote: > Good Idea, but using the same argument structure for set and get I would be > concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. > struct getxattr_args { > struct dentry *dentry; > struct inode

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Mark Salyzyn
On 8/15/19 12:20 PM, James Morris wrote: On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: --- a/include/linux/xattr.h +++ b/include/linux/xattr.h @@ -30,10 +30,10 @@ struct xattr_handler { const char *prefix; int

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2019 at 05:20:36AM +1000, James Morris wrote: > On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: > > > On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > > > --- a/include/linux/xattr.h > > > +++ b/include/linux/xattr.h > > > @@ -30,10 +30,10 @@ struct xattr_handler { >

Re: [GIT PULL] iomap: small fixes for 5.3-rc5

2019-08-15 Thread pr-tracker-bot
The pull request you sent on Thu, 15 Aug 2019 10:10:24 -0700: > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/iomap-5.3-fixes-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4ec1fa692dc7dc915c3485a7fad928924fc13de2 Thank you! -- Deet-doot-dot, I am a bot.