Re: [Cluster-devel] [GFS2] glock dump with hex lock name

2007-08-21 Thread Bob Peterson
On Tue, 2007-08-21 at 10:38 -0400, Wendy Cheng wrote: Trivial change ... Wendy Wendy / Abhi, Can we please change this to have 0x in front? + print_dbg(gi, Glock 0x%p (%u, 0x%llx)\n, gl, gl-gl_name.ln_type, That'll make it more user-friendly to paste into gfs2_edit. Bob

[Cluster-devel] [PATCH] GFS2: Patch to protect sd_log_num_jdata

2007-08-22 Thread Bob Peterson
== sdp-sd_log_commited_buf + sdp-sd_log_commited_databuf); I've tested it on my roth cluster and it fixes the problem. Regards, Bob Peterson -- diff -pur a/fs/gfs2/lops.c b/fs/gfs2/lops.c --- a/fs/gfs2/lops.c2007-08-21 18:01:07.0 -0500

Re: [Cluster-devel] [PATCH] Cleanup some common CFLAGS

2007-08-27 Thread Bob Peterson
enough to generate enough debugging information for gdb. Please ACK or apply. Fabio PS The patch depends on the previous Makefile cleanup I posted on the mailing list right before this one. ACK, but I only looked at the defaults and the gfs2 userland bits. Regards, Bob Peterson

[Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung

2007-09-13 Thread Bob Peterson
The problem boiled down to a race between the gdlm_init_threads() function initializing thread1 and its setting of blist = 1. Essentially, if (current == ls-thread1) was checked by the thread before the thread creator set ls-thread1. Since thread1 is the only thread who is allowed to work on the

[Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung

2007-09-13 Thread Bob Peterson
of the loop that was recreating the failure and it seems to work. Dave Teigland brought up the question of whether we should do this another way. For example, by checking for the task name lock_dlm1 instead. I'm open to opinions. -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- diff -pur

[Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 3

2007-09-14 Thread Bob Peterson
name lock_dlm1 instead. I'm open to opinions. -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- diff -pur a/fs/gfs2/locking/dlm/thread.c b/fs/gfs2/locking/dlm/thread.c --- a/fs/gfs2/locking/dlm/thread.c 2007-09-13 17:33:58.0 -0500 +++ b/fs/gfs2/locking/dlm/thread.c 2007-09-14

Re: [Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 3

2007-09-19 Thread Bob Peterson
On Wed, 2007-09-19 at 16:13 -0500, David Teigland wrote: ACK, I noticed that this isn't in git yet AFAICT, it's in the git tree: http://git.kernel.org/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=e76700466a04c244d1d29fe51b282838becd4f2d Are you sure you were looking at nmw?

[Cluster-devel] [PATCH][GFS2] Given device ID rather than s_id in id sysfs file

2007-11-02 Thread Bob Peterson
Hi, This patch changes the /sys/fs/gfs2/s_id/id file to give the device id major:minor rather than the s_id. That enables gfs2_tool to match devices properly (by id, not name) when locating the tuning files. Regards, Bob Peterson -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2

Re: [Cluster-devel] [PATCH][GFS2] Given device ID rather than s_id in id sysfs file

2007-11-02 Thread Bob Peterson
, would be a NULL string. The quota tool should be changed to use the same interface as gfs2_tool to determine the proper path in sysfs. Perhaps I'll open a bugzilla record on it. Regards, Bob Peterson Red Hat Cluster Suite

[Cluster-devel] [GFS2][Patch] Remove function gfs2_get_block

2007-12-10 Thread Bob Peterson
block operation, this streamlines the code and makes it a little bit more efficient. Regards, Bob Peterson Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/bmap.c|8 fs/gfs2/bmap.h|2 +- fs/gfs2/log.c |2 +- fs/gfs2/ops_address.c | 30

[Cluster-devel] [GFS2][Patch 0/10] GFS2 performance tweaks

2007-12-11 Thread Bob Peterson
fetch the dinode once in block_map 8. Only find indirect pointer buffers once in block_map 9. Move meta_inval to glops.c and declare static, more attach_bufdata to trans.c and declare static. 10. Function meta_read optimization. Regards, Bob Peterson Red Hat GFS

[Cluster-devel] [GFS2] [Patch 1/10] Journal extent mapping

2007-12-11 Thread Bob Peterson
, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/incore.h | 11 +++- fs/gfs2/log.c| 22 ++- fs/gfs2/ops_fstype.c | 68 +- fs/gfs2/super.c | 13 - 4 files changed, 97

[Cluster-devel] [GFS2] [Patch 3/10] Run through full bitmaps quicker in gfs2_bitfit

2007-12-11 Thread Bob Peterson
. The compiler optimizes that quite well and we save some time, especially when running through full bitmaps (like the bitmaps allocated for the journals). There's probably a more elegant or optimized way to do this, but I haven't thought of it yet. I'm open to suggestions. Regards, Bob Peterson Red Hat

[Cluster-devel] [GFS2] [Patch 6/10] Reorganize function gfs2_glmutex_lock

2007-12-11 Thread Bob Peterson
scrutiny because changing anything to do with locking should strike terror into one's heart. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- .../fs/gfs2/glock.c| 23 +++ 1 files changed, 9 insertions(+), 14

[Cluster-devel] [GFS2] [Patch 7/10] Only fetch the dinode once in block_map

2007-12-11 Thread Bob Peterson
Hi, Function gfs2_block_map was often looking up the disk inode twice. This optimizes it so that only does it once. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- .../fs/gfs2/bmap.c | 14 +++--- 1 files changed, 7

[Cluster-devel] [GFS2] [Patch 8/10] Only find indirect pointer buffers once

2007-12-11 Thread Bob Peterson
(not modified) so I don't think this should impact anything, except being a bit faster. There's also a slight optimization in function find_metapath, which is used a lot. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- .../fs/gfs2/bmap.c

[Cluster-devel] [GFS2] [Patch 9/10] Move functions and make them static

2007-12-11 Thread Bob Peterson
Hi, This patch doesn't change any code, it just moves it around. Function gfs2_meta_inval is moved from meta_io.c to glops.c and function gfs2_attach_bufdata is moved from meta_io,c to trans.c. Both functions are then declared static. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob

[Cluster-devel] [GFS2] [Patch 10/10] Function meta_read optimization

2007-12-11 Thread Bob Peterson
Hi, This patch optimizes function gfs2_meta_read. Basically, gfs2_meta_wait was being called regardless of whether a disk read was requested. This just pulls that wait into the if that triggers the read. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED

Re: [Cluster-devel] [GFS2] [Patch 4/10] Get rid of sd_statfs_mutex

2007-12-12 Thread Bob Peterson
at all, which I assume was the purpose of the mutex in the first place. I'm not sure this is buying us much anyway, so perhaps we should forget it. Regards, Bob Peterson

Re: [Cluster-devel] [GFS2] [Patch 3/10] Run through full bitmaps quicker in gfs2_bitfit

2007-12-12 Thread Bob Peterson
for patch3 for the compile error. Note that the previous patch3 I sent also had some leftover useless debug code in it (regarding static int c) which needed to be taken out. Regards, Bob Peterson -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- .../fs/gfs2/rgrp.c

[Cluster-devel] [GFS2] [Patch 4/10] corrected

2007-12-12 Thread Bob Peterson
Hi, This patch eliminates the unneeded sd_statfs_mutex mutex but preserves the ordering as discussed. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/incore.h |1 - fs/gfs2/ops_fstype.c |1 - fs/gfs2/super.c |4 3 files

[Cluster-devel] [GFS2] [PATCH] Minor correction

2007-12-12 Thread Bob Peterson
Hi, This is a small correction to my previously posted patch1. It just changes a divide to a shift. It's faster and doesn't introduce odd dependencies on 32-bit compiles. Regards, Bob Peterson -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/ops_fstype.c |2 +- 1 files changed

[Cluster-devel] [GFS2 patch] Initialize extent_list earlier

2008-01-03 Thread Bob Peterson
Hi, Here is a patch for the latest upstream GFS2 code: The journal extent map needs to be initialized sooner than it currently is. Otherwise failed mount attempts (e.g. not enough journals, etc.) may panic trying to access the uninitialized list. Regards, Bob Peterson Signed-off-by: Bob

[Cluster-devel] [GFS2] [Patch] gfs2_alloc_required performance

2008-01-11 Thread Bob Peterson
will be required. Benchmarks like iozone should see better performance. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/bmap.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 73dfad7

[Cluster-devel] [GFS2] [Patch] Remove unneeded i_spin

2008-01-11 Thread Bob Peterson
Hi, This patch removes a vestigial variable i_spin from the gfs2_inode structure. This not only saves us memory (30 of these in memory for the oom test) it also saves us time because we don't have to spend time initializing it (i.e. slightly better performance). Regards, Bob Peterson Red

Re: [Cluster-devel] [PATCH] Clean up unused loop variable

2008-01-15 Thread Bob Peterson
. Regards, Bob Peterson Red Hat GFS

[Cluster-devel] [PATCH][GFS2] Lockup on error

2008-01-19 Thread Bob Peterson
Hi, I spotted this bug while I was digging around. Looks like it could cause a lockup in some rare error condition. Regards, Bob Peterson -- Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/inode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2

[Cluster-devel] [GFS2 PATCH]

2008-01-28 Thread Bob Peterson
Hi, I noticed that the latest change to i_height got rid of the value from the inode dump. This patch adds it back. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/inode.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[Cluster-devel] [GFS2 PATCH] Get rid of unneeded parameter in gfs2_rlist_alloc

2008-01-28 Thread Bob Peterson
Hi, This patch removed the unnecessary parameter from function gfs2_rlist_alloc. The parameter was always passed in as 0. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/bmap.c|1 +- fs/gfs2/dir.c |2 +- fs/gfs2/eattr.c

[Cluster-devel] [GFS2 PATCH] Only do lo_incore_commit once

2008-01-28 Thread Bob Peterson
only need to call it once, we can also make it faster by removing it from the generic lops code and making it a stand-along static function. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/incore.h |1 - fs/gfs2/log.c | 17

[Cluster-devel] [GFS2 PATCH] Misc fixups

2008-01-28 Thread Bob Peterson
Hi, This patch contains two small fixups that didn't fit elsewhere. They are: (1) get rid of temp variable in find_metapath. (2) Remove vestigial ret variable from gfs2_writepage_common. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/bmap.c

[Cluster-devel] [GFS2 PATCH] Plug an unlikely leak

2008-01-28 Thread Bob Peterson
-- fs/gfs2/lops.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 7138737..4390f6f 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,

[Cluster-devel] [GFS2 PATCH] Allocate gfs2_rgrpd from slab memory

2008-01-28 Thread Bob Peterson
Hi, This patch moves the gfs2_rgrpd structure to its own slab memory. This makes it easier to control and monitor, and yields less memory fragmentation. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/main.c | 10 ++ fs/gfs2/rgrp.c

[Cluster-devel] [GFS2 PATCH] Reduce size of version numbers

2008-01-28 Thread Bob Peterson
to facilitate intelligent data packing by the compiler. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/incore.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 9c090e1..ab682c0 100644

[Cluster-devel] [GFS2 PATCH] Get rid of gl_waiters2

2008-01-28 Thread Bob Peterson
Hi, This patch reduces memory by replacing the int variable gl_waiters2 by a single bit in the gl_flags. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/glock.c |7 --- fs/gfs2/incore.h |4 ++-- 2 files changed, 6 insertions(+), 5

Re: [Cluster-devel] [GFS2] Add consts to various bits of rgrp.c

2008-01-29 Thread Bob Peterson
of routines which scan bitmaps where we can mark the bitmaps const, plus a couple of call sites that can be updated too. Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c ACK fwiw Regards, Bob Peterson

Re: [Cluster-devel] [GFS2] Introduce array of buffers to struct metapath

2008-01-29 Thread Bob Peterson
function shares the struct metapath, but currently still frees its own buffers, and this will change in a future patch. Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c ACK fwiw Regards, Bob Peterson

[Cluster-devel] [GFS2 PATCH] Eliminate gl_req_bh

2008-01-29 Thread Bob Peterson
Hi, This patch further reduces the memory needs of GFS2 by eliminating the gl_req_bh variable from struct gfs2_glock. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/glock.c | 107 ++ fs/gfs2

Re: [Cluster-devel] [GFS2] Move part of gfs2_block_map into a separate function

2008-01-29 Thread Bob Peterson
This is required to enable future changes to the block mapping code. Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c ACK fwiw Regards, Bob Peterson

[Cluster-devel] [GFS2 PATCH] Eliminate gh_state

2008-01-29 Thread Bob Peterson
are correct, the rest of the code changes are mostly just direct substitutions. So take it or leave it as you see fit. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/eattr.c | 19 ++-- fs/gfs2/glock.c | 39

[Cluster-devel] [GFS2] Faster gfs2_bitfit algorithm

2008-03-07 Thread Bob Peterson
Hi, This version of the gfs2_bitfit algorithm is up to four times faster than its predecessor. Regards, Bob Peterson Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/rgrp.c | 79 +-- 1 files changed, 47 insertions(+), 32 deletions

[Cluster-devel] [GFS2] Faster gfs2_bitfit algorithm

2008-03-10 Thread Bob Peterson
the right conditions, I've seen peaks of 20 times faster. Regards, Bob Peterson Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/rgrp.c | 93 --- 1 files changed, 61 insertions(+), 32 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2

Re: [Cluster-devel] Cluster Project tag, gfs_6_1_16, created. gfs-kernel_2_6_9_76-16-gc118d0c

2008-03-19 Thread Bob Peterson
On Wed, 2008-03-19 at 06:12 +0100, Fabio M. Di Nitto wrote: Is this commit suitable for master / STABLE2 branch? Thanks Fabio Hi Fabio, Done for both fixes; sorry about that. I'm still getting used to how we are supposed to do things in git. Regards, Bob Peterson

[Cluster-devel] RHEL4 Test Patch: bz 345401

2008-03-19 Thread Bob Peterson
by hash-key if the glock in question is on the reclaim list because you can't guarantee the thing won't go away at an inconvenient time. Previous instrumentation indicated this was happening. Regards, Bob Peterson -- diff -pur a/fs/gfs2/glock.c b/fs/gfs2/glock.c --- a/fs/gfs2/glock.c 2008-02-22

Re: [Cluster-devel] RHEL4 Test Patch: bz 345401

2008-03-19 Thread Bob Peterson
Obviously the subject should read RHEL5, not RHEL4, since this is gfs2. I'm making this distinction because I don't want it to be mistaken for a patch to the upstream gfs2.

[Cluster-devel] [GFS2 patch] Make dump_glock a bit more friendly

2008-04-16 Thread Bob Peterson
Hi, This patch makes the glock dump a little more user-friendly. My primary goal was to get rid of the very-misleading report of the glock being (unlocked) based on gl_flag, but it goes a step further. If it's too verbose, feel free to say no. Regards, Bob Peterson -- fs/gfs2/glock.c | 34

[Cluster-devel] [GFS2 patch] Performance gain creating dinodes

2008-04-16 Thread Bob Peterson
the glock in the hash table, which involves locking the hash table and possible contention. Regards, Bob Peterson Red Hat Clustering GFS -- fs/gfs2/dir.c|3 ++- fs/gfs2/inode.c | 18 -- fs/gfs2/inode.h |3 ++- fs/gfs2/ops_export.c |2 +- fs/gfs2

[Cluster-devel] [GFS2 Patch] bz 450156 - kernel panic mounting volume

2008-06-09 Thread Bob Peterson
kernel and don't believe this affects RHEL. Regards, Bob Peterson Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/ops_super.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/ops_super.c b/fs/gfs2/ops_super.c index 0b7cc92..6690792 100644 --- a/fs/gfs2

Re: [Cluster-devel] Re: [Bug 10827] 2.6.26rc4 GFS2 oops.

2008-06-23 Thread Bob Peterson
Adrian Hi, This appears to be a known bug. There's a Fedora bugzilla record for it here, which contains a patch to fix the problem: https://bugzilla.redhat.com/show_bug.cgi?id=448866 The bug does not appear to be in 2.6.25; 2.6.25 is fine afaict. Regards, Bob Peterson Red Hat GFS

Re: [Cluster-devel] Re: [Bug 10827] 2.6.26rc4 GFS2 oops.

2008-06-23 Thread Bob Peterson
Whitehouse, and he is on vacation/holiday until tomorrow. I've submitted the patch to cluster-devel, so hopefully he'll push it as soon as he returns tomorrow. Regards, Bob Peterson Red Hat GFS

[Cluster-devel] [GFS2 Patch] bz458289: rm on multiple nodes causes panic

2008-08-11 Thread Bob Peterson
This patch fixes a problem whereby simultaneous delete operations (e.g. rm -fR *) from multiple nodes on the same GFS2 file system can cause kernel panics, hangs, and/or memory corruption. Regards, Bob Peterson Signed-off-by: Bob Peterson [EMAIL PROTECTED] -- fs/gfs2/ops_inode.c | 24

[Cluster-devel] Re: [Linux-cluster] Feature Request: gfs_fsck has a yes to all response.

2009-02-23 Thread Bob Peterson
list of blocks had been | fixed. | | Regards, | | Stewart Hi Stewart, You should be able to do: gfs_fsck -y /dev/your/device and it will answer 'y' to all the questions. This is similar to other fscks. You can also use -n to answer 'no' to all questions. Regards, Bob Peterson Red Hat GFS

[Cluster-devel] Re: [Linux-cluster] Feature Request: gfs_fsck has a yes to all response.

2009-02-26 Thread Bob Peterson
, An a (all) answer to the yes/no questions is certainly easy to do. I've thought about doing it, too, but AFAIK, none of the other fscks allow this response. I'll ask around and see if anyone objects. Regards, Bob Peterson Red Hat GFS

Re: [Cluster-devel] GFS2: Fix panic in glock memory shrinker

2009-06-30 Thread Bob Peterson
) == 0) | + continue; | + | /* Test for being demotable */ | if (!test_and_set_bit(GLF_LOCK, gl-gl_flags)) { | gfs2_glock_hold(gl); Hi, ACKed by Bob Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] waiting in init.d/cman

2009-08-05 Thread Bob Peterson
getting rid of the mount.gfs2 helper altogether upstream. Bob Peterson

Re: [Cluster-devel] GFS2 and uevents document

2009-08-13 Thread Bob Peterson
| explained, | | Steve. Hi Steve, Good writeup. Here are some minor suggestions. Bob Peterson -- --- /home/msp/rpeterso/gfs_uevents.orig.txt 2009-08-13 10:02:25.0 -0500 +++ /home/msp/rpeterso/gfs_uevents.bobs.txt 2009-08-13 10:10:33.0 -0500 @@ -1,9 +1,9

Re: [Cluster-devel] [PATCH 1/4] libgfs2: Fix 'dubious one-bit signed bitfield' sparse errors

2009-08-19 Thread Bob Peterson
7 | -- | 1.6.3.3 Hi, ACKed by Bob Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 2/4] gfs2_quota: Fix sparse error

2009-08-19 Thread Bob Peterson
| gfs2_quota *q) | { | /* seek to the appropriate offset in the quota file and read the | -- | 1.6.3.3 Hi, ACKed by Bob Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 3/4] libgfs2: Fix Value stored is never read warnings

2009-08-19 Thread Bob Peterson
) but this will work. ACKed by Bob Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 4/4] fsck.gfs2: Make block_mounters static

2009-08-19 Thread Bob Peterson
(struct gfs2_sbd *sbp, int block_em) | { | if(block_em) { | /* verify it starts with lock_ */ | -- | 1.6.3.3 Hi, ACKed by Bob Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2 patch] Add -o errors=panic|withdraw mount options

2009-08-20 Thread Bob Peterson
-serious gfs2 file system error occurs. This may be useful, for example, where fabric-level fencing is used that has no way to reboot (such as fence_scsi). Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/incore.h |7 +++ fs/gfs2/ops_fstype.c

[Cluster-devel] [PATCH GFS2] gfs2_stuffed_write_end modifying source buffer?

2009-09-23 Thread Bob Peterson
nuked. Just a theory at this point but perhaps Steve Whitehouse can tell. Regards, Bob Peterson Red Hat File Systems -- fs/gfs2/aops.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 7ebae9a..6a23ba2 100644 --- a/fs/gfs2/aops.c +++ b

[Cluster-devel] [PATCH] GFS2: print glock numbers in hex

2010-02-23 Thread Bob Peterson
Hi, This patch changes glock numbers from printing in decimal to hex. Since DLM prints corresponding resource IDs in hex, it makes debugging easier. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/glock.c |2 +- 1 files changed, 1 insertions

Re: [Cluster-devel] [Linux-cluster] Cluster 3.0.8 stable release

2010-02-24 Thread Bob Peterson
to update your clusters. Sorry, guys, but we've discovered a problem with mkfs.gfs2 that makes it impossible to create gfs2 file systems. The problem has been fixed in the STABLE3 and master branches of the git repos, and 3.0.9 will be released very soon. Regards, Bob Peterson Red Hat File

Re: [Cluster-devel] [PATCH] GFS2: Allow the number of committed revokes to temporarily be negative

2010-03-29 Thread Bob Peterson
Peterson rpete...@redhat.com Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [PATCH GFS2] livelock while reclaiming unlinked dinodes

2010-04-14 Thread Bob Peterson
Hi, Here is a patch for bugzilla bug #570182. Explanation in the patch. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- Author: Bob Peterson b...@krishna.(none) Date: Tue Apr 13 08:49:33 2010 -0500 GFS2: glock livelock This patch fixes

[Cluster-devel] [GFS2 Patch] Eliminate useless err variable

2010-05-11 Thread Bob Peterson
Hi, This patch removes an unneeded err variable that is always returned as zero. Regards, Bob Peterson Red Hat File Systems -- fs/gfs2/meta_io.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index abafda1..18176d0 100644

[Cluster-devel] [GFS2 Patch] GFS2: stuck in inode wait, no glocks stuck

2010-05-11 Thread Bob Peterson
Hi, This patch changes the lock ordering when gfs2 reclaims unlinked dinodes, thereby avoiding a livelock. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- GFS2: stuck in inode wait, no glocks stuck This patch changes the lock ordering when gfs2 reclaims

[Cluster-devel] [GFS2 PATCH] Rework reclaiming unlinked dinodes

2010-05-20 Thread Bob Peterson
Hi, The previous patch I wrote for reclaiming unlinked dinodes had some shortcomings and did not prevent all hangs. This version is much cleaner and more logical, and has passed very difficult testing. Sorry for the churn. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete

[Cluster-devel] [PATCH GFS2] Fix kernel NULL pointer dereference by dlm_astd

2010-06-15 Thread Bob Peterson
memory for the glock. In some circumstances, it would cause dlm's dlm_astd daemon to try to call the bast function for the freed lock_dlm memory, which resulted in a NULL pointer dereference. This problem was discovered while testing bugzilla bug #595397. Regards, Bob Peterson Red Hat GFS Signed

Re: [Cluster-devel] [PATCH GFS2] Fix kernel NULL pointer dereference by dlm_astd

2010-06-16 Thread Bob Peterson
- Steven Whitehouse swhit...@redhat.com wrote: | Hi, | | Now in the -nmw GFS2 tree. Thanks, | | Steve. | | On Tue, 2010-06-15 at 12:07 -0400, Bob Peterson wrote: | Hi, | | This patch fixes a problem in an error path when looking | up dinodes. There are two sister-functions

[Cluster-devel] [PATCH GFS2] Fix kernel NULL pointer dereference by dlm_astd

2010-06-17 Thread Bob Peterson
Hi, This patch replaces the one I previously posted here. Regards, Bob Peterson Red Hat File Systems -- commit 77ac19b0f0061396d0dc15f705ac4e0a574bd614 Author: Bob Peterson rpete...@redhat.com Date: Thu Jun 17 15:38:32 2010 -0500 GFS2: Fix kernel NULL pointer dereference by dlm_astd

[Cluster-devel] [GFS2 Patch] GFS2: recovery stuck on transaction lock

2010-06-23 Thread Bob Peterson
, Bob Peterson Red Hat GFS Signed-off-by: Steve Whitehouse swhit...@redhat.com Signed-off-by: Bob Peterson rpete...@redhat.com -- diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index ddcdbf4..dbab3fd 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -706,8 +706,18 @@ static void glock_work_func

[Cluster-devel] [GFS2 Patch] GFS2: O_TRUNC not working on stuffed files across cluster

2010-06-24 Thread Bob Peterson
Hi, This patch replaces a statement that got dropped out by accident. Without the patch, truncates on stuffed (very small) files cause those files to have an unpredictable size. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/bmap.c

[Cluster-devel] [GFS2 Patch] Simplify gfs2_write_alloc_required

2010-06-24 Thread Bob Peterson
passing that value in, which in turn simplifies a bunch of error checking. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/aops.c |4 +--- fs/gfs2/bmap.c | 15 +-- fs/gfs2/bmap.h |2 +- fs/gfs2/file.c |4 +--- fs/gfs2

[Cluster-devel] [GFS2 Patch] GFS2: rename causes kernel Oops

2010-07-14 Thread Bob Peterson
is reused, not just the free space portion of it, and therefore the function gfs2_dirent_find_space should use the value 0 rather than GFS2_DIRENT_SIZE(0) for the actual dirent size. Fixing this calculation enables the reproducer programs to work properly. Regards, Bob Peterson Red Hat GFS Signed-off

[Cluster-devel] [PATCH GFS2] GFS2 fatal: filesystem consistency error on rename

2010-09-30 Thread Bob Peterson
and this patch fixes all three. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/ops_inode.c |8 ++-- fs/gfs2/rgrp.c | 22 +- fs/gfs2/rgrp.h |8 +--- 3 files changed, 24 insertions(+), 14 deletions

[Cluster-devel] [GFS2 Patch] fsck.gfs2 reported statfs error after gfs2_grow

2010-12-07 Thread Bob Peterson
with the system statfs file. Regards, Bob Peterson Red Hat GFS Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/rgrp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 25dbe5c..7293ea2 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2

[Cluster-devel] [PATCH][GFS2] Bouncing locks in a cluster is slow in GFS2

2011-01-26 Thread Bob Peterson
Hi, This patch is a performance improvement for GFS2 in a clustered environment. It makes the glock hold time self-adjusting. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com Bouncing locks in a cluster is slow in GFS2 -- fs/gfs2/glock.c | 89

Re: [Cluster-devel] [PATCH][GFS2] Bouncing locks in a cluster is slow in GFS2 - Try #2

2011-01-26 Thread Bob Peterson
. It makes the glock hold time self-adjusting. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com Bouncing locks in a cluster is slow in GFS2 -- [Cluster-devel] [PATCH][GFS2] Bouncing locks in a cluster is slow in GFS2 fs/gfs2/glock.c | 39

Re: [Cluster-devel] [Linux-cluster] hi,question about gfs2

2011-02-22 Thread Bob Peterson
of the cluster infrastructure. However, we don't recommend that many nodes for various reasons. For one thing, your network may be clogged with lots of traffic, which may interfere with proper cluster communications. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2 PATCH] GFS2: unlink performance patch

2011-02-23 Thread Bob Peterson
unlinks. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/bmap.c | 20 +++- fs/gfs2/rgrp.c | 34 +++--- fs/gfs2/rgrp.h |2 ++ 3 files changed, 48 insertions(+), 8 deletions(-) diff --git a/fs

[Cluster-devel] [GFS2 PATCH] Optimize glock multiple-dequeue code

2011-03-10 Thread Bob Peterson
Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- fs/gfs2/glock.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 3f45a14..8648409 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c

[Cluster-devel] [GFS2 PATCH] Don't output rgrps at every bit change during unlink

2011-03-16 Thread Bob Peterson
, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index ef3dc4b..5076896 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -876,6 +876,7 @@ static int do_strip(struct gfs2_inode *ip, struct buffer_head *dibh

[Cluster-devel] [GFS2 Patch] GFS2 filesystem hang caused by incorrect lock order

2011-03-17 Thread Bob Peterson
of gfs2_delete_inode waiting for the glock, which is held by the first. The solution is to add a new non_block parameter to the gfs2_iget function that causes it to return -ENOENT if the inode is being freed. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- fs

[Cluster-devel] [GFS2 PATCH] gfs2: remove *leaf_call_t and simplify leaf_dealloc

2011-03-22 Thread Bob Peterson
the directory leaf deallocation code. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 5c356d0..10a4bbe 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -82,11 +82,11 @@ struct qstr gfs2_qdot

[Cluster-devel] [GFS2 PATCH] gfs2: Combine transaction from gfs2_dir_exhash_dealloc

2011-03-22 Thread Bob Peterson
the directory dinode at that time anyway. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 10a4bbe..6791e49 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -86,7 +86,7 @@ typedef int (*gfs2_dscan_t

[Cluster-devel] [GFS2 PATCH] gfs2: pass leaf_bh into leaf_dealloc

2011-03-22 Thread Bob Peterson
Hi, Function foreach_leaf used to look up the leaf block address and get a buffer_head. Then it would call leaf_dealloc which did the same lookup. This patch combines the two operations by making foreach_leaf pass the leaf bh to leaf_dealloc. Regards, Bob Peterson Red Hat File Systems Signed

[Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory

2011-03-23 Thread Bob Peterson
Hi, Since GFS2 doesn't rely upon generation numbers like GFS1, we do not need to copy the generation number into memory and out of memory. This patch eliminates the variable from the in-core structure and will reduce the memory requirements of GFS2. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2 Patch] GFS2: Processes waiting on inode glock that no processes are holding

2011-05-24 Thread Bob Peterson
by only transitioning the Pending demote bit to the demote flag once we know the other conditions (not unlocked and not exclusive) are met. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com -- diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index a2a6abb

[Cluster-devel] [PATCH][GFS2] Bouncing locks in a cluster is slow in GFS2 - Try #3

2011-06-15 Thread Bob Peterson
Hi, This is a rebase of a patch I sent on January 26, 2011. Now that we've resolved the other pending issues blocking this one, I'm submitting it again. This patch is a performance improvement for GFS2 in a clustered environment. It makes the glock hold time self-adjusting. Regards, Bob

Re: [Cluster-devel] [PATCH RHEL6 1/2] tunegfs2: Ensure we don't try to open a null device

2011-07-25 Thread Bob Peterson
-by: Nathan Straz nst...@redhat.com Hi, Looks good. ACK. Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH RHEL6 2/2] tunegfs2: Fix usage message

2011-07-25 Thread Bob Peterson
| Reported-by: Nathan Straz nst...@redhat.com | --- Hi, ACK, Regards, Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH] i18n: strings review

2011-07-26 Thread Bob Peterson
by Steve | --- Hi Carlos, Looks good. ACK. Bob Peterson Red Hat File Systems

[Cluster-devel] [PATCH 00/44] fsck.gfs2: Support for checking gfs1 file systems

2011-08-11 Thread Bob Peterson
savemeta, gzip the output, and send me a link where I can download it. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [Patch 01/44] fsck.gfs2: Make functions consistently use sdp rather than sbp

2011-08-11 Thread Bob Peterson
From f4326def0744e6a01a5e7665eb4f8261d6996af7 Mon Sep 17 00:00:00 2001 From: Bob Peterson rpete...@redhat.com Date: Mon, 8 Aug 2011 08:41:36 -0500 Subject: [PATCH 01/44] fsck.gfs2: Make functions consistently use sdp rather than sbp For years, the fsck.gfs2 tool used two different variable names

[Cluster-devel] [Patch 04/44] libgfs2: Make check_sb and read_sb operate on gfs1 file systems

2011-08-11 Thread Bob Peterson
From e85543c0c03fcaeb4ada7ee7b4ecbef361b16ffc Mon Sep 17 00:00:00 2001 From: Bob Peterson rpete...@redhat.com Date: Mon, 8 Aug 2011 10:48:35 -0500 Subject: [PATCH 04/44] libgfs2: Make check_sb and read_sb operate on gfs1 file systems This patch adds allow_gfs1 parameters to the read_sb

[Cluster-devel] [Patch 03/44] libgfs1: Add a centralized gfs1 variable to superblock variables

2011-08-11 Thread Bob Peterson
From 32a60225151e08ec6291e43dec2ab8ac7f24db21 Mon Sep 17 00:00:00 2001 From: Bob Peterson rpete...@redhat.com Date: Mon, 8 Aug 2011 09:45:36 -0500 Subject: [PATCH 03/44] libgfs1: Add a centralized gfs1 variable to superblock variables This patch adds a gfs1 variable to the in-core superblock

[Cluster-devel] [Patch 05/44] libgfs2: add generic risize function, move gfs1 structures to libgfs2

2011-08-11 Thread Bob Peterson
From e02f2523bfd3b3cc12b07cabdcc388b88c0ba769 Mon Sep 17 00:00:00 2001 From: Bob Peterson rpete...@redhat.com Date: Mon, 8 Aug 2011 11:23:47 -0500 Subject: [PATCH 05/44] libgfs2: add generic risize function, move gfs1 structures to libgfs2 This patch moves a number of gfs1-specific structures

[Cluster-devel] [Patch 06/44] fsck.gfs2: Check for blocks wrongly inside resource groups

2011-08-11 Thread Bob Peterson
From 7bb269a5158f81c6c5d9190c4f76d73a83e3c9d7 Mon Sep 17 00:00:00 2001 From: Bob Peterson rpete...@redhat.com Date: Mon, 8 Aug 2011 12:46:29 -0500 Subject: [PATCH 06/44] fsck.gfs2: Check for blocks wrongly inside resource groups It's not enough to range_check blocks in order to call them valid

  1   2   3   4   5   6   7   8   9   10   >