s is the rest of the cluster infrastructure.
However, we don't recommend that many nodes for various reasons.
For one thing, your network may be clogged with lots of traffic,
which may interfere with proper cluster communications.
Regards,
Bob Peterson
Red Hat File Systems
Hi,
I just wanted to let everyone know that I just did a new build of gfs2-utils.
The new source tarball can be downloaded here:
https://fedorahosted.org/releases/g/f/gfs2-utils/gfs2-utils-3.1.1.tar.gz
To report bugs or issues:
https://bugzilla.redhat.com/
Regards,
Bob Peterson
Red Hat
crease for
GFS2 unlinks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/bmap.c | 20 +++-
fs/gfs2/rgrp.c | 34 +++---
fs/gfs2/rgrp.h |2 ++
3 files changed, 48 insertions(+), 8 deletions(-)
diff --git a/fs/g
an be the first patch in the next
| -nmw tree after that. That way we'll give it the maximum exposure
| before
| it is merged.
|
| Does that sound like a reasonable plan?
|
| Steve.
|
| > Bouncing locks in a cluster is slow in GFS2
Hi,
Sounds like a good plan.
Regards,
Bob Peterson
Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/glock.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 3f45a14..8648409 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1248,10 +1248,8 @@ int
,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index ef3dc4b..5076896 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -876,6 +876,7 @@ static int do_strip(struct gfs2_inode *ip, struct
buffer_head *dibh,
btotal
ter the call to function gfs2_trans_end.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/aops.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index aad77e4..86870b3 100644
--- a/fs/gfs2/aops.c
+++ b
ng of gfs2_delete_inode
waiting for the glock, which is held by the first. The solution is to
add a new non_block parameter to the gfs2_iget function that causes it
to return -ENOENT if the inode is being freed.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/
llow us to
more closely examine the problem and possibly solve it.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/rgrp.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index cf930c
directory leaf deallocation code.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 5c356d0..10a4bbe 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -82,11 +82,11 @@
struct qstr gfs2_qdot __read_mostly;
struct qstr
to rewrite the directory dinode at that time anyway.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 10a4bbe..6791e49 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -86,7 +86,7 @@ typedef int (*gfs2_dscan_t)(co
Hi,
Function foreach_leaf used to look up the leaf block address and get
a buffer_head. Then it would call leaf_dealloc which did the same
lookup. This patch combines the two operations by making foreach_leaf
pass the leaf bh to leaf_dealloc.
Regards,
Bob Peterson
Red Hat File Systems
Signed
Hi,
gfs2: move function foreach_leaf to gfs2_dir_exhash_dealloc
The previous patches made function gfs2_dir_exhash_dealloc do nothing
but call function foreach_leaf. This patch simplifies the code by
moving the entire function foreach_leaf into gfs2_dir_exhash_dealloc.
Regards,
Bob Peterson
Hi,
Since GFS2 doesn't rely upon generation numbers like GFS1, we do not
need to copy the generation number into memory and out of memory.
This patch eliminates the variable from the in-core structure and
will reduce the memory requirements of GFS2.
Regards,
Bob Peterson
Red Hat File Sy
that scares me; there
should be an interface to do that. If not, it must be for some
future development, because we don't reference the value anywhere.
Regards,
Bob Peterson
Red Hat File Systems
didn't then set the
GLF_DEMOTE flag or reinstate the GLF_PENDING_DEMOTE_FLAG.
The patch closes the timing window by only transitioning the
"Pending demote" bit to the "demote" flag once we know the
other conditions (not unlocked and not exclusive) are met.
Regards,
Bob Pe
Hi,
This is a rebase of a patch I sent on January 26, 2011.
Now that we've resolved the other pending issues blocking
this one, I'm submitting it again.
This patch is a performance improvement for GFS2 in a clustered
environment. It makes the glock hold time self-adjusting.
Reg
.
Bob Peterson
Red Hat File Systems
| ---
Hi,
ACK,
Regards,
Bob Peterson
Red Hat File Systems
by Steve
| ---
Hi Carlos,
Looks good. ACK.
Bob Peterson
Red Hat File Systems
sted shortly. Testing is ongoing.
If you have GFS1 or GFS2 file systems and would like to contribute
metadata for testing, please use "gfs2_edit savemeta", gzip the
output, and send me a link where I can download it.
Regards,
Bob Peterson
Red Hat File Systems
>From f4326def0744e6a01a5e7665eb4f8261d6996af7 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 08:41:36 -0500
Subject: [PATCH 01/44] fsck.gfs2: Make functions consistently use sdp rather
than sbp
For years, the fsck.gfs2 tool used two different variable names to refer to
>From e85543c0c03fcaeb4ada7ee7b4ecbef361b16ffc Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 10:48:35 -0500
Subject: [PATCH 04/44] libgfs2: Make check_sb and read_sb operate on gfs1
file systems
This patch adds "allow_gfs1" parameters to the read_sb and check
>From 32a60225151e08ec6291e43dec2ab8ac7f24db21 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 09:45:36 -0500
Subject: [PATCH 03/44] libgfs1: Add a centralized gfs1 variable to superblock
variables
This patch adds a "gfs1" variable to the in-core superblock struct
>From e02f2523bfd3b3cc12b07cabdcc388b88c0ba769 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 11:23:47 -0500
Subject: [PATCH 05/44] libgfs2: add generic risize function, move gfs1
structures to libgfs2
This patch moves a number of gfs1-specific structures from gfs2_edit
>From 7bb269a5158f81c6c5d9190c4f76d73a83e3c9d7 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 12:46:29 -0500
Subject: [PATCH 06/44] fsck.gfs2: Check for blocks wrongly inside resource
groups
It's not enough to range_check blocks in order to call them valid.
We also
>From a2fc75cad03602f8582a744c6a14ddae3a85cffd Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 12:58:04 -0500
Subject: [PATCH 07/44] fsck.gfs2: Rename function check_leaf to
check_ealeaf_block
This patch renames function check_leaf_block to check_ealeaf_block to
av
>From dfa63a3b56e71b8607098cb02e5162fc01aa8bab Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 13:28:08 -0500
Subject: [PATCH 08/44] fsck.gfs2: eliminate vestigial buffer_head variable in
check_leaf
This patch eliminates a variable bh from all the check_leaf metawalk
functi
>From 55e442c79adec0fa7f6d4e7f6700f14a630d4e3e Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 14:01:18 -0500
Subject: [PATCH 09/44] fsck.gfs2: Rename the nlink functions to make them
more intuitive
Part of fsck's checks is to verify the count of links for directories,
>From da57639e65b148bb4d2a3c6a9d98623b8ad18b04 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 14:21:06 -0500
Subject: [PATCH 10/44] fsck.gfs2: Keep di_nlink in sync when adding links for
lost+found
When adding a ".." entry to a directory newly linked to lost+fo
>From 0dc5622515a2e888efd89cb33e7c2fe600f895a5 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 14:38:19 -0500
Subject: [PATCH 11/44] fsck.gfs2: directory entry count was only 16 bits in
check_entries
When counting directory links, fsck.gfs2 was using a 16-bit inte
>From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 14:44:46 -0500
Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
This patch changes the logic of the code from being triple-negative
to single-negative so it wo
>From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 14:47:49 -0500
Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
This patch adds a call to bmodified to function dirent_repair. Without
setting the modif
>From 0307db694e7316ab93071239704428ba5e346fcb Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 15:16:01 -0500
Subject: [PATCH 14/44] fsck.gfs2: Ask to reclaim unlinked meta on a per-rgrp
basis only
Before this patch, fsck.gfs2 would ask for every unlinked metadata bit
whet
>From 37b96d287c82e81b5626948a80b52d62bb2b8612 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 15:44:19 -0500
Subject: [PATCH 15/44] fsck.gfs2: Factor out function to add ".." entry when
linking to lost+found
This function factors out a section of code
>From 97b0253e2347b87f29ecf5d5fefbb08655358bb2 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 16:11:48 -0500
Subject: [PATCH 16/44] libgfs2: Use __FUNCTION__ rather than __FILE__ for
debug messages
This patch changes the debug output of gfs2-utils to use __FUNCTION__
rat
>From 0f424f6c6a2b4fda8c5b9b2bc1cb246d868d3fec Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 16:20:14 -0500
Subject: [PATCH 17/44] fsck.gfs2: Don't stop invalidating blocks if an
invalid one is found
When fsck found a duplicate reference to a block it invalid
>From 50e59f2cd489e7b0200bb098f1c11c30977d5e28 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 16:44:47 -0500
Subject: [PATCH 18/44] fsck.gfs2: Find and clear duplicate references that
are leaf blocks
Duplicate references that were in leaf blocks were never found nor
clea
>From 3183f07e29fdc7c8af817ea97740b472f4767fc3 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 09:33:08 -0500
Subject: [PATCH 20/44] fsck.gfs2: Add duplicate reference processing for leaf
blocks
This patch adds checks for duplicate block references to the leaf block
process
>From ce30310b12df03b34d1e430e69e483bf1ee10b64 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 10:08:21 -0500
Subject: [PATCH 21/44] fsck.gfs2: split function check_leaf_blks to make it
more understandable
This patch splits function check_leaf_blks into two functions to m
>From 4768302284585037fada762a1bc5107f9212de71 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 09:23:05 -0500
Subject: [PATCH 19/44] fsck.gfs2: Move function check_num_ptrs from
metawalk.c to pass1.c
This patch moves function check_num_ptrs from metawalk.c to pass1.c
and a
>From 866622b4d90e112c9e7690e0ec61af79b827fd3d Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 11:38:18 -0500
Subject: [PATCH 22/44] fsck.gfs2: Shorten output
This patch shortens some of the output of fsck.gfs2, thereby making
the output files smaller and more manageable.
r
>From eebc8a12e1995b01b73e10f1eca2afe5395c4d72 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 12:36:04 -0500
Subject: [PATCH 23/44] fsck.gfs2: Make output messages more sensible
This patch changes several fsck output messages so that they make more
sense. Digging through v
>From 7a2fc9138955e93fd525f5ec035e7ab2b57f0a8c Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 12:45:18 -0500
Subject: [PATCH 24/44] fsck.gfs pass2: Refactor function set_dotdor_dir
This patch refactors function set_dotdot_dir to make it more readable.
rhbz#675723
---
g
>From c88ec089aeddd42c88faa17f5dd9ecb7119e2d61 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 12:48:36 -0500
Subject: [PATCH 25/44] fsck.gfs pass2: When deleting an inode, delete its
extended attributes
When pass2 decided to delete a bad/corrupt dinode from disk, it was
>From 61c30e4c549d5de8e9a668b9e34bde071ed704ce Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 13:01:05 -0500
Subject: [PATCH 26/44] fsck.gfs pass2: Only delete metadata if "bad" (not
"invalid") inode
In pass2, all metadata was deleted for inodes that
>From a97bc6cd2ecb804664968385e10de3b25e3bdb55 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 13:27:01 -0500
Subject: [PATCH 27/44] fsck.gfs pass3: Refactor mark_and_return_parent
This patch refactors pass3 function "mark_and_return_parent". Before
it was s
>From d60a5514fd59bb5f29af684a4fe3958fee597ca5 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 14:07:21 -0500
Subject: [PATCH 28/44] fsck.gfs2: misc cosmetic changes
This patch is just cosmetic changes. It cleans up comments and code
but there should be no logic changes.
r
>From 98ccc0cb40a604a943e029f1a475dd911807c22b Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 14:22:12 -0500
Subject: [PATCH 29/44] fsck.gfs2: check_leaf_blks: Don't use old_leaf if it
was a duplicate
In function check_leaf_blks fsck.gfs2 keeps track of the current
>From 06a9b623e46dfc8ea2008b8d32267f5f28708316 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 15:29:35 -0500
Subject: [PATCH 30/44] fsck.gfs2: Add find_remove_dup and
free_block_if_notdup
This patch adds a couple new functions to util.c: find_remove_dup
>From 34c9992770cb54114e8806663526cb1baa235ecb Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 15:51:34 -0500
Subject: [PATCH 31/44] fsck.gfs2: don't free previous rgrp list when trying
to repair rgrps
In cases where fsck.gfs2 is trying to repair damaged resource g
>From b3a08a2127d565609c0edaba400525b8737ab324 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 10:21:00 -0500
Subject: [PATCH 32/44] libgfs2: eliminate gfs1_readi in favor of gfs2_readi
This patch eliminates function gfs1_readi because it's nearly
identical to gfs2_rea
>From 1cd46c9abb1d1498d9b18afae4f6f978d71d648d Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 10:25:19 -0500
Subject: [PATCH 33/44] libgfs2: when adding a new GFS1 block, mark buffers
modified
When adding new blocks to the file system for GFS1, function
gfs1_lookup_block
>From bc534f1d55b9b80b795356f7c5e3bc170bd75919 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 10:33:49 -0500
Subject: [PATCH 34/44] libgfs2: when mapping gfs1 dinode blocks, use dinode
buffer
When function gfs1_block_map found a block for a stuffed file it
wasn't r
>From 83fd3a6dd7abf86de7c670fe4a869dff1ddd8582 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 13:12:54 -0500
Subject: [PATCH 35/44] libgfs2: move block_map functions to fsck.gfs2
Since the "blockmap" functions were only used in fsck.gfs2 they don't
have
>From 8f63c5404cb4731593c7dd2ecc958af5d5b68d9f Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 14:07:45 -0500
Subject: [PATCH 36/44] libgfs2: eliminate gfs1_rindex_read in favor of
rindex_read
Now that function rindex_read is able to handle gfs1 file reading,
this pa
>From 1b5b46eb51f0784152792fe4f446bb8f78712665 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 14:20:11 -0500
Subject: [PATCH 37/44] libgfs2: combine ri_update and gfs1_ri_update
Since gfs1_ri_update is nearly identical to ri_update, I decided to
combine the main logic int
>From a839d64d24bd61c951177e981a88e678912a495f Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 14:49:35 -0500
Subject: [PATCH 38/44] libgfs2: combine gfs_inode_read and gfs_inode_get
Functions gfs_inode_read and gfs_inode_get were nearly identical.
They did the same ex
>From 6fc9e595a6eb140c097cf0aafe203c40d44a8863 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 15:27:10 -0500
Subject: [PATCH 39/44] libgfs2: move gfs1 functions from edit to libgfs2
This patch moves some gfs1-specific functions from gfs2_edit to
libgfs2 so that other ut
>From 6861c4a24df7120264e31848395059ce06181026 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 15:30:25 -0500
Subject: [PATCH 40/44] gfs2_edit savemeta: save_inode_data backwards for gfs1
The logic in "gfs2_edit savemeta" was wrong for saving inode blocks.
This pa
>From fa2783c80d02a6ffba36936e8031d471b4c9adb2 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Wed, 10 Aug 2011 16:28:02 -0500
Subject: [PATCH 41/44] libgfs2: expand libgfs2's capabilities to operate on
gfs1
This patch expands many of the libgfs2 functions so that they may
operate
>From 993b62468d4d58220927f72a1fc01b04ebd75da5 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Thu, 11 Aug 2011 09:16:33 -0500
Subject: [PATCH 42/44] fsck.gfs2: Combine block and char device inode types
This patch combines the block and character device block designations.
Devices are
>From 0de28d19f6bcdfd6bb987079c698776ce769596f Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Thu, 11 Aug 2011 12:25:38 -0500
Subject: [PATCH 43/44] fsck.gfs2: four-step duplicate elimination process
This patch reforms the duplicate block reference processing by
introducing a new four-s
the logic
accordingly, but I should be done it more cleanly.
I'll redesign patch 4 and send out a replacement.
Regards,
Bob Peterson
Red Hat File Systems
es from gfs2_edit
so I'll just redo the patch.
Regards,
Bob Peterson
Red Hat File Systems
be checked and fixed if necessary.
I'll see if I can adjust the patch to add some comments or
somehow be less confusing.
Regards,
Bob Peterson
Red Hat File Systems
m_dir(sdp, dirblk))
continue;
Regards,
Bob Peterson
Red Hat File Systems
e patchset introduces the
| following warnings:
Hi,
Good catches. I'll clean these up.
Regards,
Bob Peterson
Red Hat File Systems
is experimental, so make backups and try it AT YOUR OWN RISK.
However, it is also better tested than all of its predecessors.
Regards,
Bob Peterson
Red Hat File Systems
>From 9b808af98b25a97cdfa71afc0066565d7c74e758 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 09:45:36 -0500
Subject: [PATCH 03/56] libgfs1: Add gfs1 variable to superblock structure
This patch adds a "gfs1" variable to the in-core superblock structure
for u
>From eb78d8bc0c745495cfbf48eacbdd2bc8c40687b4 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Fri, 12 Aug 2011 14:46:22 -0500
Subject: [PATCH 04/56] libgfs2: Make check_sb and read_sb operate on gfs1
This patch adds "allow_gfs1" parameters to the read_sb and check_sb functio
>From b41b13ad098be6fb94ecfe44c1acb9a90d2e376c Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Mon, 8 Aug 2011 11:23:47 -0500
Subject: [PATCH 05/56] libgfs2: move gfs1 structures to libgfs2
This patch moves a number of gfs1-specific structures from gfs2_edit to
libgfs2 so other utils
>From ac7599926d255907a72a2728dc62f0bf764fe6fe Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 9 Aug 2011 09:23:05 -0500
Subject: [PATCH 19/56] fsck.gfs2: fsck.gfs2: Move check_num_ptrs from
metawalk to pass1
This patch moves function check_num_ptrs from metawalk.c to pass1.c
and a
>From eea850f1a8af10e23cd9a6a82a7d3da46341a461 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Fri, 19 Aug 2011 08:48:29 -0500
Subject: [PATCH 45/56] fsck.gfs2: Remove bad inodes from duplicate tree
The problem was that if an inode was determined to be "bad" (lots of
corrup
>From 9ed45847f7ab17177fda10ba47e768e96ef0389d Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Fri, 19 Aug 2011 08:50:07 -0500
Subject: [PATCH 46/56] fsck.gfs2: Handle duplicate reference to dinode blocks
The fsck.gfs2 tool was not properly handling cases where dinode
blocks were referenced
>From 8418bdea9e43d56c1f20d749ee2c9a9b12b684c3 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Fri, 19 Aug 2011 08:50:48 -0500
Subject: [PATCH 47/56] fsck.gfs2: Bad extended attributes not deleted
properly
This patch fixes a couple of problems fsck.gfs2 when it discovered
corrupt exten
>From c93beb4367027f52979297dafae5728093f6a5d6 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Fri, 19 Aug 2011 15:57:03 -0500
Subject: [PATCH 48/56] libgfs2: Make rebuild functions not re-read ip
Before this patch, the libgfs2 rebuild functions in structures.c
were not consistent ab
>From c404df1868834ccf2bc6be88401be7bbb01abcc7 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 09:16:10 -0500
Subject: [PATCH 49/56] fsck.gfs2: Shorten debug output
This patch considerably shortens the debug output of fsck.gfs2 by
doing a few things. First, if fsck is j
>From 878f33b79259b6798f19c3569278b46a170eee10 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 09:28:22 -0500
Subject: [PATCH 50/56] fsck.gfs2: Increment link count reporting wrong dinode
The output from fsck.gfs2 was wrong when it reported about a
link count change for l
>From b836875303346bfbe264279b441e864c043daadd Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 09:31:40 -0500
Subject: [PATCH 51/56] fsck.gfs2: system dinodes take priority over user
dinodes
In testing fsck.gfs2 I noticed some incorrect behavior: If a block
was referen
>From 1cea55e014f7dc8f75ad8ace758f4d4fb7095ca1 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 10:02:02 -0500
Subject: [PATCH 52/56] fsck.gfs2: Recognize partially gfs2-converted dinodes
In testing fsck.gfs2 I noticed that if a file system had some
leftover gfs2 dinodes (
>From e635bf72ab0a1e1c3a935336072ccbdb14718365 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 10:30:20 -0500
Subject: [PATCH 53/56] fsck.gfs2: Print step 2 duplicate debug msg first
In testing fsck.gfs2 I noticed that when duplicates were resolved,
the "step 2"
>From 3352e37b309f134a5504fa36d8037fab7bb05e53 Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Tue, 23 Aug 2011 22:11:24 -0500
Subject: [PATCH 54/56] fsck.gfs2: pass1c counts percentage backward
In testing I noticed that pass1c, which checks all extended
attributes, counted percent-compl
>From c047763230204f55c2da9a6558f47bc26f4b526c Mon Sep 17 00:00:00 2001
From: Bob Peterson
Date: Thu, 25 Aug 2011 10:49:36 -0500
Subject: [PATCH 55/56] fsck.gfs2: Speed up rangecheck functions
This patch speeds up the block rangecheck functions by passing
the block type in as an integer rat
- Original Message -
| Hi Bob,
|
| On 25/08/11 17:49, Bob Peterson wrote:
| > 32/56 libgfs2: eliminate gfs1_readi in favor of gfs2_readi
|
| Could you send the latest version of patch 32? Using the original one
| I'm getting:
|
| Applying: libgfs2: eliminate gfs1_readi in
- Original Message -
| From 7a26516c6e3ed7e8fc87d48112171630f6db7677 Mon Sep 17 00:00:00 2001
| From: Bob Peterson
| Date: Thu, 25 Aug 2011 11:09:25 -0500
| Subject: [PATCH 56/56] libgfs2: Make in-core rgrps use rbtree
|
| This patch changes the in-core structure used for resource groups
ough the loop will leak memory.
| +
| + if (res > 0){
With my suggestion above, this can be removed:
| + free(line);
Other than that, it looks good.
Regards,
Bob Peterson
Red Hat File Systems
ewn = &((*newn)->rb_right);
| + else {
| spin_unlock(&sdp->sd_rindex_spin);
| - return rgd;
| + return cur;
| }
| }
Regards,
Bob Peterson
Red Hat File Systems
Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/bmap.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 7878c47..7efa38c 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -691,7 +691,7
- Original Message -
| This patch changes the are_you_sure() function
| to make use of rpmatch() to identify the user's
| answer in the language set in the i18n
| Also add 2 another translatable strings
|
| Signed-off-by: Carlos Maiolino
| ---
Hi,
Looks good.
Regards,
Bob Peterso
- Original Message -
| This patch takes advantage of the are_you_sure() function
| to ask a yes/no question within verify_bsize() function
|
Hi,
Looks good.
Regards,
Bob Peterson
Red Hat File Systems
/close might change the behavior
when errors occur: For example, if you try to mkfs.gfs2
for a device you don't have permission to. Or for a
device that doesn't exist. Please test those two cases
to make sure nothing weird happens.
Regards,
Bob Peterson
Red Hat File Systems
code in the main_mkfs() function (almost at the begining
| of the function):
Hi Carlos,
Thanks for clearing that up. I should have looked myself; sorry.
Yes, the patches look good to push as far as I'm concerned.
Regards,
Bob Peterson
Red Hat File System
fs2
Segmentation fault (core dumped)
# ./gfs2_grow /mnt/gfs2
FS: Mount Point: /mnt/gfs2
FS: Device: /dev/mapper/vg_gfs2-lv_gfs2
FS: Size:127997 (0x1f3fd)
FS: RG size: 127980 (0x1f3ec)
DEV: Size: 256000 (0x3e800)
The file system grew by 500MB.
gfs2_grow complete.
Regards,
Bob Peterson
/mnt/gfs2 > /dev/null) was reduced
from 2m2.814s on a stock kernel to 0m45.938s.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/dir.c | 33 +
1 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/fs/gfs2/dir.c b
it.
Regards,
Bob Peterson
Red Hat File Systems
es for faster lookup. This patch
eliminates that step, since it doesn't have a resource name
at that time for inserting new entries in the rb_tree.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
commit 4f65e6021b3b5582c731542552914a3f6865f8a5
Author: Bob Peter
d hard-code it to 32. What can I say?
Regards,
Bob Peterson
Red Hat File Systems
--
commit 19ec5ffb5eaf915944861f8ebd4c065818a238c5
Author: Bob Peterson
Date: Thu Oct 6 10:34:05 2011 -0500
GFS2: Add readahead to sequential directory traversal
This patch adds read-ahead capabili
s a lot of
the issues you wrote about.
I couldn't use the file struct because of the way function
gfs2_dir_read is called from NFS.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
--
fs/gfs2/dir.c| 50 ++
f
- Original Message -
| On Wed, Oct 05, 2011 at 03:25:39PM -0400, Bob Peterson wrote:
| > Hi,
| >
| > This upstream patch changes the way DLM keeps track of RSBs.
| > Before, they were in a linked list off a hash table. Now,
| > they're an rb_tree off the same hash ta
1 - 100 of 2505 matches
Mail list logo
