Re: [Cluster-devel] [PATCH] gfs2: get rid of potential double free

2018-11-26 Thread PanBian
On Tue, Nov 27, 2018 at 12:19:48AM +0100, Andreas Gruenbacher wrote: > Pan, > > On Mon, 26 Nov 2018 at 09:44, Pan Bian wrote: > > > __gfs2_set_acl will not increase the reference count of acl if it fails. > > In this case, posix_acl_release are called twice, one after > > __gfs2_set_acl and one

Re: [Cluster-devel] [PATCH] gfs2: get rid of potential double free

2018-11-26 Thread Andreas Gruenbacher
Pan, On Mon, 26 Nov 2018 at 09:44, Pan Bian wrote: > __gfs2_set_acl will not increase the reference count of acl if it fails. > In this case, posix_acl_release are called twice, one after > __gfs2_set_acl and one in the error handling block. This patch does not > release acl when __gfs2_set_acl