[cmake-developers] [CMake 0014845]: invalid generated -I path for JNI includes on cygwin

2014-03-27 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14845 == Reported By:FrancisANDRE Assigned To:

Re: [cmake-developers] [PATCH] Better find module developer documentation

2014-03-27 Thread Brad King
On 03/26/2014 03:02 PM, Alex Merry wrote: I wrote some documentation on how to write a find module for KDE's extra-cmake-modules project, and Stephen suggested upstreaming it. So attached is a patch that does that. Thanks for working on this. I like the tutorial-style presentation. First, a

[cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
I atached patch which cleanup Watcom Windows configuration It includes following changes. remove Watcom linker caseexact options already defined in linker system definition use win_dll system for SHARED_LIBRARY and SHARED_MODULE use explicit target definition -bt=.. option for proper

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Daniele E. Domenichelli
Hello all, Sorry for bringing up an old thread, you can find the original thread here: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8658 I pushed the topic again with no changes (just a rebase), I've been using it for a while with no issues at all. Is it ok to merge it to

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Daniele E. Domenichelli
Hello again, Sorry for bringing up another old thread, you can find the original thread here: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8837 I pushed the topic again with no changes (just a rebase), I've been using it for a while with no issues at all. Is it ok to merge

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Brad King
On 03/27/2014 11:16 AM, Daniele E. Domenichelli wrote: Is it ok to merge it to next? Yes, but let's do only one change to ExternalProject per day so we can see how the tests do. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Brad King
On 03/27/2014 10:47 AM, Jiri Malak wrote: I atached patch which cleanup Watcom Windows configuration Thanks. Since this touches Windows-wcl386.cmake it is tangled with the link line quoting change. Once that is in 'master' please rebase this on it and re-send. Thanks, -Brad -- Powered by

Re: [cmake-developers] wlink command-line parsing

2014-03-27 Thread Brad King
On 03/26/2014 06:38 PM, Jiri Malak wrote: It is correct version of patch. Thanks. + if( useSingleQuote) +{ +#if defined(_WIN32) !defined(__CYGWIN__) +result = '; +#else +result = \'; +#endif This quoting style is now very specific to Watcom. Please add another patch on

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Brad King
On 03/27/2014 11:34 AM, Brad King wrote: A simpler way to look for the argument: if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);) # ... test CMAKE_MATCH_1 endif() Actually you don't need to parse the arg ahead of time. The ALL option to add_custom_target just tells it to *not* set the

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Daniele E. Domenichelli
On 27/03/14 16:53, Brad King wrote: Actually you don't need to parse the arg ahead of time. The ALL option to add_custom_target just tells it to *not* set the EXCLUDE_FROM_ALL target property. Instead you can leave out ALL, parse the args as normal, and then add set_property(TARGET ...

Re: [cmake-developers] wlink command-line parsing

2014-03-27 Thread Jiri Malak
I did it. New patch is enclosed. Regards Jiri On 03/26/2014 06:38 PM, Jiri Malak wrote: It is correct version of patch. Thanks. + if( useSingleQuote) +{ +#if defined(_WIN32) !defined(__CYGWIN__) +result = '; +#else +result = \'; +#endif This quoting style is now very

Re: [cmake-developers] wlink command-line parsing

2014-03-27 Thread Brad King
On 03/27/2014 01:22 PM, Jiri Malak wrote: I did it. New patch is enclosed. Thanks. I've squashed all the changes into: Makefile: Generate single-quoted object lists for Watcom http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=423009c1 -Brad -- Powered by www.kitware.com Please keep

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Brad King
On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote: + if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);) +set(exclude_from_all ${CMAKE_MATCH_1}) + endif() + if(NOT exclude_from_all) +set(all ALL) + endif() We need to be robust against variables set in outer scopes: set(all

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
OK. I will do it as soon as it will be possible. Jiri On 03/27/2014 10:47 AM, Jiri Malak wrote: I atached patch which cleanup Watcom Windows configuration Thanks. Since this touches Windows-wcl386.cmake it is tangled with the link line quoting change. Once that is in 'master' please

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Daniele E. Domenichelli
On 27/03/14 18:50, Brad King wrote: On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote: + if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);) +set(exclude_from_all ${CMAKE_MATCH_1}) + endif() + if(NOT exclude_from_all) +set(all ALL) + endif() Sorry, I made 2 force-pushes (after

Re: [cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

2014-03-27 Thread Brad King
On 03/27/2014 02:23 PM, Daniele E. Domenichelli wrote: The updated code after your second e-mail should be this: + get_property(exclude_from_all TARGET ${name} PROPERTY _EP_EXCLUDE_FROM_ALL) + if(exclude_from_all) +set_property(TARGET ${name} PROPERTY EXCLUDE_FROM_ALL TRUE) + endif()

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Brad King
On 03/27/2014 11:34 AM, Brad King wrote: On 03/27/2014 11:16 AM, Daniele E. Domenichelli wrote: Is it ok to merge it to next? Yes, but let's do only one change to ExternalProject per day so we can see how the tests do. Please take a look at the failure on the continuous test submissions.

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Brad King
On 03/27/2014 02:35 PM, Brad King wrote: Please take a look at the failure on the continuous test submissions. fatal: Couldn't find remote ref origin/master fatal: The remote end hung up unexpectedly Is there a particular version requirement on Git? Also I just noticed this line: +

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread J Decker
On Thu, Mar 27, 2014 at 7:47 AM, Jiri Malak malak.j...@gmail.com wrote: I atached patch which cleanup Watcom Windows configuration It includes following changes. remove Watcom linker caseexact options already defined in linker system definition what do you mean 'defined in linker system

Re: [cmake-developers] [PATCH] cleanup Watcom Windows configuration

2014-03-27 Thread Jiri Malak
On Thu, Mar 27, 2014 at 7:47 AM, Jiri Malak malak.j...@gmail.com wrote: I atached patch which cleanup Watcom Windows configuration It includes following changes. remove Watcom linker caseexact options already defined in linker system definition what do you mean 'defined in linker system

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Brad King
On 03/27/2014 02:35 PM, Brad King wrote: Please take a look at the failure on the continuous test submissions. fatal: Couldn't find remote ref origin/master fatal: The remote end hung up unexpectedly I see this fix, thanks: ExternalProject: Strip out origin/ from git tag

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2014-03-27 Thread Daniele E. Domenichelli
On 27/03/14 19:45, Brad King wrote: On 03/27/2014 02:35 PM, Brad King wrote: Please take a look at the failure on the continuous test submissions. fatal: Couldn't find remote ref origin/master fatal: The remote end hung up unexpectedly Is there a particular version requirement on Git? I

Re: [cmake-developers] A goal for a simple Android toolchain file.

2014-03-27 Thread Eric Wing
On 3/26/14, Stephen Kelly steve...@gmail.com wrote: Eric Wing wrote: I have been using my fork of the Android-CMake (originally from OpenCV) that you want to obsolete. My fork contains a lot of fixes to deal with more recent NDK updates and more complicated requirements that I have.

[CMake] custom nsis template- Install targets not working

2014-03-27 Thread Lloyd
Hi, My CMake file contains the install comands like this install(TARGETS MyExe RUNTIME DESTINATION .) When I use the standard NSIS template, the installer is created with MyExe. But our project needs a custom NSIS template so I have written one, and it is generating an installer *without*

Re: [CMake] custom nsis template- Install targets not working

2014-03-27 Thread Eric Noulard
2014-03-27 7:08 GMT+01:00 Lloyd lloydkl.t...@gmail.com: Hi, My CMake file contains the install comands like this install(TARGETS MyExe RUNTIME DESTINATION .) When I use the standard NSIS template, the installer is created with MyExe. But our project needs a custom NSIS template so I have

Re: [CMake] custom nsis template- Install targets not working

2014-03-27 Thread Lloyd
I am no NSIS expert so I can't imagine why 'File /r ${INST_DIR}\*.*' could possibly do ??? About the file command the NSIS documentation says this: Adds file(s) to be extracted to the current output path ($OUTDIR). If the /r switch is used, files and directories are added

Re: [CMake] custom nsis template- Install targets not working

2014-03-27 Thread Lloyd
Solved the problem. Further verification revealed that, when I build PACKAGE, it generates a install_manifest.txt file in my build directory. It contains absolute paths to copy of install files I mentioned using install targets command. This temporary directory and its files are also created when

[CMake] target name collision

2014-03-27 Thread Aurelien Richez
Hi, I have two project that are independent and can be compiled on their own. I also have a bigger project which include these two project with add_subdirectory. However, these projects contain targets with the same names. As a consequence, cmake 2.8 complains with a message such as another

Re: [CMake] target name collision

2014-03-27 Thread Jakub Zakrzewski
Is there a reason, why you treat your independent projects with add_directory() instead of making them external projects? -- Gruesse, Jakub From: CMake [mailto:cmake-boun...@cmake.org] On Behalf Of Aurelien Richez Sent: Donnerstag, 27. März 2014 14:58 To: cmake@cmake.org Subject: [CMake]

Re: [CMake] target name collision

2014-03-27 Thread Angeliki Chrysochou
Hi Aurelien, Even though it is unsafe and not recommended, you could set policy CMP0002 to old so that cmake silently accepts non-unique target names like this: cmake_policy(SET CMP0002 OLD) I can't guarantee that your build will then work however. Another option is to write your own wrapper

Re: [CMake] target name collision

2014-03-27 Thread Aurelien Richez
Thanks Angeliki. I will try to do something like this. In fact I forgot to mention that my target which collide comes from add_custom target() but I can apply the same principle. To be more precise about the context, my projects have a target unit_test which is run tests each time I build

[CMake] multi-line strings... is this expected?

2014-03-27 Thread Matthew Woehlke
I have¹ a CTest like: execute_process(...) set(expected ...text... ...text... ) string(REGEX MATCH ${expected} match ${out}) So, basically, I'm checking that the process outputs a certain set of lines, and taking advantage of multi-line strings in CTest script for convenience and

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1484-g335850b

2014-03-27 Thread Stephen Kelly
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 335850b22fc76249b7d80d4745b3d781b1fa0e5c (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.0-rc3-391-g0301e36

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via 0301e36fcd033f24b73a779adcc3f3b265793d85 (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.0-rc3-389-gc53e820

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via c53e82093fbb541344f6d32640993fbb389c185a (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.0-rc3-395-ge8451d6

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via e8451d6426f6cd10ef1d0235b3358aee5d9cff17 (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.0-rc3-397-gede0419

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via ede0419a376cd3ddc26058f910318c76e0077bb1 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1490-gf376a82

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via f376a82b9fc79ff961b35c753c2b2beef546be7e (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1493-gcbd2444

2014-03-27 Thread Daniele E . Domenichelli
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via cbd2444b399f30af625b57ca3c1b1a26ac5ec020 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1496-g7f1a4a3

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 7f1a4a3930d6cc783793da4a89fa804a1785f439 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1499-g2d1fa0b

2014-03-27 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 2d1fa0bccae394270e3cc70edb2c747728f166b0 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1502-g4c0b1e3

2014-03-27 Thread Daniele E . Domenichelli
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 4c0b1e3de0974769e7a90ae2bb8f66e9802af8d1 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1507-g4ffd78e

2014-03-27 Thread Stephen Kelly
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 4ffd78e2709a3639b079bd6d8863472b83b0da3c (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1531-g98539c5

2014-03-27 Thread Stephen Kelly
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 98539c551dee1b3240a683b282dbdefd574f7de2 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.0-rc3-1548-g372f343

2014-03-27 Thread Daniele E . Domenichelli
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 372f343688f89c3610c78cacd46b4a19cc48e566 (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.0-rc3-398-gcab2e31

2014-03-27 Thread Kitware Robot
20140327) +set(CMake_VERSION_PATCH 20140328) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake