Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

2012-05-17 Thread Stephen Kelly
Peter Collingbourne wrote: On Sun, May 13, 2012 at 11:59:20PM +0200, Stephen Kelly wrote: Stephen Kelly wrote: Furthermore, there is no need to make paths within the build directory absolute. Each command must be invoked from the home output directory (i.e. the build root directory),

Re: [cmake-developers] Target usage requirements and conventions

2012-05-17 Thread Stephen Kelly
Alexander Neundorf wrote: On Sunday 13 May 2012, Stephen Kelly wrote: Stephen Kelly wrote: Hi there, The topic of 'target usage requirements' has come up several times. It's something I'd like to work further towards in CMake 2.8.9. I have created a wiki page on the KDE wiki

Re: [cmake-developers] Adding logic to CMake for -fPIE and -fPIC

2012-05-17 Thread Brad King
On 05/17/2012 08:36 AM, Stephen Kelly wrote: Done and re-pushed to my clone. I still have to write the unit tests, but I think it can be reviewed again at this point. Great start. Here are some comments. The Update the documentation of IMPORTED_LOCATION to match the code. commit has an

Re: [cmake-developers] Target usage requirements and conventions

2012-05-17 Thread Brad King
On 05/17/2012 09:25 AM, Stephen Kelly wrote: $IF($CONFIGURATION MATCHES Debug AND $LANGUAGE STREQUALS CXX)... I'm not sure what should go in the ... part though. Some syntax to delimit the then/else values would be needed. I'm not sure else() and endif() are needed as additional

Re: [cmake-developers] Handling of Config specific imported targets?

2012-05-17 Thread Stephen Kelly
Brad King wrote: On 05/17/2012 09:41 AM, Stephen Kelly wrote: Great, so choosing the correct imported configuration a solved problem. I'll point the documentation in of the Qt 5 CMake stuff to that so. Note that MAP_IMPORTED_CONFIG_CONFIG should not be set by package configuration files.

Re: [cmake-developers] Target usage requirements and conventions

2012-05-17 Thread Stephen Kelly
Brad King wrote: On 05/17/2012 09:25 AM, Stephen Kelly wrote: $IF($CONFIGURATION MATCHES Debug AND $LANGUAGE STREQUALS CXX)... I'm not sure what should go in the ... part though. Some syntax to delimit the then/else values would be needed. I'm not sure else() and endif() are needed

[cmake-developers] [CMake 0013234]: Ninja: Add support for IMPLICIT_DEPENDS in add_custom_command

2012-05-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13234 == Reported By:Mathias Gaunard Assigned To:

Re: [cmake-developers] conditionals in generator expressions (was: Target usage requirements and conventions)

2012-05-17 Thread Brad King
On 05/17/2012 10:31 AM, Stephen Kelly wrote: We may not need the else part but we still need a strict and extensible syntax to delimit the value in the ... part above. not certain what you have in mind with 'extensible' or if you have any ideas of how it might need to be extended. The

Re: [cmake-developers] conditionals in generator expressions (was: Target usage requirements and conventions)

2012-05-17 Thread David Cole
I don't think this conditional stuff in generator expressions is a good idea at all. It's going to be ugly and very hard to read, and make people hate the CMake language even more than they already do. If there's any way at all that supports what we want but does not require conditionals, then