The following issue has been SUBMITTED.
==
http://www.itk.org/Bug/view.php?id=13257
==
Reported By:Andreas Mohr
Assigned To:
Brad King wrote:
On 05/29/2012 12:16 PM, Stephen Kelly wrote:
Done, though I left some notes in the commit for now. It seems the
existing variable is used for more than just PIC equivalents.
Thanks for going through all the platforms!
I think the only non-PIC instances are for Watcom and
Looks like there is one more left:
http://open.cdash.org/testDetails.php?test=146498578build=2319638
-Bill
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
On Wed, May 30, 2012 at 6:20 AM, Stephen Kelly steve...@gmail.com wrote:
RISCos.cmake and ULTRIX.cmake contains '-G 0' and HP-UX-HP.cmake contains
+Z. I don't know what they are really for.
HP's +Z option is for PIC:
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13258
==
Reported By:Clinton Stimpson
Assigned To:
What a mess. Sorry about that.
Updated now.
Thanks,
Steve.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow
On 05/30/2012 12:26 PM, Stephen Kelly wrote:
What a mess. Sorry about that.
Updated now.
Great, that looks pretty good. A couple more comments:
The KWStyle test fails due to a few lines too long. Use:
$ git log master.. -p --pickaxe-regex -S.{80} -- Source
to look for hunks that add
Bill Hoffman wrote:
Looks like there is one more left:
http://open.cdash.org/testDetails.php?test=146498578build=2319638
Hmm, I'm not sure how to solve this.
It seems like the full path to the compiler with backslashes doesn't have
its backslashes escaped, and they get stripped on the
Brad King wrote:
Also the code near calls to GetShouldUseOldFlags is not
indented with our convention.
I've had a look, and I don't see the breaks from the convention. Can you say
what commits and hunks?
I haven't tried to implement the XCode patch, but I removed the use from the
On 05/30/2012 02:22 PM, Stephen Kelly wrote:
Brad King wrote:
Also the code near calls to GetShouldUseOldFlags is not
indented with our convention.
I've had a look, and I don't see the breaks from the convention. Can you say
what commits and hunks?
In the makefile generator:
+if
10 matches
Mail list logo