Re: [cmake-developers] [Review request] Topic ExternalProject_SCM_DISCONNECTED

2014-11-05 Thread Daniele E. Domenichelli
On 05/11/14 17:39, Brad King wrote: > Would the name "UPDATE_INDEPENDENT" or "UPDATE_DISCONNECTED" > make more sense? Otherwise, the topic looks ready for testing > to me. "UPDATE_INDEPENDENT" might be confused with something related to "INDEPENDENT_STEP_TARGETS", so I'd rather choose between SCM

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Ben Boeckel
On Wed, Nov 05, 2014 at 15:03:02 -0800, Peter Collingbourne wrote: > On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > > For the testing of it, since only Ninja supports it, maybe it would be > > possible to run a program which exits testing for isatty(STDIN_FILENO) > > or isatty(STDOU

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Peter Collingbourne
On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > On Wed, Nov 05, 2014 at 13:12:13 -0800, Peter Collingbourne wrote: > > I've added documentation and tests and addressed Ben's comments, and > > published > > the staging branch 'console-pool'. PTAL. > > Thanks for splitting the commit

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Ben Boeckel
On Wed, Nov 05, 2014 at 13:12:13 -0800, Peter Collingbourne wrote: > I've added documentation and tests and addressed Ben's comments, and published > the staging branch 'console-pool'. PTAL. Thanks for splitting the commits. For the testing of it, since only Ninja supports it, maybe it would be p

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Peter Collingbourne
On Mon, Nov 03, 2014 at 04:22:56PM -0800, Peter Collingbourne wrote: > Hi all, > > This patch exposes the Ninja console pool feature via the add_custom_command > and add_custom_target commands. Specifically, it introduces a USE_CONSOLE > flag which can be used to communicate to the generator that

Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

2014-11-05 Thread Brad King
On 11/05/2014 01:11 PM, Geoffrey Viola wrote: > I rebased and squashed the previous commits and made some new changes. Thanks. Here are more comments. The hunk in Modules/CMakeSystemSpecificInformation.cmake is now just removing a blank line so it should not be needed. > +message("GHS-Determine

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Brad King
On 11/05/2014 02:32 PM, Tim Gallagher wrote: > Next time I won't have to go back and forth several times It's no problem. That's part of the code review process and is to be expected. Thanks for your patience with it. -Brad -- Powered by www.kitware.com Please keep messages on-topic and che

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Tim Gallagher
Great, thank you. Next time I won't have to go back and forth several times (I hope)! Tim - Original Message - From: "Brad King" To: "Tim Gallagher" Cc: cmake-developers@cmake.org Sent: Wednesday, November 5, 2014 2:19:06 PM Subject: Re: [cmake-developers] Assembly/preprocessed targets

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Brad King
On 11/05/2014 01:53 PM, Tim Gallagher wrote: > Here's to hoping 3rd time's the charm... Thanks. Applied with minor tweaks: Makefile: Refactor checks for lang-specific targets and export compile cmds http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=06f8b429 Makefile: Add assembly and prepro

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Tim Gallagher
Here's to hoping 3rd time's the charm... Also, what version of gfortran do you have that requires both -E and -cpp to do the preprocessing? I don't need that on my version, I'm using 4.7.1. There may need to be more sophisticated logic in the Compiler module to add -cpp to the command line for

Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

2014-11-05 Thread Geoffrey Viola
I rebased and squashed the previous commits and made some new changes. The GHS generator should now build a kernel and a monolith, which is necessary to autogenerate all the files necessary to compile. The generator determines that the executable target is a kernel based on a compiler flag and d

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Brad King
On 11/05/2014 12:14 PM, Tim Gallagher wrote: > I have attached an updated patch Thanks! Please split this into two patches. The first one should do the refactoring of the variable name and corresponding logic with no functionality changes. The second one can add the Fortran feature. Also pleas

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Tim Gallagher
Sorry about the TABs, I guess emacs defaults to it and I never noticed. I have attached an updated patch where the tabs are removed and the test for CMAKE_EXPORT_COMPILE_COMMANDS is also removed. Tim - Original Message - From: "Brad King" To: "tim gallagher" , cmake-developers@cmake.o

Re: [cmake-developers] GCC HPPA linker errors

2014-11-05 Thread Rolf Eike Beer
Am Mittwoch, 5. November 2014, 10:38:14 schrieben Sie: > So, it seems nothing changed. Looking at the log though, it looks like the > flags aren't even getting used. Can you check the output of uname with > it's various options? I suspect the result might not be exactly "parisc". voyager ~ # un

Re: [cmake-developers] install(DIRECTORY) genex support

2014-11-05 Thread Tim Blechmann
hi brad, >> [1] https://github.com/Kitware/CMake/pull/124 > > Good start. Please extend documentation and tests for this feature > similar to how it was done for install(FILES) in the above-linked > commit. > > Then please read CONTRIBUTING.rst and send the patch to this list > for further revi

Re: [cmake-developers] [Review request] Topic ExternalProject_SCM_DISCONNECTED

2014-11-05 Thread Brad King
On 11/05/2014 03:58 AM, Daniele E. Domenichelli wrote: > If SCM_DISCONNECTED is set, the update step is not executed > automatically when building the main target. The update step can still > be added as a step target and called manually. Good feature. Would the name "UPDATE_INDEPENDENT" or "UPDA

Re: [cmake-developers] install(DIRECTORY) genex support

2014-11-05 Thread Brad King
On 11/05/2014 07:01 AM, Tim Blechmann wrote: > i wonder, is there any reason for not supporting generator expressions > for install(DIRECTORY)? It just hasn't been implemented. Support for generator expressions was added to install(FILES) here: install: Support generator expressions in FILES an

Re: [cmake-developers] Assembly/preprocessed targets for Fortran

2014-11-05 Thread Brad King
On 11/04/2014 06:37 PM, Tim Gallagher wrote: > I have attached the patch to enable the targets for Fortran. Thanks. Please update it to avoid using hard TABs for indentation. Also in the CompileCommandOutput test hunk: > -project (CompileCommandOutput CXX) > +project (CompileCommandOutput) > +en

Re: [cmake-developers] GCC HPPA linker errors

2014-11-05 Thread Brad King
On 11/05/2014 10:38 AM, Chuck Atkins wrote: > So, it seems nothing changed. Looking at the log though, it > looks like the flags aren't even getting used. The value of cmake_machine_parisc is not set on HP-UX by the bootstrap script so it can only ever work on Linux right now. These changes brok

Re: [cmake-developers] GCC HPPA linker errors

2014-11-05 Thread Chuck Atkins
So, it seems nothing changed. Looking at the log though, it looks like the flags aren't even getting used. Can you check the output of uname with it's various options? I suspect the result might not be exactly "parisc". - Chuck On Tue, Nov 4, 2014 at 4:27 PM, Chuck Atkins wrote: > just a mat

Re: [cmake-developers] [CMake] Forwarding parameters to cmake through cmake-gui

2014-11-05 Thread Brad King
On 11/04/2014 06:38 PM, Eric Wing wrote: > This would be really useful to me. No one plans to work on it AFAIK. You'd have to dig in yourself. Sorry, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware of

[cmake-developers] install(DIRECTORY) genex support

2014-11-05 Thread Tim Blechmann
hi all, i wonder, is there any reason for not supporting generator expressions for install(DIRECTORY)? i need this functionality to be able to install dSYM folders which are generated by xcode. if not, could someone review/merge this patch [1]? it is probably too late for 3.1, right? thanks a lo

[cmake-developers] [Review request] Topic ExternalProject_SCM_DISCONNECTED

2014-11-05 Thread Daniele E. Domenichelli
Hello all, Please review the topic ExternalProject_SCM_DISCONNECTED. This patch adds a SCM_DISCONNECTED option to ExternalProject_Add. If SCM_DISCONNECTED is set, the update step is not executed automatically when building the main target. The update step can still be added as a step target and