Re: [cmake-developers] [Patch] Adding Windows 10 support

On 09/23/2015 01:29 AM, Gilles Khouzam wrote: > Now, for the default behavior, if > CMAKE_WINDOWS_TARGET_PLATFORM_VERSION is set through a toolchain > file or the project, then that will be the default which will > initialize the WINDOWS_TARGET_PLATFORM_VERSION for each target > through the

Re: [cmake-developers] generator expression for path slash conversion

I wrote the documentation, added a genex test that checks it the given path is converted as expected on different platforms, and added another ExternalProject test for Windows that invokes pushd, which is is command sensitive to the path style. I wasn't sure about the VERSION I am supposed to

Re: [cmake-developers] Help with diagnosing dashboard failure

On 09/22/2015 05:03 PM, Stephen Kelly wrote: > A few days ago I merged a commit which moves the construction of > cmLocalGenerator objects. > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a3aa333d > > It fails on the RunCMake.try_compile test on several dashboards in the > CMP0056 test

Re: [cmake-developers] [Patch] Adding Windows 10 support

>CMAKE_SYSTEM_NAME is already always defined to a value detected from the host >system when not defined by a toolchain file or by the user in the cache. On a >Windows host the value will be "Windows". >I don't fully understand the case in question. When not building for Windows >Store, does

Re: [cmake-developers] generator expression for path slash conversion

On 09/23/2015 08:40 AM, Kislinskiy, Stefan wrote: > I wrote the documentation, added a genex test that checks it the > given path is converted as expected on different platforms, and > added another ExternalProject test for Windows that invokes > pushd, which is is command sensitive to the path

Re: [cmake-developers] Generator expressions for install destination

Brad, if I made that patch clean with tests, would you accept it for 3.4? It doesn't require any refactoring with what Steven mentioned. -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Stephen Kelly Sent: Tuesday, September 22, 2015

Re: [cmake-developers] Help with diagnosing dashboard failure

Brad King wrote: > On 09/22/2015 05:03 PM, Stephen Kelly wrote: >> A few days ago I merged a commit which moves the construction of >> cmLocalGenerator objects. >> >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a3aa333d >> >> It fails on the RunCMake.try_compile test on several

Re: [cmake-developers] Generator expressions for install destination

On 09/23/2015 01:47 PM, Robert Goulet wrote: > Updated patch for install(FILES) DESTINATION genex support. Test added as > well. Thanks. I applied it without the test: install: Allow generator expressions in FILES DESTINATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=17aa6fd3 and

Re: [cmake-developers] Help with diagnosing dashboard failure

Brad King wrote: > On 09/23/2015 01:15 PM, Stephen Kelly wrote: >> Yes, however the revision was not correct. The current fix-max-path- >> initialization branch does not use that revision. >> >>> cmGlobalGenerator: Create local generator after configuring the >>> makefile.

Re: [cmake-developers] Generator expressions for install destination

Updated patch for install(FILES) DESTINATION genex support. Test added as well. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday, September 23, 2015 10:19 AM To: Robert Goulet ; Stephen Kelly ;

Re: [cmake-developers] Help with diagnosing dashboard failure

On 09/23/2015 01:15 PM, Stephen Kelly wrote: > Yes, however the revision was not correct. The current fix-max-path- > initialization branch does not use that revision. > >> cmGlobalGenerator: Create local generator after configuring the makefile. >>

Re: [cmake-developers] Generator expressions for install destination

Alright thanks Brad! I have a similar change that applies the exact same code logic to install(DIRECTORY), but I haven't wrote the test yet. Should I still write a test for it before I send it to you? -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday,

Re: [cmake-developers] [CPackDeb] empty directories in packages

Le 22/09/15 12:03, Domen Vrankar a écrit : I was looking at this issue http://public.kitware.com/Bug/view.php?id=13009 and apparently it is not possible to install empty directories (I just tested). I believe that it should be possible to do that (even if there are better ways like postinst).

Re: [cmake-developers] Generator expressions for install destination

On 09/23/2015 03:19 PM, Robert Goulet wrote: > I have a similar change that applies the exact same code logic > to install(DIRECTORY), but I haven't wrote the test yet. Should > I still write a test for it before I send it to you? Yes, please. Base the commit on 69ab5f55. You should be able to

Re: [cmake-developers] Generator expressions for install destination

Here is the patch to support genex for install(DIRECTORY) command DESTINATION option. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday, September 23, 2015 3:37 PM To: Robert Goulet ; cmake-developers@cmake.org Subject: Re:

[cmake-developers] [CMake 0015757]: Including a project from parent subdirectory causes CMake to produce wrong build files for Ninja generator

The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15757 == Reported By:Pavel Solodovnikov Assigned To:

Re: [cmake-developers] [Patch] Adding Windows 10 support

Ok, I've got this working as discussed. This adds only the WINDOWS_TARGET_PLATFORM_VERSION property as it currently only supports the desktop scenario and is extracted from the rest of the Windows 10 Store support. This property enables a Windows 10 Desktop project to use a specific version of