Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-14 Thread Peter Collingbourne
On Wed, Nov 05, 2014 at 06:35:25PM -0500, Ben Boeckel wrote: On Wed, Nov 05, 2014 at 15:03:02 -0800, Peter Collingbourne wrote: On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: For the testing of it, since only Ninja supports it, maybe it would be possible to run a program

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Peter Collingbourne
On Mon, Nov 03, 2014 at 04:22:56PM -0800, Peter Collingbourne wrote: Hi all, This patch exposes the Ninja console pool feature via the add_custom_command and add_custom_target commands. Specifically, it introduces a USE_CONSOLE flag which can be used to communicate to the generator

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-04 Thread Peter Collingbourne
On Tue, Nov 04, 2014 at 12:53:07AM -0500, Ben Boeckel wrote: On Mon, Nov 03, 2014 at 16:22:56 -0800, Peter Collingbourne wrote: This patch exposes the Ninja console pool feature via the add_custom_command and add_custom_target commands. Specifically, it introduces a USE_CONSOLE flag which

[cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-03 Thread Peter Collingbourne
other than the Ninja generator. The patch also causes the feature to be used with the built-in cache editor. Docs/tests to come. Any comments on the proposed approach are appreciated. Thanks, -- Peter From eaebc04718f1a96c59ac03d21ebb4bb95db4475f Mon Sep 17 00:00:00 2001 From: Peter Collingbourne

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Peter Collingbourne
On Wed, Jun 13, 2012 at 05:34:14PM +0200, Peter Kümmel wrote: On 13.06.2012 15:31, Amine Khaldi wrote: Please don't consider Windows as done until proper dependency tracking is in place (it's lacking so far for rc files). Please test stage. I've added rc file dependency tracking. It's a

Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS

2012-05-16 Thread Peter Collingbourne
On Sun, May 13, 2012 at 11:59:20PM +0200, Stephen Kelly wrote: Stephen Kelly wrote: Furthermore, there is no need to make paths within the build directory absolute. Each command must be invoked from the home output directory (i.e. the build root directory), so each command's directory

Re: [cmake-developers] ninja status

2012-04-07 Thread Peter Collingbourne
On Sat, Apr 07, 2012 at 10:00:41PM +0200, Peter Kümmel wrote: On 07.04.2012 21:56, Peter Kümmel wrote: By default Ninja support is not enabled on Windows and Mac, somehow it was build the last times but I touched the cmake code there and introduced a FORCE:

Re: [cmake-developers] Ninja: Recognize OBJECT and CMAKE_C_COMPILER in CMAKE_DEPFILE_FLAGS_${lang}

2012-03-25 Thread Peter Collingbourne
On Fri, Mar 23, 2012 at 08:52:42AM -0400, Brad King wrote: On 3/22/2012 12:23 PM, Amine Khaldi wrote: I've attached a patch that allows us (ReactOS) ... to properly track dependencies in rc files. Peter, as maintainer of the Ninja generator how does this look to you? I think this is fine,

Re: [cmake-developers] depend problem on windows

2012-03-17 Thread Peter Collingbourne
On Thu, Mar 15, 2012 at 10:24:49AM -0400, Bill Hoffman wrote: So, I did a git branch switch to next and ran ninja on my build tree. It correctly re-ran cmake. But I found a link error building cmake-gui: CMakeLib.lib(cmLocalVisualStudio10Generator.cxx.obj) : error LNK2001: unresolved

Re: [cmake-developers] ninja bug on windows

2012-03-14 Thread Peter Collingbourne
On Wed, Mar 14, 2012 at 10:52:22AM -0400, Bill Hoffman wrote: On 3/13/2012 10:39 PM, Peter Collingbourne wrote: Maybe another time we can think about ways to improve PCH support, but for now I guess we can add an OR Ninja to this test and add OBJECT_OUTPUTS support to the Ninja generator. I

Re: [cmake-developers] new ninja rebuild too much issue

2012-03-14 Thread Peter Collingbourne
On Wed, Mar 14, 2012 at 10:45:39AM -0400, Bill Hoffman wrote: On 3/14/2012 7:34 AM, Nicolas Desprès wrote: Nope if you like in the generated build.ninja build.ninja appears only once as an output using the RERUN_CMAKE rule. I rather think it is a bug in ninja of the restat implementation.

Re: [cmake-developers] Ninja/VS: fixed PDB name

2012-03-13 Thread Peter Collingbourne
On Wed, Mar 14, 2012 at 02:45:44AM +0100, Óscar Fuentes wrote: The compile and link commands executed by ninja contains the same option: /FdTARGET_PDB (TARGET_PDB here is literal text, not a placeholder.) This is a simplified excerpt from a .ninja.log file: 5969 11219 0

Re: [cmake-developers] ninja bug on windows

2012-03-13 Thread Peter Collingbourne
On Tue, Mar 13, 2012 at 07:08:31PM -0400, Bill Hoffman wrote: PrecompiledHeader - This one seems to be a dependency problem. The first time you run it you get this: 122: Run Build Command:C:/cygwin/bin/ninja.exe [3/4] Building C object CMakeFiles\foo.dir\foo1.c.obj 122: FAILED:

Re: [cmake-developers] ninja bug on windows

2012-03-10 Thread Peter Collingbourne
On Fri, Mar 09, 2012 at 02:10:45PM -0500, Bill Hoffman wrote: I am seeing that ninja always wants to relink the executables for me every time it is run. The output is this: $ ninja [1/9] Linking C static library Utilities\cmlibarchive\libarchive\cmlibarchive.lib [2/9] Linking CXX

Re: [cmake-developers] Rename Ninja generator?

2012-03-08 Thread Peter Collingbourne
On Thu, Mar 08, 2012 at 05:44:09PM -0500, Bill Hoffman wrote: I am wondering if we want to call the Ninja generator something like: Ninja Makefiles... It is not totally accurate, but it avoids code like this: IF(CMAKE_GENERATOR MATCHES Makefiles OR CMAKE_GENERATOR MATCHES Ninja) Also,

Re: [cmake-developers] Rename Ninja generator?

2012-03-08 Thread Peter Collingbourne
On Thu, Mar 08, 2012 at 09:25:37PM -0500, Bill Hoffman wrote: On 3/8/2012 8:37 PM, Alan W. Irwin wrote: I think that would be confusing to users. Could you define an internal variable (to identify those generators that have Makefile-like characteristics) that could be tested instead of

Re: [cmake-developers] Ninja windows

2012-03-06 Thread Peter Collingbourne
On Tue, Mar 06, 2012 at 11:44:46AM -0500, Bill Hoffman wrote: What is the current status of ninja windows? I would like to setup a dashboard for this, however, the ninja code for windows does not seem to be on the stage for CMake right now. Is there a way to get it on the stage? Or

Re: [cmake-developers] Ninja generator on Windows

2012-02-01 Thread Peter Collingbourne
On Tue, Jan 31, 2012 at 10:42:40PM -0500, Bill Hoffman wrote: On 1/31/2012 5:58 PM, Peter Collingbourne wrote: That will be handy when it comes time to integrate this work upstream because KWSys is shared with other projects. Why isn't that time now? The generator already works

Re: [cmake-developers] Ninja generator on Windows

2012-01-31 Thread Peter Collingbourne
On Tue, Jan 31, 2012 at 10:32:23PM +0100, Peter Kümmel wrote: On 31.01.2012 16:19, Peter Collingbourne wrote: On Tue, Jan 31, 2012 at 12:15:59AM +0100, Peter Kümmel wrote: - Paths like 'c:\' - Ninja now supports colon escaping c: - c$: Is there a single place where the escaping could

Re: [cmake-developers] [PATCH 0/3] The CMake Ninja generator.

2012-01-25 Thread Peter Collingbourne
On Tue, Jan 03, 2012 at 01:15:17AM +, Peter Collingbourne wrote: On Sat, Nov 12, 2011 at 02:36:04AM +, Peter Collingbourne wrote: Hi, These patches add the Ninja generator to CMake, which I am now proposing for inclusion in mainline. [...] This patch series is also available

Re: [cmake-developers] [PATCH 0/3] The CMake Ninja generator.

2012-01-02 Thread Peter Collingbourne
On Sat, Nov 12, 2011 at 02:36:04AM +, Peter Collingbourne wrote: Hi, These patches add the Ninja generator to CMake, which I am now proposing for inclusion in mainline. [...] This patch series is also available from my git repository: git://github.com/pcc/CMake.git ninja-generator-pr

Re: [cmake-developers] [PATCH 3/3] Add the Ninja generator

2011-11-22 Thread Peter Collingbourne
On Mon, Nov 14, 2011 at 08:18:16AM +0100, Rolf Eike Beer wrote: diff --git a/Modules/Compiler/GNU.cmake b/Modules/Compiler/GNU.cmake index 8d6f5df..bdcaf9d 100644 --- a/Modules/Compiler/GNU.cmake +++ b/Modules/Compiler/GNU.cmake @@ -24,6 +24,15 @@ macro(__compiler_gnu lang)

Re: [cmake-developers] [PATCH 2/3] Add support for executable with exports flags to cmLocalGenerator::GetTargetFlags

2011-11-12 Thread Peter Collingbourne
On Sat, Nov 12, 2011 at 10:45:04AM -0500, David Cole wrote: Looks like PATCH 3/3 didn't come through... (too large for the mailing list?) It apparently requires moderator approval due to its size: Your mail to 'cmake-developers' with the subject [PATCH 3/3] Add the Ninja generator Is

[cmake-developers] [PATCH 0/3] The CMake Ninja generator.

2011-11-11 Thread Peter Collingbourne
Hi, These patches add the Ninja generator to CMake, which I am now proposing for inclusion in mainline. The generator should work with the current 'master' branch of Ninja from: https://github.com/martine/ninja The generator passes the CMake test suite on Linux (Debian testing) and FreeBSD

[cmake-developers] [PATCH 1/3] Add SystemTools::TrimWhitespace function

2011-11-11 Thread Peter Collingbourne
--- Source/kwsys/SystemTools.cxx| 15 +++ Source/kwsys/SystemTools.hxx.in |5 + 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/Source/kwsys/SystemTools.cxx b/Source/kwsys/SystemTools.cxx index 1bf19c0..c14eb38 100644 --- a/Source/kwsys/SystemTools.cxx

Re: [cmake-developers] [PATCH 0/7] Preparation for Ninja generator: refactorings, bug fixes

2011-11-09 Thread Peter Collingbourne
On Tue, Oct 04, 2011 at 11:21:00PM +0200, Peter Kümmel wrote: On 04.10.2011 23:19, Peter Kümmel wrote: On 03.10.2011 15:03, Brad King wrote: On 10/2/2011 1:41 PM, Peter Collingbourne wrote: I have modified the commit message to include more details, and pushed a modified branch to github

Re: [cmake-developers] [PATCH 0/7] Preparation for Ninja generator: refactorings, bug fixes

2011-10-02 Thread Peter Collingbourne
On Tue, Sep 27, 2011 at 08:19:39AM -0400, Brad King wrote: On 9/26/2011 11:48 PM, Peter Collingbourne wrote: Now that the Ninja generator is passing all tests on Linux, I have decided to start preparing patches, and I am starting with some refactorings and bug fixes developed in the course

Re: [cmake-developers] [PATCH 1/7] Refactor TargetTypeNames.

2011-10-02 Thread Peter Collingbourne
On Tue, Sep 27, 2011 at 05:32:19PM +0200, Nicolas Desprès wrote: On Tue, Sep 27, 2011 at 3:55 PM, Rolf Eike Beer e...@sf-mail.de wrote: From: Nicolas Despres nicolas.desp...@gmail.com Make it a static method instead of an array. It is safer for the type checking and if we add a new target

Re: [cmake-developers] [PATCH 7/7] Fix configuration-dependent flag lookup in cmLocalGenerator::GetTargetFlags

2011-10-02 Thread Peter Collingbourne
On Tue, Sep 27, 2011 at 05:33:44PM +0200, Nicolas Desprès wrote: On Tue, Sep 27, 2011 at 4:03 PM, Rolf Eike Beer e...@sf-mail.de wrote: ---  Source/cmLocalGenerator.cxx |   23 ---  1 files changed, 20 insertions(+), 3 deletions(-) diff --git

[cmake-developers] [PATCH 5/7] Introduce a cmLocalGenerator::ConvertToIncludeReference function

2011-09-26 Thread Peter Collingbourne
This provides a mechanism for the local generator to override how header search paths are generated. --- Source/cmLocalGenerator.cxx |9 - Source/cmLocalGenerator.h |4 +++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/Source/cmLocalGenerator.cxx

[cmake-developers] [PATCH 0/7] Preparation for Ninja generator: refactorings, bug fixes

2011-09-26 Thread Peter Collingbourne
Hi, Now that the Ninja generator is passing all tests on Linux, I have decided to start preparing patches, and I am starting with some refactorings and bug fixes developed in the course of developing the Ninja generator. Three of the patches were originally by Nicolas Despres, the rest are by

[cmake-developers] [PATCH 2/7] Add const versions of some getters.

2011-09-26 Thread Peter Collingbourne
From: Nicolas Despres nicolas.desp...@gmail.com --- Source/cmGlobalGenerator.h |1 + Source/cmLocalGenerator.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Source/cmGlobalGenerator.h b/Source/cmGlobalGenerator.h index 88eb8b6..97cacc5 100644 ---

[cmake-developers] [PATCH 4/7] Make cmLocalGenerator::ConvertToLinkReference virtual

2011-09-26 Thread Peter Collingbourne
This provides a mechanism for the local generator to override how library search paths are generated. --- Source/cmLocalGenerator.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Source/cmLocalGenerator.h b/Source/cmLocalGenerator.h index 1f5a26e..69e452b 100644 ---

[cmake-developers] [PATCH 3/7] Constify many getters of cmGlobalGenerator.

2011-09-26 Thread Peter Collingbourne
From: Nicolas Despres nicolas.desp...@gmail.com --- Source/cmGlobalGenerator.h | 32 +++--- Source/cmGlobalUnixMakefileGenerator3.h | 22 ++-- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/Source/cmGlobalGenerator.h

[cmake-developers] [PATCH 7/7] Fix configuration-dependent flag lookup in cmLocalGenerator::GetTargetFlags

2011-09-26 Thread Peter Collingbourne
--- Source/cmLocalGenerator.cxx | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx index aeda164..4044876 100644 --- a/Source/cmLocalGenerator.cxx +++ b/Source/cmLocalGenerator.cxx @@ -1463,6

[cmake-developers] [PATCH 6/7] Introduce a cmGlobalGenerator::ResolveLanguageCompiler function

2011-09-26 Thread Peter Collingbourne
It is factored out of cmGlobalUnixMakefileGenerator3::EnableLanguage, and may be used by other generators to resolve CMAKE_*_COMPILER settings. --- Source/cmGlobalGenerator.cxx | 73 + Source/cmGlobalGenerator.h|7 +++