Re: [cmake-developers] Hi and issues with FindBoost

On 04/02/2019 10:10, Robert Sawko wrote: I couldn't find a dedicated bug tracker for cmake modules. https://gitlab.kitware.com/cmake/cmake/issues/ It's the same bug tracker as for the rest of CMake, since it's all a single codebase. If you put "FindBoost: " as the prefix of the issue

Re: [cmake-developers] module proposal: PreventInSourceBuilds

On 09/11/2018 10:34, Joachim Wuttke wrote: In all my projects, the top-level CMakeLists.txt contains the line include(PreventInSourceBuilds) to protect users (and myself) from unintentionally running CMake in the source directory. I for one have an equivalent to this logic in all my projects

Re: [cmake-developers] Trouble with FindPNG module

On 24/04/2017 19:30, Ben Boeckel wrote: On Mon, Apr 24, 2017 at 19:17:39 +0100, Roger Leigh wrote: Sounds like that's exactly the problem. You can only have one libpng *development* package installed at once. You probably want the regular "libpng-dev" package installed if you wan

Re: [cmake-developers] Trouble with FindPNG module

On 24/04/2017 15:54, Robert Dailey wrote: Sorry to bump; any info on this? I'm completely blocked :-( On Fri, Apr 21, 2017 at 4:48 PM, Robert Dailey wrote: I'm running CMake 3.8.0 on Ubuntu 14. I invoke the following: find_package(PNG REQUIRED) Which gives me the

[cmake-developers] Support for version suffixes

Hi folks, I'd like to bring this issue to your attention to canvas some feedback regarding the use of version suffixes: https://gitlab.kitware.com/cmake/cmake/issues/16716 This is basically a proposal to allow an optional version suffix like "-rc3", "-beta1" etc. in addition to the

Re: [cmake-developers] Boost 1.63 support

On 27/12/2016 14:34, Gregor Jasny via cmake-developers wrote: Hello, On 27/12/2016 13:20, Roger Leigh wrote: I opened the following merge request to add support for the newly-released Boost 1.63: https://gitlab.kitware.com/cmake/cmake/merge_requests/361 I wonder what's the reason

[cmake-developers] Boost 1.63 support

I opened the following merge request to add support for the newly-released Boost 1.63: https://gitlab.kitware.com/cmake/cmake/merge_requests/361 Kind regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

[cmake-developers] [patch] Add support for Ice 3.6.3 to FindIce

Branch: ice-3.6.3. Pushed to next for testing. This is for a new point release recently issued by upstream. Regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to

[cmake-developers] [patch] FreeBSD build fix

With FreeBSD 11, I was getting a link failure due to missing kvm symbols in Utilities/cmlibuv. The fix is a trivial addition. It's added unconditionally; I checked for its presence in FreeBSD 11, 10 and 9. Branch: freebsd-kvm-link Merged into stage for testing. Regards, Roger -- Powered

[cmake-developers] [patch] BZip2 imported targets

Adds BZip2::BZip2 imported target and documentation, along with unit test which may be enabled with the CMake_TEST_FindBZip2 option. Derived from the existing code in FindZLib. Branch: bzip2-imported-targets Merged into stage for testing. Regards, Roger -- Powered by www.kitware.com

Re: [cmake-developers] [patch] Expose GNUInstallDirs absolute path algorithm

On 30/08/2016 14:53, Brad King wrote: On 08/28/2016 01:51 PM, Roger Leigh wrote: The macro name might need adjusting The idea looks fine to me. Typically we name module-provided APIs with the module name. How about "GNUInstallDirs_get_absolute_install_dir"? I'm also ope

[cmake-developers] [patch] Expose GNUInstallDirs absolute path algorithm

n principle. Kind regards, Roger >From ed6301e40a8b5d71fb45b55a8ac2dbacb5804be7 Mon Sep 17 00:00:00 2001 From: Roger Leigh <rle...@codelibre.net> Date: Sun, 28 Aug 2016 18:19:02 +0100 Subject: [PATCH] GNUInstallDirs: Add set_full_install_dir macro --- Modu

Re: [cmake-developers] Security in CMake

CMake is not and can never be a replacement for a package manager. They serve entirely different roles. While you can extend CMake to give it the ability to build and install all sorts stuff, that does not make it a package manager. It's a convenient way to build a complex set of

[cmake-developers] [patch] Fix variable naming in FindTIFF unit test

Straightforward renaming, in https://gitlab.kitware.com/cmake/cmake/merge_requests/33 which is also merged into next for testing. Regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers

Re: [cmake-developers] Using a custom DSL compiler in CMake

On 21/06/2016 18:18, Chris Bieneman wrote: Hello cmake-developers, I’m trying to find a solution to a long running problem in our build. In LLVM we have a domain specific language named TableGen that we use to generate header files used throughout the project. Our current solution to work

[cmake-developers] [patch] FindIce updates

I have opened a couple of merge requests here, and also merged these into next for testing: https://gitlab.kitware.com/cmake/cmake/merge_requests/17 https://gitlab.kitware.com/cmake/cmake/merge_requests/19 The first adds support for the latest 3.6.x releases. The second adds support for

[cmake-developers] [patch] FindBZip2: Add additional debug library name

I noticed that FindBZip2.cmake was searching for the bzip2d debug library but not bz2d (it uses bz2 and bzip2 for the release library names). While bzip2[d] is the common form on Windows, which is what the upstream nmake build creates, there are at least two CMake builds for bzip2 which use

[cmake-developers] [PATCH] FindBoost: Boost 1.61

Boost 1.61 was released today. My boost-1.61 branch, merged into next, adds the updated dependency information for this release. The version information was already added, so is unchanged. Regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ

Re: [cmake-developers] [PATCH] FindBoost does not detect absence of header file

On 13/05/2016 14:36, Brad King wrote: On 05/12/2016 03:49 PM, Roger Leigh wrote: I have made the suggested changes above where this was possible, and merged the boost-component-headers branch into next for testing. Thanks. It looks pretty good, but there is one problem: +find_path

Re: [cmake-developers] [PATCH] FindBoost does not detect absence of header file

On 11/05/2016 19:43, rle...@codelibre.net wrote: On 2016-05-11 19:30, Chuck Atkins wrote: I guess it doesn't really matter but for the libraries that don't have a single include header, should you be using these instead: * container/container_fwd.hpp * exception/all.hpp *

[cmake-developers] [PATCH] Always define Boost::boost imported target

For https://cmake.org/Bug/view.php?id=16057 I have merged the boost-import-default branch into next for testing. This includes a unit test to verify that the basic boost headers work in the absence of COMPONENTS being specified with find_package. Regards, Roger -- Dr Roger Leigh -- Open

[cmake-developers] #16013 merged for testing

Hi folks, I've merged the branch boost-optional-indirect-deps into next for testing (for https://cmake.org/Bug/view.php?id=16013). Kind regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware

Re: [cmake-developers] CMakeFindDependencyMacro limitations

On 24/02/2016 22:49, Roger Leigh wrote: I've attached a patch for a very simple modification to find_dependency. I'm not proposing that it be merged, it's just a suggestion for further discussion. I've tested it with my own packages with multiple find_dependency(Boost COMPONENTS ...) calls

Re: [cmake-developers] CMakeFindDependencyMacro limitations

On 24/12/2015 12:07, Stephen Kelly wrote: Roger Leigh wrote: On 21/12/2015 15:07, Stephen Kelly wrote: Roger Leigh wrote: I can understand why REQUIRED and related arguments are omitted--that is why find_dependency exists--but I'd quite like to be able to specify COMPONENTS where needed e.g

Re: [cmake-developers] EXPORT dependency handling

On 20/01/2016 19:05, Brad King wrote: On 01/20/2016 11:57 AM, rle...@codelibre.net wrote: As an aside, I've found some limitations in the usability and utility of EXPORT. These are two of the missing pieces for making the exported configuration functional: 1) is the need to manually call

Re: [cmake-developers] [patch] New find module FindXalanC

On 19/01/2016 19:14, Brad King wrote: On 01/19/2016 12:02 PM, Roger Leigh wrote: +find_package(XercesC 3.0.0 REQUIRED) I think this is an assumption leaking from my own usage of it. I've removed the version here. Thanks. The CMakeOnly.AllFindModules and FindModulesExecuteAll tests fail

[cmake-developers] [patch] New find module FindXalanC

Merged into next from the staging branch "xalanc" for review and testing. Includes a couple of unit tests to validate. Since it depends on XercesC, I hope what I've done here for the imported and non-imported target cases is OK. I've tested on Linux and Windows. Regards, Roger --

Re: [cmake-developers] [patch] New find module FindXalanC

On 19/01/2016 16:50, Brad King wrote: On 01/19/2016 11:39 AM, Roger Leigh wrote: Merged into next from the staging branch "xalanc" for review and testing. Includes a couple of unit tests to validate. Since it depends on XercesC, I hope what I've done here for the imported and no

Re: [cmake-developers] CMakeFindDependencyMacro limitations

On 21/12/2015 15:07, Stephen Kelly wrote: Roger Leigh wrote: I've run into a few limitations in find_dependency. I'm not sure if these are by design or could be fixed, so this is really a request for further explanation or design rationale. The first issue is this: if (NOT ${dep}_FOUND

[cmake-developers] [PATCH] FindBoost: Boost 1.60 support

With the release of Boost 1.60, I've updated FindBoost to work with this version. Pushed to https://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/boost-1.60 and merged into next for review. - Adds 1.60.0 and 1.60 as valid versions - Adds dependency information for 1.60; this is

[cmake-developers] CMakeFindDependencyMacro limitations

I've run into a few limitations in find_dependency. I'm not sure if these are by design or could be fixed, so this is really a request for further explanation or design rationale. The first issue is this: if (NOT ${dep}_FOUND) This seems to be making the assumption that the found variable

Re: [cmake-developers] [PATCH] FindTIFF: Add imported targets

On 02/12/2015 17:31, rle...@codelibre.net wrote: - Add TIFF::TIFF imported target - Document imported target - Add testcase to test the standard variables and the imported target Also: - Add TIFF_INCLUDE_DIRS to match common practice - Update documentation generally, including documenting

Re: [cmake-developers] [PATCH] FindBoost: Add imported targets

On 18/11/2015 11:27, rle...@codelibre.net wrote: On 11/16/2015 09:26 AM, Florent Castelli wrote: But one there’s one thing that comes to mind. Some compiled libraries have dependencies on other compiled libraries. Don’t you think it would make sense to teach FindBoost about those so we link

Re: [cmake-developers] [PATCH] Imported targets for XercesC

Mon Sep 17 00:00:00 2001 From: Roger Leigh <r.le...@dundee.ac.uk> Date: Wed, 18 Nov 2015 16:45:54 + Subject: [PATCH] XercesC: Add imported targets and unit test --- Help/release/dev/FindXercesC-imported-targets.rst | 4 ++ Modules/FindXercesC.cmake

Re: [cmake-developers] [PATCH] FindBoost: Add imported targets

On 17/11/2015 07:53, Ruslan Baratov wrote: On 16-Nov-15 21:01, rle...@codelibre.net wrote: I have attached a patch to add imported targets to FindBoost, in the form of Boost:: (e.g. Boost::date_time) or Boost::Boost as a generic interface library for header-only components. Since it's

Re: [cmake-developers] FindZLIB module should find debug and release variants

On 23/08/2015 10:07, Michael Scott wrote: Carrying on in the list of open issues to look at for contributing to CMake, I've had a look at issue 15280 - FindZLIB module should find debug and release variants. I've made some changes to the FindZLIB module which should make it so that debug and

[cmake-developers] [patch] Support for Boost 1.59

The attached patch adds Boost 1.59.0/1.59 to the list of supported versions in the FindBoost module. Tested on: Ubuntu 14.04 and Windows with VS2013 with Boost 1.59.0. Regards, Roger From 0419a7bd7f1da27bcbf9eaba424fda99cc030867 Mon Sep 17 00:00:00 2001 From: Roger Leigh rle...@codelibre.net

Re: [cmake-developers] [patch] Export template instantiations with GenerateExportHeader

On 30/07/2015 18:34, Brad King wrote: On 07/30/2015 11:23 AM, Roger Leigh wrote: foo_EXPORT_TEMPLATE template class foo_EXPORT std::allocatorchar; [snip] #ifdef @EXPORT_IMPORT_CONDITION@ /* We are building this library */ # define @EXPORT_MACRO_NAME@ @DEFINE_EXPORT

[cmake-developers] [patch] Export template instantiations with GenerateExportHeader

/dlltest (with unpatched cmake--I create the macros after using the generated export header) Regards, Roger From 19b63c2b3f89c44ccfe5f0b7e7ef8aa2ea6377a1 Mon Sep 17 00:00:00 2001 From: Roger Leigh r.le...@dundee.ac.uk Date: Thu, 30 Jul 2015 15:47:38 +0100 Subject: [PATCH] GenerateExportHeader: Add

Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC

On Fri, Dec 05, 2014 at 09:04:19AM -0500, Brad King wrote: On 12/04/2014 05:54 PM, Roger Leigh wrote: No. Either is fine with me; I didn't expect this to be problematic to omit the C suffix, but happy to have it added if it will avoid confusion. I just saw your other mail saying you'd

Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC

if it will avoid confusion. I just saw your other mail saying you'd made a patch. Do you need me to do anything else? Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd

Re: [cmake-developers] [PATCH] New module FindLibDl

of the standard library. It would be equally nice to know if common-but-nonstandard extensions such as dladdr(3) were safe to use. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org

Re: [cmake-developers] [PATCH] New module FindLibDl

On Wed, Nov 19, 2014 at 08:35:53PM +0100, Nils Gladitz wrote: On 19.11.2014 20:23, Roger Leigh wrote: libdl (for dlopen, dlsym) is part of (or an extention to) the standard library/linker on many platforms. It doesn't currently have support in CMake, though there are a few independent

[cmake-developers] [PATCH] FindIntl: Module to find Gettext libintl headers and library

that it's perfectly OK to use libintl without the gettext tools (and vice versa), and they might not all be found. I've added cross references between the two in notes to make the relationship clearer. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org

[cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

/opt/Ice-${ice_version}) line earlier in the script), so the removal simply makes the behaviour consistent. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools

Re: [cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

On Tue, Sep 09, 2014 at 11:48:53AM -0400, Brad King wrote: On 09/09/2014 11:35 AM, Roger Leigh wrote: I have attached a minor fix to the FindIce module added a couple of weeks back. Applied, thanks: FindIce: Remove unneeded search path modification http://cmake.org/gitweb?p=cmake.git

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Fri, Aug 22, 2014 at 11:17:05AM +0100, Roger Leigh wrote: On Thu, Aug 21, 2014 at 02:47:24PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: On Sun, Aug 17, 2014 at 05:22:38PM +0100, Roger Leigh wrote: On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote: Am Sonntag, 17

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Thu, Aug 21, 2014 at 02:47:24PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: On Sun, Aug 17, 2014 at 05:22:38PM +0100, Roger Leigh wrote: On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote: Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh: On Fri, Aug 15

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Sun, Aug 17, 2014 at 05:22:38PM +0100, Roger Leigh wrote: On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote: Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh: On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see

Re: [cmake-developers] [PATCH] New module FindXerces

. - Don't delete the version variable afterwards, it's good have set by the find module as an output variable Xerces_VERSION. - Chuck On Sat, Aug 16, 2014 at 6:48 AM, Roger Leigh rle...@codelibre.net wrote: Hi, Attached is a patch to add support for Apache Xerces-C

Re: [cmake-developers] [PATCH] New module FindXerces

On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would like any further changes making, please just let me know. I

Re: [cmake-developers] [PATCH] New module FindXerces

On Sun, Aug 17, 2014 at 02:28:59PM +0100, Roger Leigh wrote: On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would

Re: [cmake-developers] [PATCH] New module FindXerces

in the version passed to find_package. Ah, OK. I've tidied up the version handling as you suggested, new patch attached. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see what needs doing. In the meantime, I've attached a revised patch with all the above corrections included. Based on the comments made on my other FindXerces patch, I've updated this patch

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote: Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh: On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see what needs doing. In the meantime, I've attached a revised

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Wed, Aug 13, 2014 at 10:10:01AM -0400, Brad King wrote: On 08/12/2014 05:59 PM, Roger Leigh wrote: Regarding the Windows Registry, I've taken a look and it looks like there might be some usable keys from the installer which could be used, but I'll need to do further digging with all

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Mon, Aug 11, 2014 at 11:07:57AM -0400, Brad King wrote: On 08/08/2014 08:56 AM, Roger Leigh wrote: On Thu, Aug 07, 2014 at 06:49:28PM +0100, Roger Leigh wrote: Hi, I've written a module for finding the details of a ZeroC ICE installation, attached, which I thought might

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Tue, Aug 12, 2014 at 09:08:57PM +0100, Roger Leigh wrote: On Mon, Aug 11, 2014 at 11:07:57AM -0400, Brad King wrote: On 08/08/2014 08:56 AM, Roger Leigh wrote: On Thu, Aug 07, 2014 at 06:49:28PM +0100, Roger Leigh wrote: 3. There is a lot of hard-coded version-specific information

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

On Thu, Aug 07, 2014 at 06:49:28PM +0100, Roger Leigh wrote: Hi, I've written a module for finding the details of a ZeroC ICE installation, attached, which I thought might be of interest to a wider audience and be suitable for direct inclusion into cmake. I've attached the patch

[cmake-developers] [PATCH] New module: FindIce.cmake

with the cmake docs build, so it might possibly need some minor tweaking. Kind regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A