Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread Alexander Neundorf
On Monday 05 November 2012, David Cole wrote: I would prefer squish3_add_test and squish4_add_test, as the version number goes with squish, not with the add_test... Keep the old macros and functions with the same name and same meaning please. We've had too many backwards incompatible

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread David Cole
I like squish_v3_add_test the best: keeps the conventional prefix, but still indicates the version it goes with. On Mon, Nov 5, 2012 at 12:23 PM, Alexander Neundorf neund...@kde.org wrote: On Monday 05 November 2012, David Cole wrote: I would prefer squish3_add_test and squish4_add_test, as the

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread Alexander Neundorf
On Monday 05 November 2012, David Cole wrote: I like squish_v3_add_test the best: keeps the conventional prefix, but still indicates the version it goes with. Ok, done. This is in the MakeSquish4Work on the cmake stage. Any objections to merging this into next ? Alex -- Powered by

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread David Cole
No objections here. That's at least going to smoke test the module for us. Has this been *really* tested on Windows? (Can the bug reporter test out the changes as you've made them? Presumably he tested similar changes in his own copy when he attached the patches to the bug.) On Mon, Nov 5, 2012

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread Alexander Neundorf
On Monday 05 November 2012, David Cole wrote: No objections here. That's at least going to smoke test the module for us. Has this been *really* tested on Windows? (Can the bug reporter test out the changes as you've made them? Presumably he tested similar changes in his own copy when he

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-05 Thread David Cole
Great! Thanks for the info. On Mon, Nov 5, 2012 at 2:23 PM, Alexander Neundorf neund...@kde.org wrote: On Monday 05 November 2012, David Cole wrote: No objections here. That's at least going to smoke test the module for us. Has this been *really* tested on Windows? (Can the bug reporter test

[cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-04 Thread Alexander Neundorf
Hi, I finally want to commit my changes to FindSquish.cmake upstream. FindSquish.cmake as it comes with cmake does not work at all with squish version 4.x. The documentation of FindSquish.cmake says it is currently aimed at version 3. This is this bug:

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-04 Thread Alexander Neundorf
On Sunday 04 November 2012, Alexander Neundorf wrote: Hi, I finally want to commit my changes to FindSquish.cmake upstream. FindSquish.cmake as it comes with cmake does not work at all with squish version 4.x. The documentation of FindSquish.cmake says it is currently aimed at version 3.

Re: [cmake-developers] How to fix FindSquish.cmake wrt. backward compatibility ?

2012-11-04 Thread David Cole
I would prefer squish3_add_test and squish4_add_test, as the version number goes with squish, not with the add_test... Keep the old macros and functions with the same name and same meaning please. We've had too many backwards incompatible complaints in 2.8.10 after only a few days out in the