Re: [cmake-developers] Two pull requests

2012-03-01 Thread Brad King
On 2/29/2012 4:58 PM, Yury G. Kudryashov wrote: Brad King wrote: Our style checker limits .h and .cxx files to 79 columns. Some of the updated comments exceed this limit. Please reformat them. Where can I find the style checker sources? I'll run it to pre-commit hook then. The

Re: [cmake-developers] Two pull requests

2012-03-01 Thread Brad King
On 2/29/2012 5:34 PM, Yury G. Kudryashov wrote: Our style checker limits .h and .cxx files to 79 columns. Some of the updated comments exceed this limit. Please Force-pushed. Thanks. It conflicts with the add-const-qualifiers topic in cmPropertyDefinition::IsChained. I merged that into

Re: [cmake-developers] Two pull requests

2012-03-01 Thread Eric Noulard
2012/3/1 Brad King brad.k...@kitware.com: On 3/1/2012 10:47 AM, Eric Noulard wrote: Last time I tried to enable KWStyle hooks following this: http://www.cmake.org/Wiki/Git/Hooks#Setup That page is generic for many of Kitware's projects and is not specific to CMake.  The same hooks are also

Re: [cmake-developers] Two pull requests

2012-02-29 Thread Yury G. Kudryashov
Brad King wrote: On 2/28/2012 4:21 PM, Brad King wrote: On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote: git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git doxygen-fixes Our style checker limits .h and .cxx files to 79 columns. Some of the updated comments exceed this limit. Please

Re: [cmake-developers] Two pull requests

2012-02-29 Thread Yury G. Kudryashov
Brad King wrote: On 2/28/2012 4:21 PM, Brad King wrote: On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote: git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git run-vim-spellcheck Merged, thanks: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=adc2c990 git pull

[cmake-developers] Two pull requests

2012-02-28 Thread Yury G. Kudryashov
Hi! I've published two branches on gitorious. First, I run spellcheck on some source files. git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/fix-typos Next, I fixed some doxygen formatting. git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/apidocs- fixes The last

Re: [cmake-developers] Two pull requests

2012-02-28 Thread Brad King
On 2/28/2012 2:46 PM, Yury G. Kudryashov wrote: I've published two branches on gitorious. Thanks for your work! First, I run spellcheck on some source files. git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/fix-typos Please combine those commits and write a single commit

Re: [cmake-developers] Two pull requests

2012-02-28 Thread Yury G. Kudryashov
Brad King wrote: On 2/28/2012 2:46 PM, Yury G. Kudryashov wrote: git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/fix-typos Please combine those commits and write a single commit message that briefly explains the tools you ran to find the errors. I've also renamed branch.

Re: [cmake-developers] Two pull requests

2012-02-28 Thread Brad King
On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote: git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git run-vim-spellcheck git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git doxygen-fixes Thanks. I'll look at those topics when I get a chance. We accept any form of patch that