Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/17/2016 01:42 PM, Nicolas Desprès wrote: > That's great! The code is way cleaner this way. I have tested it with > my generator and it works fine. Great, thanks for trying it out. We'll see how nightly testing goes tonight but otherwise I think this topic is all set. Thanks for

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Tue, May 17, 2016 at 4:23 PM, Brad King wrote: > On 05/13/2016 07:19 PM, Nicolas Desprès wrote: > > Ok. See the new implementation > > Thanks. I've rebased your topic on 'master' after the style transition > commit and updated the style accordingly. Then I split the

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/13/2016 07:19 PM, Nicolas Desprès wrote: > Ok. See the new implementation Thanks. I've rebased your topic on 'master' after the style transition commit and updated the style accordingly. Then I split the topic up into more commits and simplified the prefix insertion logic a bit. I've

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/13/2016 03:25 PM, Brad King wrote: > so for now please make your logic recognize this case and work around it. Please split this into two commits to move hunks like this: > + this->TargetAll = this->NinjaOutputPath("all"); > + this->CMakeCacheFile =

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/13/2016 12:13 PM, Nicolas Desprès wrote: > with a value that looks like this: > "-Wl,-bundle_loader,/Users/polrop/Documents/cmake/_build > ninja/Tests/ExportImport/Export/testExe2" > > lie on the caller site because the "if (li->IsPath)" in OutputLinkLibraries() > should not be true for

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Thu, May 12, 2016 at 10:07 PM, Brad King wrote: > On 05/12/2016 02:16 PM, Nicolas Desprès wrote: > > All done. Thank you for taking a look. > > https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix > > The RunCMake.NinjaOutputPathPrefix test fails for

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/12/2016 02:16 PM, Nicolas Desprès wrote: > All done. Thank you for taking a look. > https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix The RunCMake.NinjaOutputPathPrefix test fails for me when I have the CMake source and build trees in a directory with a space in the

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Thu, May 12, 2016 at 3:16 PM, Brad King wrote: > On 05/12/2016 06:16 AM, Nicolas Desprès wrote: > > Brad has just sent a notification email about an upcoming feature freeze. > > Do you think we could have this feature merged before? > > I'll take a look. Please rebase

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On 05/12/2016 06:16 AM, Nicolas Desprès wrote: > Brad has just sent a notification email about an upcoming feature freeze. > Do you think we could have this feature merged before? I'll take a look. Please rebase on 'master' to resolve conflicts and also reconcile with the

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

Hi Ben, Brad has just sent a notification email about an upcoming feature freeze. Do you think we could have this feature merged before? Regards, Nicolas On Sun, Mar 20, 2016 at 1:47 PM, Nicolas Desprès wrote: > > > On Wed, Mar 9, 2016 at 9:41 PM, Ben Boeckel

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Wed, Mar 9, 2016 at 9:41 PM, Ben Boeckel wrote: > On Tue, Mar 08, 2016 at 12:36:31 +0100, Nicolas Desprès wrote: > > Did you have a chance to review my patches? > > So I looked at it today, and it looks good overall. A few niggles: > Thanks > > +inline bool

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Tue, Mar 08, 2016 at 12:36:31 +0100, Nicolas Desprès wrote: > Did you have a chance to review my patches? So I looked at it today, and it looks good overall. A few niggles: +inline bool cmEndsWith(const std::string& str, const std::string& what) +{ + assert(str.size() >= what.size());

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Tue, Mar 08, 2016 at 12:36:31 +0100, Nicolas Desprès wrote: > Did you have a chance to review my patches? Sorry, not yet. I hope to have a peek at it today or tomorrow. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

Ben, Did you have a chance to review my patches? Cheers, Nicolas On Sunday, February 14, 2016, Nicolas Desprès wrote: > Ben, > > I have pushed a complete version of the patch here: > https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix > > Since

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

Ben, I have pushed a complete version of the patch here: https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix Since the last push, I have addressed the comments you made in your previous review (i.e. move some code to cmAlgorithm.h) and added a RunCMake.NinjaOutputPathPrefix

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Fri, Jan 22, 2016 at 17:34:03 +0100, Nicolas Desprès wrote: > I have pushed a first draft of the patch here: > > https://github.com/nicolasdespres/CMake/commit/67a4faad47378c07c97a29dd229d6f9fa500763b > > I have tested with a small project and it looks good. Looks like a good start to me as

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

Ben, I have pushed a first draft of the patch here: https://github.com/nicolasdespres/CMake/commit/67a4faad47378c07c97a29dd229d6f9fa500763b I have tested with a small project and it looks good. I would like to add some regression tests but I don't know from where to start. The principle would

[cmake-developers] Using CMake generated ninja file as a subninja file

Hello, I would like to be able to use a build.ninja file generated by CMake as a subninja file of a super build.ninja file generated by a custom generator. This way I could include a CMake projects in a bigger one. Currently, I call ninja recursively to build the CMake sub-project. But this

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Wed, Jan 6, 2016 at 6:25 PM, Ben Boeckel wrote: > On Wed, Jan 06, 2016 at 11:14:32 +0100, Nicolas Desprès wrote: > > To enable this type of generation, the "top/" directory must be passed to > > CMake somehow. An environment variable or a CMake variable called > >

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Wed, Jan 06, 2016 at 19:26:11 +0100, Nicolas Desprès wrote: > Is that variable already available or a name suggestion? I cannot find any > reference to it neither in the source nor in the documentation. It's a suggestion. > This is acceptable for me since I have a custom generator that would

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Wed, Jan 6, 2016 at 7:35 PM, Ben Boeckel wrote: > On Wed, Jan 06, 2016 at 19:26:11 +0100, Nicolas Desprès wrote: > > Is that variable already available or a name suggestion? I cannot find > any > > reference to it neither in the source nor in the documentation. > >

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

On Wed, Jan 06, 2016 at 11:14:32 +0100, Nicolas Desprès wrote: > To enable this type of generation, the "top/" directory must be passed to > CMake somehow. An environment variable or a CMake variable called > CMAKE_NINJA_TOP_BUILD_DIR would do the trick. I think CMAKE_NINJA_OUTPUT_PATH_PREFIX