On 02/25/2014 04:17 PM, Matthäus G. Chajdas wrote:
thanks for splitting the patches the review. I've just pushed the
requested changes to the add-FindOpenCL topic.
Thanks. I made some minor tweaks and merged to 'next' for testing:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=041485bc
Hi Matthäus,
On 02/23/2014 03:34 AM, Rolf Eike Beer wrote:
Looks better.
Thanks for your work on these. I've split your branch into
separate topics for FindHg and FindOpenCL. The FindHg changes
are now in master:
FindHg: Search for TortoiseHg
Hi Brad,
thanks for splitting the patches the review. I've just pushed the
requested changes to the add-FindOpenCL topic.
If there is still something missing, please drop me a line; I appreciate
your patience with a new contributor!
Cheers,
Matthäus
On 25.02.2014 17:36, Brad King wrote:
Hi
Hi,
So, I'm very sorry to come up with those things now and not having catched
them earlier. If you now do
no problem, I should have also checked what I was adding with git :/
I think I fixed everything now in my latest commit. At least `git diff
origin/master Modules/FindHg.cmake` looks
Am Sonntag, 23. Februar 2014, 09:13:18 schrieb Matthäus G. Chajdas:
Hi,
So, I'm very sorry to come up with those things now and not having catched
them earlier. If you now do
no problem, I should have also checked what I was adding with git :/
I think I fixed everything now in my
Am Samstag, 8. Februar 2014, 14:28:37 schrieb Matthäus G. Chajdas:
Hi,
I would like to propose two new modules for inclusion in CMake:
FindOpenCL to find OpenCL and FindHg for Mercurial (see attached.)
FindOpenCL is written in similar spirit to FindOpenGL, while FindHg is
basically the
Hi,
I'm following that guide -- I have a Mantis CDash account, and I'm at
step 4 which is wait for acceptance. Most projects I know have some
policy like ping the maintainer after two weeks or ask the code owner
or similar if a patch is in limbo. I have no problem waiting longer, but
it would be
On 02/19/2014 02:40 PM, Matthäus G. Chajdas wrote:
I'm following that guide -- I have a Mantis CDash account, and I'm at
step 4 which is wait for acceptance
The fact that I've asked you to do this *is* the acceptance, as in
acceptance of your offer to add and maintain these modules.
Thanks,
Hi,
at least the documentation here:
http://www.cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#find-modules
says so, unless there is another one I should be referring to. I've
changed it to _VERSION.
As I said in the last mail, how do we continue from here on? Are the
modules
Hi Eike,
thanks for reviewing! I've just pushed a new version, which should fix
all the issues you mentioned. I'm also setting now Hg_FOUND using
FOUND_VAR (this is also recommended in the documentation.)
Anything more left to do? The only thing which bothers me is the
_VERSION_STRING in FindHg
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for reviewing! I've just pushed a new version, which should fix
all the issues you mentioned. I'm also setting now Hg_FOUND using
FOUND_VAR (this is also recommended in the documentation.)
Anything more
Hi,
couldn't find it in the documentation either :(
I've changed it to OPENCL_VERSION_STRING. Should I apply for commit
access now?
Cheers,
Matthäus
On 16.02.2014 20:10, Rolf Eike Beer wrote:
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for
Am Sonntag, 16. Februar 2014, 20:26:22 schrieb Matthäus G. Chajdas:
Hi,
couldn't find it in the documentation either :(
Help/manual/cmake-developer.7.rst
I've changed it to OPENCL_VERSION_STRING.
Should be OpenCL_VERSION_STRING: the variables should follow the casing of the
module name.
Hi Eike,
thanks again! I've just read the Wiki regarding commit access, and it
says I should wait for acceptance on the mailing list before applying
for access. This is the first time ever I try to contribute something to
CMake, so please bear with me if I'm missing something here. Should I
ping
Rolf Eike Beer wrote:
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for reviewing! I've just pushed a new version, which should fix
all the issues you mentioned. I'm also setting now Hg_FOUND using
FOUND_VAR (this is also recommended in the
Rolf Eike Beer wrote:
Matthäus G. Chajdas wrote:
Hi Eike,
all right, then Hg, as it's FindHg, unless there is a naming policy I'm
not aware of. I was just confused a bit due to FindGit, which uses GIT_
as the prefix.
How do I proceed from here? What should I do next?
I think you can
Am Samstag, 15. Februar 2014, 18:54:47 schrieb Stephen Kelly:
Rolf Eike Beer wrote:
Matthäus G. Chajdas wrote:
Hi Eike,
all right, then Hg, as it's FindHg, unless there is a naming policy I'm
not aware of. I was just confused a bit due to FindGit, which uses GIT_
as the prefix.
Hi Eike,
all right, then Hg, as it's FindHg, unless there is a naming policy I'm
not aware of. I was just confused a bit due to FindGit, which uses GIT_
as the prefix.
How do I proceed from here? What should I do next?
Cheers,
Matthäus
On 08.02.2014 17:38, Rolf Eike Beer wrote:
Am Samstag,
Am Samstag, 8. Februar 2014, 14:28:37 schrieb Matthäus G. Chajdas:
Hi,
I would like to propose two new modules for inclusion in CMake:
FindOpenCL to find OpenCL and FindHg for Mercurial (see attached.)
FindOpenCL is written in similar spirit to FindOpenGL, while FindHg is
basically the
Hi Eike,
thanks for taking a look. I've changed the module accordingly. Is there
a recommendation whether to use HG_ or Hg_ as the prefix for the variables?
As I guess there will be a bit back forth here, I've also pushed them
to a repository on github: https://github.com/Anteru/findhgcl
Am Samstag, 8. Februar 2014, 16:38:02 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for taking a look. I've changed the module accordingly. Is there
a recommendation whether to use HG_ or Hg_ as the prefix for the variables?
As I guess there will be a bit back forth here, I've also pushed
21 matches
Mail list logo
