[cmake-developers] Bad error message when a package could not be found - make find_package() not search config files by default

2012-02-16 Thread Alexander Neundorf
Hi, when I use a Find-module to search for a package, I get a nice error message if the package could not be found. If I use find_package(Foo) and rely on Config-mode, cmake produces an error message which doesn't help the user: ~/src/extra-cmake-modules/example/b$ make rebuild_cache Running

Re: [cmake-developers] Support for imported targets in CMAKE_REQUIRED_LIBRARIES

2012-02-16 Thread Brad King
On 2/16/2012 6:32 AM, Alexander Neundorf wrote: Done, and pushed to stage. I added the prefix cmake_ to the function, and added a test for it. Looks good, thanks. However now that I look at the end result I realize that the functionality is not specific to CMAKE_REQUIRED_LIBRARIES at all. It

Re: [cmake-developers] Support for imported targets in CMAKE_REQUIRED_LIBRARIES

2012-02-16 Thread Alexander Neundorf
On Thursday 16 February 2012, Brad King wrote: On 2/16/2012 6:32 AM, Alexander Neundorf wrote: Done, and pushed to stage. I added the prefix cmake_ to the function, and added a test for it. Looks good, thanks. However now that I look at the end result I realize that the functionality

Re: [cmake-developers] Bad error message when a package could not be found - make find_package() not search config files by default

2012-02-16 Thread Brad King
On 2/16/2012 8:19 AM, Alexander Neundorf wrote: Comments, objections ? The entire point of find_package's interface is that the caller does not need to care how the package is found, and the actual method used for the find can change under the hood. Ideally every package would provide a

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Brad King
On 2/16/2012 10:15 AM, Alexander Neundorf wrote: On Thursday 16 February 2012, Brad King wrote: In hindsight that name was poorly chosen. I'd really like to see package in the name because they are package configuration files. Otherwise there is no indication it has anything to do with

Re: [cmake-developers] Bad error message when a package could not be found - make find_package() not search config files by default

2012-02-16 Thread Alexander Neundorf
On Thursday 16 February 2012, Brad King wrote: On 2/16/2012 8:19 AM, Alexander Neundorf wrote: Comments, objections ? The entire point of find_package's interface is that the caller does not need to care how the package is found, and the actual method used for the find can change under the

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Alexander Neundorf
On Thursday 16 February 2012, Brad King wrote: On 2/16/2012 10:15 AM, Alexander Neundorf wrote: On Thursday 16 February 2012, Brad King wrote: In hindsight that name was poorly chosen. I'd really like to see package in the name because they are package configuration files. Otherwise

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Brad King
On 2/16/2012 10:48 AM, Alexander Neundorf wrote: 5) configure_package_config_file() + write_basic_package_version_file() So, 5) ? Looks good. Thanks. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please

Re: [cmake-developers] Bad error message when a package could not be found - make find_package() not search config files by default

2012-02-16 Thread Brad King
On 2/16/2012 10:30 AM, Alexander Neundorf wrote: In any of the above modes the error message can be more explicit. It is up to the author of the project to choose to do this. I do not want it to be required. Here we disagree. I think it should be required, to avoid the impression finding

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread David Cole
On Thu, Feb 16, 2012 at 10:52 AM, Brad King brad.k...@kitware.com wrote: On 2/16/2012 10:48 AM, Alexander Neundorf wrote: 5) configure_package_config_file(**) + write_basic_package_version_** file() So, 5) ? Looks good. Thanks. -Brad -- Powered by www.kitware.com Visit other

[cmake-developers] FYI: Cross compiling ideas...

2012-02-16 Thread Alexander Neundorf
Hi, just FYI some input on what people would like to have when cross compiling. Like uploading executables to the target in try_run(), installing to a target using something like scp, etc. Alex -- Forwarded Message -- Date: Thursday 16 February 2012, 14:32:21 From: Thomas

Re: [cmake-developers] target_include_directories branch in stage

2012-02-16 Thread David Cole
Pushed down the queue again... I'll get to it soon. There are a handful of minor changes that I still need to make first. On Thu, Feb 16, 2012 at 8:20 AM, Stephen Kelly steve...@gmail.com wrote: David Cole wrote: Excellent : thanks very much for trying it out. I'll try to get this first

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Brad King
On 2/16/2012 1:24 PM, Alexander Neundorf wrote: Actually I expected I would prefer this over the fixed names, but now that I've done it and look at what Config.cmake.in file I have to write, I think I liked the previous version with the fixed names (CONFIG_HELPER) better. I think it was easier

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread Peter Kümmel
On 16.02.2012 04:51, Bill Hoffman wrote: On 2/15/2012 5:52 PM, Peter Kümmel wrote: In summary: - use the CMakeLists.txt from https://github.com/syntheticpp/ninja/tree/cmake - on Windows use ninja from https://github.com/syntheticpp/ninja/tree/token-splitter and wait and see

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Brad King
On 2/16/2012 3:29 PM, Eric Noulard wrote: What are you targeting? install-time i.e. make install usage? package install time prodduced with cpack usage? package install time NOT produced with cpack usage? a subset of this? The goal is a FooConfig.cmake file for make install time but that

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread Bill Hoffman
On 2/16/2012 2:57 PM, Peter Kümmel wrote: They are not interested. There is another patch in the pipeline but with this the current generator doesn't work. Use the official ninja and drop Win atm. Bummer. I am most interested in windows. Would love to stop using gmake... Seems like they

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Eric Noulard
2012/2/16 Brad King brad.k...@kitware.com: On 2/16/2012 3:29 PM, Eric Noulard wrote: What are you targeting? install-time i.e. make install usage? package install time prodduced with cpack usage? package install time NOT produced with cpack usage? a subset of this? The goal is a

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread David Cole
On Thu, Feb 16, 2012 at 3:52 PM, Eric Noulard eric.noul...@gmail.comwrote: 2012/2/16 Brad King brad.k...@kitware.com: On 2/16/2012 3:29 PM, Eric Noulard wrote: What are you targeting? install-time i.e. make install usage? package install time prodduced with cpack usage? package

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Brad King
On 2/16/2012 4:13 PM, David Cole wrote: On Thu, Feb 16, 2012 at 3:52 PM, Eric Noulard eric.noul...@gmail.com mailto:eric.noul...@gmail.com wrote: I'm not convinced, yet I'll have to try with the example provided by Alex by adding proper CPack usage in it. Currently I see in

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread Peter Kümmel
On 16.02.2012 21:38, Bill Hoffman wrote: On 2/16/2012 2:57 PM, Peter Kümmel wrote: They are not interested. There is another patch in the pipeline but with this the current generator doesn't work. Use the official ninja and drop Win atm. Bummer. I am most interested in windows. Would love

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread Richard Wackerbarth
What are we trying to accomplish here? I have set up 3 of my machines (1 each MacOSX, FreeBSD, and Linux --- like my housekeeper, I don't do Windows) to submit nightly builds using the Ninja generator. That will test the impact of changes in the generator. But it appears that we may also need

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread David Cole
On Thu, Feb 16, 2012 at 5:08 PM, Richard Wackerbarth rich...@nfsnet.orgwrote: What are we trying to accomplish here? 2 things: (1) Keep the CMake ninja generator working with the changing state of the CMake code base (primary) (2) Understanding what version of ninja works good on all the

Re: [cmake-developers] ninja broken on windows?

2012-02-16 Thread Bill Hoffman
On 2/16/2012 5:19 PM, David Cole wrote: On Thu, Feb 16, 2012 at 5:08 PM, Richard Wackerbarth rich...@nfsnet.org mailto:rich...@nfsnet.org wrote: What are we trying to accomplish here? 2 things: (1) Keep the CMake ninja generator working with the changing state of the CMake code base

[cmake-developers] Modifying RPATH feature to run tests uninstalled

2012-02-16 Thread Stephen Kelly
Hi there, One of the macros we have in KDE creates shell scripts to initialize environment variables needed on various platforms so that tests can be run before installation. If RPATH is enabled, the scripts are not needed, but RPATH is sometimes disabled, so the scripts are the solution to

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Alexander Neundorf
On Thursday 16 February 2012, Brad King wrote: On 2/16/2012 1:24 PM, Alexander Neundorf wrote: Actually I expected I would prefer this over the fixed names, but now that I've done it and look at what Config.cmake.in file I have to write, I think I liked the previous version with the fixed

[cmake-developers] Making GUI applications by default

2012-02-16 Thread Stephen Kelly
Hi there, Also in this thread one of the discussion topics was making CMake default to creating Gui-ready executables. That is, setting the WIN32_EXECUTABLE or MACOSX_BUNDLE property on the executable target. http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/6961/focus=7005 By

Re: [cmake-developers] Making Config.cmake files easier to write

2012-02-16 Thread Eric Noulard
2012/2/16 Brad King brad.k...@kitware.com: On 2/16/2012 4:13 PM, David Cole wrote: On Thu, Feb 16, 2012 at 3:52 PM, Eric Noulard eric.noul...@gmail.com mailto:eric.noul...@gmail.com wrote:    I'm not convinced, yet I'll have to try with the example provided by Alex    by adding proper CPack