Stephen Kelly wrote:
7) I've only implemented the support for this target type in the
Makefile generator so far. I can also do the Ninja one after all of the
details about how it works are sorted out.
Can someone else implement the VS and Xcode support? I'm too unfamiliar
with those
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14399
==
Reported By:Xuefer
Assigned To:
On 10/09/13 18:13, David Cole wrote:
Comments:
(1) Obviously, remove the FIXME and actually add the documentation
before merging this into CMake 'next'...
Of course :)
I was waiting to define the exact new behaviour before writing the
documentation
(2) This won't work:
+string(REGEX
On 10/09/13 20:05, Brad King wrote:
I think it should be explicitly enabled or disabled by an option:
GIT_WORK_TREE_PRESERVE 0|1
What about EP_WORK_TREE_PRESERVE? Even though the patch is for git only
at the moment, I think this should be supported also for the other
repositories (perhaps
On 09/11/2013 06:00 AM, Daniele E. Domenichelli wrote:
On 10/09/13 20:05, Brad King wrote:
I think it should be explicitly enabled or disabled by an option:
GIT_WORK_TREE_PRESERVE 0|1
What about EP_WORK_TREE_PRESERVE? Even though the patch is for git only
at the moment, I think this
The EP_ prefix is not needed because this is already an option of
the ExternalProject_Add function. How about SOURCE_DIR_PRESERVE?
To me, the name SOURCE_DIR_PRESERVE implies that the source dir, if it
exists, will not be touched by the download command or the update
command at all.
If it
On 11/09/13 14:34, Brad King wrote:
On 09/11/2013 06:00 AM, Daniele E. Domenichelli wrote:
On 10/09/13 20:05, Brad King wrote:
I think it should be explicitly enabled or disabled by an option:
GIT_WORK_TREE_PRESERVE 0|1
What about EP_WORK_TREE_PRESERVE? Even though the patch is for git
On 9/11/2013 10:35 AM, David Cole wrote:
My main point being: if you're actively developing code in these source
trees, then they're not really External, are they?
If you want to take advantage of ExternalProject, then you have to make
all your projects external even the main one you are
Steve,
On 09/11/2013 11:10 AM, David Cole wrote:
Configure policy warnings with CMake 2.8.12-rc3 in a Qt-enabled VTK
'master' dashboard:
http://open.cdash.org/viewConfigure.php?buildid=3025085
The warning reads
CMake Warning (dev) in GUISupport/Qt/CMakeLists.txt:
Policy CMP0022 is
On 09/11/2013 11:10 AM, David Cole wrote:
Build warnings about unrecognized option '/link'; ignored on ITK, VTK
Please post a sample link line that generates this warning.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
Configure policy warnings with CMake 2.8.12-rc3 in a Qt-enabled VTK
'master' dashboard:
http://open.cdash.org/viewConfigure.php?buildid=3025085
Build warnings about unrecognized option '/link'; ignored on ITK, VTK
and VTKWikiExamples dashboards (with 2.8.12-rc3 driving, ninja
generator,
C:\dev\My Tests\Nightly\VTK Win32-ninja-Debugninja -v
vtkChartsCoreCxxTests
[1/1] cmd.exe /c cd . C:\Program Files\CMake 2.8\bin\cmake.exe -E
vs_link_exe C:\PROGRA~1\MICRO
S~1.0\VC\bin\link.exe /nologo @CMakeFiles/vtkChartsCoreCxxTests.rsp
/out:bin\vtkChartsCoreCxxTests.
exe
On 09/11/2013 11:10 AM, David Cole wrote:
Configure policy warnings with CMake 2.8.12-rc3 in a Qt-enabled VTK
'master' dashboard:
http://open.cdash.org/viewConfigure.php?buildid=3025085
Here is a fix for the CMP0022 warnings:
http://review.source.kitware.com/#/t/3233/
-Brad
--
On 09/11/2013 12:05 PM, David Cole wrote:
C:\PROGRA~1\MICROS~1.0\VC\bin\link.exe /nologo
@CMakeFiles/vtkChartsCoreCxxTests.rsp
[snip]
It must be in the CMakeFiles/vtkChartsCoreCxxTests.rsp file, but that
file's gone after the command executes.
I think ninja writes that file out
On 09/11/2013 12:32 PM, Brad King wrote:
I think ninja writes that file out temporarily. Therefore the
ninja build files must have the /link option in them somewhere.
Okay, I found the problem. There was a Ninja-specific change made
here to do linking with response files:
On 10/09/13 19:54, David Cole wrote:
set(dir .)
file(GLOB r1 ${dir}/*)
list(LENGTH r1 n1)
message(n1='${n1}')
file(GLOB r2 ${dir}/*.*)
list(LENGTH r2 n2)
message(n2='${n2}')
convinces me that n1 and n2 should both be 0 in an empty directory, and
non-0 in
On 08/06/2013 05:39 AM, Daniele E. Domenichelli wrote:
I added a commit introducing a couple of unit tests that should run only
if GTK and/or GTKMM are available on the system.
Do these tests share a build tree? GTK2Targets.gtk and GTK2Components.gtk
failed randomly last night:
Peter,
On 09/11/2013 12:40 PM, Brad King wrote:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e31df039
That commit added special handling for /link with executables
Why is *_COMPILER_LINKER_OPTION_FLAG_* needed here:
Yes, that patch (removing the one line in Windows-MSVC.cmake)
eliminates the warning.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
On 09/11/2013 02:33 PM, David Cole wrote:
Yes, that patch (removing the one line in Windows-MSVC.cmake)
eliminates the warning.
Okay, thanks. Applied:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3cd753df
I've started a branch off this thread on cmake-developers
to inquire about
On 09/11/2013 10:39 AM, Daniele E. Domenichelli wrote:
Ah ok, sorry I thought this was supposed to be a global variable, not a
parameter of ExternalProject_Add...
So, how about a SOURCE_DIR_PRESERVE parameter of ExternalProject_Add
that defaults to the value of EP_SOURCE_DIR_PRESERVE if
Brad King wrote:
Can you please teach it to print out the value of each of the two
properties so we have some hint about what is different?
I pushed print-CMP0022-content-conflict and merged it to next.
Thanks,
Steve.
--
Powered by www.kitware.com
Visit other Kitware open-source
22 matches
Mail list logo
