[cmake-developers] [CMake 0014622]: Typo in helpstrings for CMAKE_(C|CXX|Fortran)_STANDARD_LIBRARIES_INIT

2013-12-03 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14622 == Reported By:Stephan Tolksdorf Assigned To:

Re: [cmake-developers] Topic filter-showincludes-in-launcher - How to access cmake variables from ctest?

2013-12-03 Thread Brad King
On 12/02/2013 02:32 AM, Nils Gladitz wrote: topic filter-showincludes-in-launcher-mk2 which works around the issue by passing parameters to the launcher command line instead. I think that is a cleaner approach anyway. I've tested it locally and merged it to next. I revised your commit

Re: [cmake-developers] Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-03 Thread Brad King
On 12/03/2013 09:42 AM, Brad King wrote: Until this is resolved I've reverted the part of the CMakeParseArguments_EmptyArgs topic that was merged to 'next'. After this is worked out please rebase everything on master and squash the topic down to avoid the break- fix-compatiblity sequence.

Re: [cmake-developers] Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-03 Thread Daniele E. Domenichelli
On 02/12/13 22:57, Brad King wrote: The function() and macro() commands rename any existing command of the same name to one with a leading underscore. This was added long ago for use as local debugging and never really finished. It is not documented behavior. Thanks! This actually explains

Re: [cmake-developers] Topic filter-showincludes-in-launcher - How to access cmake variables from ctest?

2013-12-03 Thread Nils Gladitz
On 12/03/2013 03:30 PM, Brad King wrote: I revised your commit message: CTest: filter /showIncludes output from ninja compile launcher http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e5e3f3d4 but otherwise the commit is identical to yours. Can you confirm that this achieves what you

Re: [cmake-developers] Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-03 Thread Stephen Kelly
Brad King wrote: Also, Steve added a Module.CMakeParseArguments test to the topic. Wouldn't that make more sense as a RunCMake test? Perhaps. I only added that to show how to reproduce the failure minimally. I'll leave it up to Daniele what to do with it. Thanks, Steve. -- Powered by

Re: [cmake-developers] Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-03 Thread Daniele E. Domenichelli
On 03/12/13 15:43, Brad King wrote: On 12/03/2013 09:42 AM, Brad King wrote: After this is worked out please rebase everything on master and squash the topic down to avoid the break- fix-compatiblity sequence. Also, Steve added a Module.CMakeParseArguments test to the topic. Wouldn't that

Re: [cmake-developers] Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-03 Thread Daniele E. Domenichelli
On 03/12/13 15:53, Brad King wrote: Thanks. Please squash it so that the topic looks like you got this all right the first time. Also convert Steve's test case to a RunCMake test and perhaps add some error case checking if needed too. Done, I'm not sure if you want to squash even more...

Re: [cmake-developers] CMakeParseArguments: Do not skip empty arguments

2013-12-03 Thread Brad King
On 11/27/2013 10:40 AM, Brad King wrote: Go ahead and merge it to 'next' for testing. I will review it there Looking at the topic as of commit 10fd6fba, here are some comments. Why does CMAKE_PARSE_ARGUMENTS_DEFAULT_SKIP_EMPTY need to be an inherited directory property instead of a variable?

[cmake-developers] [CMake 0014626]: FindFreetype module needs a new maintainer and an overhaul

2013-12-03 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14626 == Reported By:Brad King Assigned To:

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-12-03 Thread Ben Boeckel
On Mon, Nov 18, 2013 at 12:19:55 +0100, Daniele E. Domenichelli wrote: If there are local changes, git stash is used to save the changes and restore them after the pull. If any of these operation fails, it tries to restore the original status and exits with a fatal error, asking the user to

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-12-03 Thread Daniele E. Domenichelli
On 03/12/13 21:34, Ben Boeckel wrote: On Mon, Nov 18, 2013 at 12:19:55 +0100, Daniele E. Domenichelli wrote: If there are local changes, git stash is used to save the changes and restore them after the pull. If any of these operation fails, it tries to restore the original status and exits

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-12-03 Thread Ben Boeckel
On Tue, Dec 03, 2013 at 23:09:38 +0100, Daniele E. Domenichelli wrote: git stash save automatically saves the index, that is restored using git stash pop --index. The --keep-index does not save the index but instead keeps it in the working tree. This means that after stashing you will still