[cmake-developers] [CMake 0014684]: Missing -rpath-link with static library in mix
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=14684 == Reported By:Clinton Stimpson Assigned To: == Project:CMake Issue ID: 14684 Category: CMake Reproducibility:have not tried Severity: minor Priority: normal Status: new == Date Submitted: 2014-01-06 08:34 EST Last Modified: 2014-01-06 08:34 EST == Summary:Missing -rpath-link with static library in mix Description: Using attached project, I get a link error: /usr/bin/ld: warning: libshareda.so, needed by .../build/subdir/libsharedb.so, not found (try using -rpath or -rpath-link) .../build/subdir/libsharedb.so: undefined reference to `shareda()' Somehow a needed -rpath-link is dropped instead of pushed through the usage of a static library. This was found when some newer Linux distributions have the --as-needed linker flag on by default. I added the --no-undefined linker flag to help show that the bug isn't in the code. == Issue History Date ModifiedUsername FieldChange == 2014-01-06 08:34 Clinton StimpsonNew Issue 2014-01-06 08:34 Clinton StimpsonFile Added: test-rpath-link.tar.gz == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request to review topic codelite-ide-generator
The cmake repositories should be back online and behaving normally. On Sun, Jan 5, 2014 at 3:07 PM, Eran Ifrah eran.if...@gmail.com wrote: Thanks, I will try again tomorrow On Sun, Jan 5, 2014 at 9:34 PM, Nils Gladitz nilsglad...@gmail.comwrote: On 05.01.2014 19:26, Eran Ifrah wrote: Hmm, it looks like there is a general problem with the website, as I am getting blank pages on various links, e.g. http://www.cmake.org/Wiki/CMake/Git/Develop So I will try again later Eran There is a maintenance notice on cmake.org and the git repository seems to be in flux. After pulling I got a state from 2 months ago ~_~ Nils -- Eran Ifrah Author of codelite, a cross platform open source C/C++ IDE: http://www.codelite.org wxCrafter, a wxWidgets RAD: http://wxcrafter.codelite.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request review of new topic gcc-binutil-wrappers
On 01/04/2014 12:09 PM, Nils Gladitz wrote:
GCC (I think since about 4.7) provides wrappers for ar, nm and ranlib
with a gcc- name prefix (e.g. gcc-ar-4.7).
I created a topic to pick these up for CMAKE_AR, CMAKE_RANLIB and
CMAKE_NM per default if used with GCC.
These wrappers pass the --plugin option to the actual tools which is
required for link time optimization (LTO).
I haven't merged it to next yet since I am not sure if this might
break anything in existing setups.
Please wait until after Clinton's unicode topics have settled so
that you can get more isolated feedback from the dashboard.
Does anyone else have any insight or suggestions?
This hunk looks strange:
+set(COMPILER ${CMAKE_CXX_COMPILER}${CMAKE_C_COMPILER})
+get_filename_component(COMPILER_DIR ${COMPILER} DIRECTORY)
I don't think both compilers should be used at the same time :)
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] optional-install topic
Nils, The topic adds the variable CMAKE_DISABLE_INSTALL_RULES. For skipping certain generation features we already have the convention CMAKE_SKIP_... for variable names. Perhaps CMAKE_SKIP_INSTALL_RULES? Please add a RunCMake.install test with a case covering the warning: +mf-IssueMessage(cmake::WARNING, + CMAKE_DISABLE_INSTALL_RULES was enabled even though + installation rules have been specified); Also please look at adding a full test that verifies that no cmake_install.cmake file is generated and if possible that cmake --build . --target install fails. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request review of new topic gcc-binutil-wrappers
On 01/06/2014 04:44 PM, Brad King wrote:
Please wait until after Clinton's unicode topics have settled so that
you can get more isolated feedback from the dashboard.
Will do.
This hunk looks strange:
+set(COMPILER ${CMAKE_CXX_COMPILER}${CMAKE_C_COMPILER})
+get_filename_component(COMPILER_DIR ${COMPILER} DIRECTORY)
I don't think both compilers should be used at the same time :)
Yeah, I assumed only one is set at a time but I'll have to check that.
CMakeFindBinUtils is included by CMakeDetermineLANGCompiler.cmake.
Perhaps they could pass their language into CMakeFindBinUtils so this
and similar constructs that check variables for both languages can be
removed.
Thanks!
Nils
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] optional-install topic
On 01/06/2014 04:48 PM, Brad King wrote: The topic adds the variable CMAKE_DISABLE_INSTALL_RULES. For skipping certain generation features we already have the convention CMAKE_SKIP_... for variable names. Perhaps CMAKE_SKIP_INSTALL_RULES? Please add a RunCMake.install test with a case covering the warning: +mf-IssueMessage(cmake::WARNING, + CMAKE_DISABLE_INSTALL_RULES was enabled even though + installation rules have been specified); Also please look at adding a full test that verifies that no cmake_install.cmake file is generated and if possible that cmake --build . --target install fails. Will be done. Thanks! Nils -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request to review topic codelite-ide-generator
On Sun, Jan 5, 2014 at 7:47 PM, Alexander Neundorf neund...@kde.org wrote: On Saturday 04 January 2014, Eran Ifrah wrote: Hi, I have added support for CodeLite IDE (topic name: codeite-ide-generator) If any of the developers can review it - it will be great P.S: This topic is related to this Mantis bug feature request: http://public.kitware.com/Bug/view.php?id=9901 I had a look last week and it looked good in general, and also seemed to work. :-) Did you get around to add a test using codelite-make (or what the name was ) ? No (and this is the correct name) Did you check whether everything works correctly if the source dir or the build dir contain spaces ? e.g. $HOME/cmake/src dir/ and $HOME/cmake/build dir/ ? I tried both cases and its working properly. Note that the first case is irrelevant since, codelite's project and workspace files do not include absolute paths (and the generator also convert them to relative before the project files are generated) Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Eran Ifrah Author of codelite, a cross platform open source C/C++ IDE: http://www.codelite.org wxCrafter, a wxWidgets RAD: http://wxcrafter.codelite.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request to review topic codelite-ide-generator
Hi Nils, the changes you suggested are now pushed (git is back online and working) Eran On Sat, Jan 4, 2014 at 8:31 PM, Nils Gladitz nilsglad...@gmail.com wrote: Hello again :) I'd remove -j from the ninja invocation since ninja itself already uses its own default value based on CPU count. I'd also remove or replace Additionally a hierarchy of makefiles is generated [...] in the documentation. When using ninja the input files are only generated in the root build directory. Nils On 04.01.2014 18:48, Eran Ifrah wrote: Hi, I have added support for CodeLite IDE (topic name: codeite-ide-generator) If any of the developers can review it - it will be great P.S: This topic is related to this Mantis bug feature request: http://public.kitware.com/Bug/view.php?id=9901 Thanks! -- Eran Ifrah Author of codelite, a cross platform open source C/C++ IDE: http://www.codelite.org wxCrafter, a wxWidgets RAD: http://wxcrafter.codelite.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe:http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Eran Ifrah Author of codelite, a cross platform open source C/C++ IDE: http://www.codelite.org wxCrafter, a wxWidgets RAD: http://wxcrafter.codelite.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] RFC: add version to project() call
Hi, on cmake stage I have a simple branch AddVersionToProjectCommand. This extends the project command to also accept a version number: project(Foo VERSION 1.2.3 CXX) All that does is setting some more variables (beside PROJECT_NAME, PROJECT_SOURCE_DIR, PROJECT_BINARY_DIR and the projectName_... equivalents). When setting a version, you also get PROJECT_VERSION and PROJECT_VERSION_(MAJOR|MINOR|PATCH|TWEAK) variables as well as the projectName_... equivalents. These version variables can then be used in other commands/macros/functions which need a version. I modified write_basic_package_version_file() accordingly, so that you can now simply do project(Foo VERSION 1.2.3) ... write_basic_package_version_file(FooConfigVersion.cmake COMPATIBILITY AnyNewerVersion) and this will use the version number from the project() call automatically (if no VERSION has been given explicitely). Comments ? Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] RFC: add version to project() call
Am Montag, 6. Januar 2014, 22:41:26 schrieb Alexander Neundorf: Hi, on cmake stage I have a simple branch AddVersionToProjectCommand. This extends the project command to also accept a version number: project(Foo VERSION 1.2.3 CXX) Cool, I like this. Shouldn't there be spaces on both sides of operators (e.g. '= 2')? Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] RFC: add version to project() call
On Monday 06 January 2014, Rolf Eike Beer wrote:
Am Montag, 6. Januar 2014, 22:41:26 schrieb Alexander Neundorf:
Hi,
on cmake stage I have a simple branch AddVersionToProjectCommand.
This extends the project command to also accept a version number:
project(Foo VERSION 1.2.3 CXX)
Cool, I like this. Shouldn't there be spaces on both sides of operators
(e.g. '= 2')?
?
This basically only sets up version variables for the current project, i.e. it
replaces
project(Foo CXX)
set(Foo_VERSION_MAJOR 1)
set(Foo_VERSION_MINOR 2)
set(Foo_VERSION_PATCH 3)
set(Foo_VERSION
${Foo_VERSION_MAJOR}.${Foo_VERSION_MINOR}.${Foo_VERSION_PATCH})
with one function call, which results in a set of variables with standard
names (not related to find_package()).
Alex
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] RFC: add version to project() call
Am Montag, 6. Januar 2014, 23:26:49 schrieb Alexander Neundorf: On Monday 06 January 2014, Rolf Eike Beer wrote: Am Montag, 6. Januar 2014, 22:41:26 schrieb Alexander Neundorf: Hi, on cmake stage I have a simple branch AddVersionToProjectCommand. This extends the project command to also accept a version number: project(Foo VERSION 1.2.3 CXX) Cool, I like this. Shouldn't there be spaces on both sides of operators (e.g. '= 2')? ? I mean in the C++ code where you check the components. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
