Re: [cmake-developers] Commit 4c98de33: cmLocalGenerator: fix the default configuration check
Hello Ben, I think the change is also required for the following line (line 424): if(!default_config !configurationTypes.empty()) Because here the default_config could also be a valid pointer with an empty content/string. Nevertheless I had already posted a working patch which uses a std::vector and std::string instead to prevent such pointer problems. Best Regards Roman -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Commit 4c98de33: cmLocalGenerator: fix the default configuration check
On Mon, Feb 02, 2015 at 23:47:15 +0100, Roman Wüger wrote: I think the change is also required for the following line (line 424): if(!default_config !configurationTypes.empty()) Because here the ?default_config? could also be a valid pointer with an empty content/string. Nevertheless I had already posted a working patch which uses a std::vector and std::string instead to prevent such pointer problems. Yeah, your patch is better. I'll revert mine and put yours up. Do you have/want access to the stage to push it yourself? I can do so if not. http://www.cmake.org/Wiki/CMake/Git/Develop Thanks, --Ben P.S. Also, seems I hadn't switched this repo over to my Kitware email anyways for this commit. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Fwd: [CMake] CPack in CMake 3.1.0 doesn't install files
Forwarding to CMake Developers as this looks to be bug. -- Forwarded message -- From: NoRulez noru...@me.com Date: Mon, Feb 2, 2015 at 9:54 AM Subject: Re: [CMake] CPack in CMake 3.1.0 doesn't install files To: Robert Maynard robert.mayn...@kitware.com Cc: CMake MailingList cm...@cmake.org Hi, I think I found the problem: In the file cmLocalGenerator.cxx the pointer is always true since 3.1.0, which was a const char* in 3.0.2. and now it could point to an empty const std::string, but the pointer is still valid The if statement is: if(!default_config) And should be (line 411): if(!default_config || (default_config strlen(default_config) == 0)) Best Regards Am 23.01.2015 um 09:15 schrieb NoRulez noru...@me.com: Hi, i've tested it also with 3.1.1 and the failure behaves the same. Best Regards Am 21.01.2015 um 10:00 schrieb NoRulez noru...@me.com: Hi, it should also not work when you build a test project in release mode and then in the build directory type cpack -G ZIP for example. (Without the -C option) In the CTestScript is also added the -C option to ensure it uses the release mode, but it doesn't work either. When you then open the cmake_install.cmake files, you will see that the CMAKE_INSTALL_CONFIG_NAME variable is empty on line 15. In CMake 3.0.2 the variable is set with the value Release. Best Regards Am 20.01.2015 um 18:40 schrieb Robert Maynard robert.mayn...@kitware.com: Hi, I haven't seen this issue but if you have a self-contained and reduced (preferably plain CMake ) test case, I would be happy to run it and verify if this is a regression. On Tue, Jan 20, 2015 at 2:37 AM, NoRulez noru...@me.com wrote: No one? Has something changed between 3.0.2 to 3.1.0 which prevents cpack to copy the generated *.exe file to the _CPack_Packages directory? Or did i need an additional variable to be set in 3.1.0? Thanks in advance Best Regards Am 16.01.2015 um 12:09 schrieb NoRulez noru...@me.com: If I switch back to 3.0.2 everything is working like a charm Best Regards Am 15.01.2015 um 17:49 schrieb NoRulez noru...@me.com: Hello, we have only upgraded to the last release 3.1.0 from 3.0.2 and get the following when cpack is executed in a CTestScript: error: fixup_bundle: not a valid bundle The files are ceated, but they are not copied to the _CPack_Packages folder Then I found out that the variable CMAKE_INSTALL_CONFIG_NAME is empty in the cmake_install.cmake files Any hints? Best Regards -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to
Re: [cmake-developers] Fwd: [CMake] CPack in CMake 3.1.0 doesn't install files
On Mon, Feb 02, 2015 at 09:56:26 -0500, Robert Maynard wrote: Forwarding to CMake Developers as this looks to be bug. Oops, indeed. Pushing out a patch. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Extracting target metadata, IDE integration
On Mon, Jan 26, 2015 at 9:15 PM, Tobias Hunger tobias.hun...@gmail.com wrote:
I gave this patch a try with the cmake project data.
I had hoped that this file would contain all the information an IDE
might need, but there seems quite a bit missing for that. E.g. there
is no information on which files are used to build a target. What am I
missing?
Best Regards,
Tobias
On Mon, Jan 26, 2015 at 4:23 PM, Brad King brad.k...@kitware.com wrote:
On 01/25/2015 08:26 AM, Tobias Hunger wrote:
I just had a bit of time to play with cmake this weekend: Is this
patch available somewhere by now?
Aleix sent it in a message of this thread on 2015-01-09:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/10711/focus=12061
Some review comments elsewhere in this thread are still pending.
-Brad
It does provide them. For example [1].
Isn't that what you meant?
Aleix
[1]
{
name: kdevcmakebuilder,
type: MODULE_LIBRARY,
configs: [
{
name: debug,
sources: [
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuilder.cpp,
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/cmakejob.cpp,
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/prunejob.cpp,
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp,
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder/ui_cmakebuildersettings.h,
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuilderconfig.cpp,
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuilderconfig.h,
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder/kdevcmakebuilder_automoc.cpp,
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuildersettings.ui,
/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/cmakebuilderconfig.kcfgc
]
}
],
directory:
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder,
location:
/home/kde-devel/build-frameworks/kdevelop/projectbuilders/cmakebuilder/kdevcmakebuilder.so,
backtrace:
[/home/kde-devel/frameworks/kdevelop/projectbuilders/cmakebuilder/CMakeLists.txt:20],
installed: true
}
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Fix for the default configuration for CMAKE_INSTALL_CONFIG_NAME
Hello, since version 3.1.0 CMake generates cmake_install.cmake files where the default configuration is empty. (e.g.: set(CMAKE_INSTALL_CONFIG_NAME )) In previous versions = 3.0.2 the default_config variable points to a NULL pointer for invalid configurations. In later releases the variable points to valid objects, even if the configuration is empty. Attached is a patch to fix this issue. Best Regards Roman 0001-Bugfix-Fix-default-config-for-CMAKE_INSTALL_CONFIG_N.patch Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
