Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-03-17 Thread Raffi Enficiaud

 On 17 Mar 2015, at 19:39, Brad King brad.k...@kitware.com wrote:
 
 On 03/17/2015 12:28 PM, Raffi Enficiaud wrote:
 I think everything in http://www.cmake.org/Bug/view.php?id=14641 was 
 addressed.
 What should the maintainer usually do?
 
 I've marked your Mantis account as a developer for CMake and assigned
 the issue to you.  In this case since it's already resolved I went ahead
 and marked the issue as such already.  Future issues with this module may
 be assigned to you.
 
 Thanks,
 -Brad
 

Very good, and many thanks for your support,

Best,
Raffi

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-03-17 Thread Raffi Enficiaud

Le 12/03/15 21:00, Brad King a écrit :

On 03/12/2015 12:35 PM, Raffi Enficiaud wrote:

I will squash all this together once everything is done.
For now please base further work on commit 3743aa11.
We'll see how this does on the nightly testing!



Hi,

I have a problem running the tests on win7. All the tests are passing, 
but at the end, I have the following:


17-Mar-2015 04:23:23100% tests passed, 0 tests failed out of 21
17-Mar-2015 04:23:23
17-Mar-2015 04:23:23Total Test time (real) =  21.84 sec
17-Mar-2015 04:23:23 	Add file: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/CMakeScripts/findmatlab_nightbuild.cmake
17-Mar-2015 04:23:23 	Add file: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/CMakeScripts/cmake_common.cmake
17-Mar-2015 04:23:23 	Add file: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/CMakeScripts/findmatlab_nightbuild.cmake
17-Mar-2015 04:23:23 	Add file: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/CMakeScripts/kwsys_common.cmake

17-Mar-2015 04:23:23Submit files (using http)
17-Mar-2015 04:23:23   Using HTTP submit method
17-Mar-2015 04:23:23 	   Drop 
site:http://open.cdash.org/submit.php?project=KWSys
17-Mar-2015 04:23:40 	   Uploaded: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/My 
Tests/KWSys-build/Testing/20150317-0100/Build.xml
17-Mar-2015 04:23:44 	   Uploaded: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/My 
Tests/KWSys-build/Testing/20150317-0100/Configure.xml
17-Mar-2015 04:23:49 	   Uploaded: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/My 
Tests/KWSys-build/Testing/20150317-0100/Notes.xml
17-Mar-2015 04:23:53 	   Uploaded: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/My 
Tests/KWSys-build/Testing/20150317-0100/Test.xml
17-Mar-2015 04:23:56 	   Uploaded: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/My 
Tests/KWSys-build/Testing/20150317-0100/Update.xml

17-Mar-2015 04:23:56   Submission successful
17-Mar-2015 04:23:57 	Error in read script: 
D:/bamboo_build_dir/SW-CMAK-JOB1/dashboard/CMakeScripts/findmatlab_nightbuild.cmake
17-Mar-2015 04:23:57 	Failing task since return code of [C:\Program 
Files (x86)\CMake 2.8\bin\ctest.exe -S findmatlab_nightbuild.cmake -V] 
was -1 while expected 0



The content of the findmatlab_nightbuild.cmake is

set(CTEST_SITE bambooagent.raffienficiaud)
set(CTEST_BUILD_NAME Win7x64-vs2013e-matlab2013b)
set(CTEST_BUILD_CONFIGURATION Debug)
set(CTEST_CMAKE_GENERATOR Visual Studio 12 Win64)

set(dashboard_cache CMake_TEST_FindMatlab:BOOL=ON)
include(${CTEST_SCRIPT_DIRECTORY}/cmake_common.cmake)

and I am using ctest 2.8.12 to run -S findmatlab_nightbuild.cmake -V

Any clue?

Raffi

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [CMake] Problems with WriteCompilerDetectionHeader and cxx_nullptr

2015-03-17 Thread Brad King
On 03/16/2015 03:05 AM, Roman Wüger wrote:
 attached is an updated patch.

Applied, thanks:

 WCDH: Fix cxx_nullptr workaround for pre-C++11 compilers
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f9d09626

-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] Fix FindPackageHandleStandardArgs documentation

2015-03-17 Thread Brad King
On 03/14/2015 05:23 PM, Gregor Jasny wrote:
 this is my first attempt to practice the topic workflow.
 I pushed the attached patch to the topic branch and
 await review before merging to next.

The change looks good.  Please change the commit message to
start in the line

 FPHSA: Revise documented command signature

We use the FPHSA:  prefix for changes to that module.
Then force-push the topic back to the stage and merge to
'next', please.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-03-17 Thread Brad King
On 03/17/2015 12:28 PM, Raffi Enficiaud wrote:
 I think everything in http://www.cmake.org/Bug/view.php?id=14641 was 
 addressed.
 What should the maintainer usually do?

I've marked your Mantis account as a developer for CMake and assigned
the issue to you.  In this case since it's already resolved I went ahead
and marked the issue as such already.  Future issues with this module may
be assigned to you.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] file glob and glob recurse directory listing difference

2015-03-17 Thread Brad King
On 03/15/2015 06:37 PM, Domen Vrankar wrote:
 Alternative would be to define LIST_DIRECTORIES for GLOB_RECURSE only
 and preserve back compatibility that way - maybe also define
 NO_DIRECTORY_LISTING for GLOB just for the sake of consistency.

Let's just define both options for both commands so that it can
always be explicitly specified.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] ABI.h.in: add support for Xtensa architecture

2015-03-17 Thread Brad King
On 03/17/2015 08:51 AM, Max Filippov wrote:
 Signed-off-by: Max Filippov jcmvb...@gmail.com

Thanks, applied:

 KWIML: Teach ABI.h about Xtensa architecture
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ded79a97

 Merge branch 'upstream-kwiml' into update-kwiml
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=67940795

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH v8 0/5] Add XCTest Bundle Support

2015-03-17 Thread Brad King
On 03/14/2015 03:03 PM, Gregor Jasny wrote:
 I changed it into a Find module and it looks much more polished
 now.

Great.

 I fully agree that modifying the testee is not something one would
 expect when adding a test for it. Therefore I reverted the rpath
 setting for Frameworks and replaced it with a DYLD environment
 variable when calling xctest. For the App Bundle I reverted your
 ENABLE_EXPORTS call and replaced it with Xcode specific settings
 for the XCODE generator and a linker flag for the Makefile generator.

Okay.

 +  target_link_libraries(${target}
 +PRIVATE -bundle_loader $TARGET_FILE:${testee})

Please try using this in a CMake source/build tree each with spaces
in the path.  Quoting may need updating; perhaps:

  target_link_libraries(${target}
 PRIVATE -bundle_loader $TARGET_FILE:${testee})

 Once you ACK the series I will create a topic branch and follow
 the developer instructions.

Please proceed.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [PATCH] ABI.h.in: add support for Xtensa architecture

2015-03-17 Thread Max Filippov
Signed-off-by: Max Filippov jcmvb...@gmail.com
---
 Utilities/KWIML/ABI.h.in | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/Utilities/KWIML/ABI.h.in b/Utilities/KWIML/ABI.h.in
index 21c9139..6300ada 100644
--- a/Utilities/KWIML/ABI.h.in
+++ b/Utilities/KWIML/ABI.h.in
@@ -432,6 +432,12 @@ suppression macro @KWIML@_ABI_NO_VERIFY was defined.
 #  define @KWIML@_ABI_ENDIAN_ID @KWIML@_ABI_ENDIAN_ID_BIG
 # endif
 
+/* Xtensa */
+#elif defined(__XTENSA_EB__)
+# define @KWIML@_ABI_ENDIAN_ID @KWIML@_ABI_ENDIAN_ID_BIG
+#elif defined(__XTENSA_EL__)
+# define @KWIML@_ABI_ENDIAN_ID @KWIML@_ABI_ENDIAN_ID_LITTLE
+
 /* Unknown CPU */
 #elif !defined(@KWIML@_ABI_NO_ERROR_ENDIAN)
 # error Byte order of target CPU unknown.
-- 
1.8.1.4

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015451]: Setting MAP_IMPORTED_CONFIG_CONFIG hides IMPORTED_LOCATION

2015-03-17 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://public.kitware.com/Bug/view.php?id=15451 
== 
Reported By:Bjoern Thiel
Assigned To:
== 
Project:CMake
Issue ID:   15451
Category:   CMake
Reproducibility:always
Severity:   major
Priority:   normal
Status: new
== 
Date Submitted: 2015-03-17 07:30 EDT
Last Modified:  2015-03-17 07:30 EDT
== 
Summary:Setting MAP_IMPORTED_CONFIG_CONFIG hides
IMPORTED_LOCATION
Description: 
I thought IMPORTED_LOCATION is a fall back for IMPORTED_LOCATION_CONFIG and
should be found in any case. But cmTarget::GetMappedConfig gives up too early:
if(!mappedConfigs.empty()  !*loc  !*imp) { return false; } (line 5540)
Example: set(CMAKE_MAP_IMPORTED_CONFIG_RELWITHDEBINFO RELEASE) and try to use
Qt5::moc in the RelWithDebInfo configuration.

Steps to Reproduce: 
See above.
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2015-03-17 07:30 Bjoern Thiel   New Issue
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-03-17 Thread Raffi Enficiaud

 On 17 Mar 2015, at 16:25, Brad King brad.k...@kitware.com wrote:
 
 Nothing right now!  I've squashed this all into one commit:
 
 FindMatlab: Rewrite module and provide a usage API
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=49c8dcf7
 
 and merged to 'master' for inclusion in 3.3.
 
 Thanks for all your work on this and persistence with following up
 on feedback.  This is a huge improvement over the previous FindMatlab
 module.
 
 -Brad

I am happy that it worked! 
I think everything in http://www.cmake.org/Bug/view.php?id=14641 was addressed.
What should the maintainer usually do?

Best,
Raffi
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers