Re: [cmake-developers] [CPack] Call for volunteer for CPackRPM, CPackDeb maintenance.

Hello, I have been talking with Eric for the past few days now and would also like to help out with maintaining these two modules. I am a CMake user for about six years now and have also been using CPackRPM but for now I haven no experience with CPackDeb. As suggested by Eric I'll start with

[cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

Hi, I extended the proposed patch for ticket 13176 with: - documentation section - CPACK_RPM_component_PACKAGE_DESCRIPTION fallback to CPACK_COMPONENT_compName_DESCRIPTION - handling of cases when one component sets its variable and the other doesn't Regards, Domen -- Powered by

Re: [cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

that could be used by CPACK_RPM_component_PACKAGE_SUMMARY as default value? Thanks, Domen 2014-10-14 0:23 GMT+02:00 Domen Vrankar domen.vran...@gmail.com: Message was sent to early by accident so I'm resending the rest. 2014-10-14 0:17 GMT+02:00 Domen Vrankar domen.vran...@gmail.com: Hi, I

Re: [cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

2014-10-14 9:28 GMT+02:00 Eric Noulard eric.noul...@gmail.com: 2014-10-14 9:03 GMT+02:00 Domen Vrankar domen.vran...@gmail.com: Sorry for spamming... I noticed that the previous patch would break user provided rpm spec files so I'm attaching a new patch that fixes that problem with a bit

[cmake-developers] CMake and CPack automated testing

Hi, I was looking at CMake automated tests and did not quite understand how they are intended to be written. Do they only test for e.g. if CPack executes without errors or do they check generated files content (e.g. diff or call for e.g. rpm -qi some_pkg.rpm and then diff the output)? I'm not

Re: [cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

I also have a question. Would CPack also need something like CPACK_COMPONENT_component_PACKAGE_SUMMARY that could be used by CPACK_RPM_component_PACKAGE_SUMMARY as default value? Not sure of that one. We already have CPACK_COMPONENT_GROUP_CMAKE_DESCRIPTION which may be a default value for

Re: [cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

I also wrote a test and noticed two things: 1) CPackComponentsForAll test is using component names in lower case and component parts in variables in upper case (e.g. COMPONENT headers and CPACK_COMPONENT_HEADERS_DESCRIPTION). Patch uses CPACK_RPM_PACKAGE_COMPONENT variable as part of

Re: [cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

2014-10-21 14:52 GMT+02:00 Brad King brad.k...@kitware.com: On 10/21/2014 02:18 AM, Domen Vrankar wrote: Patches must be applied in order: 0001-CPackRPM-component-based-packaging-description-and-s.patch 0001-add-added-semantic-tests-for-rpm-component-descripti.patch Could someone pleas

Re: [cmake-developers] [CMake] [CPack] RPM generator creates %dir for /usr/local/xxx

Moving the conversation to developers mailing list. More docs on this for 2.8.12: http://www.cmake.org/cmake/help/v2.8.12/cpack.html#variable:CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION I guess that /usr/local may be added to CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST default list values. For

[cmake-developers] [CPack] [CPackRPM]patch for bug 15209 - handling of symbolic links

a relative path symlink if needed. Please review the patch and post the feedback. If the patch is OK add it to repository. Thanks, Domen From 0a3098dbeb79c90ac3882b13afa77e6e8ff98d62 Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Sat, 8 Nov 2014 22:01:19 +0100 Subject

Re: [cmake-developers] string SUBSTRING TRUNCATE mode

This should be a good addition, no? diff --git a/Modules/CPackRPM.cmake b/Modules/CPackRPM.cmake index 56d9b66..66717ef 100644 --- a/Modules/CPackRPM.cmake +++ b/Modules/CPackRPM.cmake @@ -683,9 +683,7 @@ foreach(_RPM_SPEC_HEADER URL REQUIRES SUGGESTS PROVIDES OBSOLETES PREFIX

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 21:09 GMT+01:00 Brad King brad.k...@kitware.com: On 11/17/2014 02:46 PM, Gauthier Lamaison wrote: I've been trying to make multiple RPMs using components, but it appears that the component variables such as CPACK_RPM_componentName_PACKAGE_REQUIRES are not correctly unset. Worse,

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 23:05 GMT+01:00 Domen Vrankar domen.vran...@gmail.com: 2014-11-17 21:09 GMT+01:00 Brad King brad.k...@kitware.com: On 11/17/2014 02:46 PM, Gauthier Lamaison wrote: I've been trying to make multiple RPMs using components, but it appears that the component variables

Re: [cmake-developers] [PATCH] Avoid bad alloc for large files

I received a bad alloc when uploading a large file with CTest. The patch below resolved this. Your patch is line-wrapped and can't be applied. However, I did this by hand. This is basically the same, but it avoids the needless floating point arithmetic. Does it work for you? snip

Re: [cmake-developers] [PATCH] Avoid bad alloc for large files

I received a bad alloc when uploading a large file with CTest. The patch below resolved this. I just took a look at the code and noticed that it is quite memory consumption heavy ((2 * encoded_buffer_size) + file_buffer_size). This implementation could be used instead (not tested): std::string

Re: [cmake-developers] [Review request] Topic install_CMAKE_INSTALL_RELATIVE

) before submitting the patch for review. Preview patch is attached. Regards, Domen From 2d5289559527371e3fce555d49b20e6789d1324c Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Mon, 22 Dec 2014 21:22:34 +0100 Subject: [PATCH] multiple path relocation prefixes Allow multiple

[cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

Hello, Could somebody please review the topic rpm_multi_prefix. http://www.cmake.org/gitweb?p=stage/cmake.git;a=commit;h=c908ba3707fcf8cf43df0c5cd90f8ea6d98d7c29 Patch adds support for multiple relocation paths per RPM package. For relocation paths I have extended GNUInstallDirs module since it

Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

Add the --target argument to rpmbuild Do not add a BuildArch variable to the spec file for arch specific packages BuildArch causes rpm building to fail except for noarch packages I'm not too familiar with cross compilation problems so could you please also provide a simple test case to help

[cmake-developers] fixing a bug after topic was merged to master

Hi all, While writing tests for a new topic I found a bug in an older topic that I wrote. The that topic was already merged to master (last week) but remote stage branch still exists. The fix is trivial - one variable typo. How can I get the fix both into master and next release candidate

[cmake-developers] CPack RPM failing tests on dashboard

I've noticed CPack/RPM test fails on dashboard for two Fedora-19-x86_64 machines: https://open.cdash.org/buildSummary.php?buildid=3658687 https://open.cdash.org/buildSummary.php?buildid=3658677 Would it be possible to get generated rpm files from one of them for analysis?

Re: [cmake-developers] CPack RPM failing tests on dashboard

May be you can make RunCPackVerifyResult.cmake more verbose when a failure occurs? (i.e. a bunch of extra rpm query on the culprit generated RPM) and/or more informations in the error message. You're right. Haven't thought about such cases when I don't have the output RPM files. I'll extend

Re: [cmake-developers] [PATCH] Setting default user, group and permissions for CPackRPM

On 01/13/2015 01:55 AM, Domen Vrankar wrote: This patch is somewhat related to http://public.kitware.com/pipermail/cmake/2014-December/059460.html (bug report: http://www.cmake.org/Bug/view.php?id=3602) as it defines user and group that should be used for RPM content but on a per RPM scale

Re: [cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

2014-12-31 2:03 GMT+01:00 Domen Vrankar domen.vran...@gmail.com: Hello, Could somebody please review the topic rpm_multi_prefix. http://www.cmake.org/gitweb?p=stage/cmake.git;a=commit;h=c908ba3707fcf8cf43df0c5cd90f8ea6d98d7c29 Patch adds support for multiple relocation paths per RPM package

Re: [cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

Resending as I accidentally dropped the developers mailing list... 2015-01-16 22:38 GMT+01:00 Brad King brad.k...@kitware.com: On 01/16/2015 08:42 AM, Brad King wrote: Go ahead and merge to 'next' for testing and follow up with any dashboard trouble. I'll still be able to review it there.

Re: [cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

2015-01-16 23:16 GMT+01:00 Domen Vrankar domen.vran...@gmail.com: One other idea came to mind... Allow arbitrary paths for different prefixes and a script to generate prefixes from paths in GNUInstallDirs. That would be a more general solution. I could also remove the use of GNUInstallDirs

Re: [cmake-developers] old policies interfering with script provided by CPack

I decided not to add a module-wide policy scope just before a release in case it causes other problems. Instead I converted the fix to set the policy locally: CPackRPM: Do not run file(GLOB_RECURSE) without CMP0009 set to NEW http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=be36bfd6

Re: [cmake-developers] KWSys patches

I'll get the KWSys patch through. Once it is integrated into CMake then you can rebase the CMake part of the change on that. However, please revise the logic in the KWSys patch to avoid using exceptions. I've noticed that exceptions are not used but was not certain how else to handle this

Re: [cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

From: Domen Vrankar domen.vran...@gmail.com Date: Wed, 28 Jan 2015 23:48:57 +0100 Subject: [PATCH] fixup! cpack rpm multiple path relocation prefixes CPackRPM test was refactored to use RunCMake infrastructure. --- Tests/CMakeLists.txt| 9 - Tests/CPackRPM

Re: [cmake-developers] [PATCH][CPack][RPM] multiple path relocation prefixes

I'm not familiar with the corresponding use case. Please explain how multiple relocation paths works in general with RPM tools. In RPM packages you can specify multiple Prefix: sections and during installation you have multiple options: use --prefix new_path during installation: this will

[cmake-developers] [PATCH] Setting default user, group and permissions for CPackRPM

and CPACK_compName_DEFAULT_DIR_PERMISSIONS for default directory permissions Regards, Domen From 8a7981b4e710cbcf730eb30f16fc205992cf68d2 Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Tue, 13 Jan 2015 00:22:02 +0100 Subject: [PATCH] cpack rpm setting of defattr RPM supports setting

[cmake-developers] old policies interfering with script provided by CPack

Hi everyone, During testing of CPackRPM with older CMakeLists.txt I noticed that cmake_minimum_required from that script affects how CPackRPM script works. The policy that is causing problems is CMP0009 - FILE GLOB_RECURSE calls should not follow symlinks by default. To get around this problem

Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

I've finally had some time to read over the Tests section, and it is a bit overwhelming. I'm going to describe the use cases for my patch and perhaps you can give me some guidance on adding an actual test. There are three, maybe four use cases: 1) native rpm (e.g. x86_64) 2) noarch rpm (a

[cmake-developers] KWSys patches

contribute this patch? Attached are KWSys patch and KWSys+CMake patch. Thanks, Domen From 9c113fe546669a064d461004ae7e74be07744e40 Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Sun, 15 Feb 2015 20:42:16 +0100 Subject: [PATCH] handle cyclic recursion when using glob

[cmake-developers] file glob and glob recurse directory listing difference

Hi all, I'm working on a patch to enable directory listing in file(GLOB_RECURSE...). Currently GLOB lists directories and GLOB_RECURSE doesn't. I was thinking about unifying the two by providing NO_DIRECTORY_LISTING option. Unfortunately this breaks back compatibility so I would need to use a

Re: [cmake-developers] [PATCH] CPack: change cpack_set_if_not_set into a function

If you work on that, please include tests (perhaps in the form of a new Tests/RunCMake/CPack directory), documentation updates, and a release note in a file such as 'Help/release/dev/cpack-maybe-set.rst'. For that you could rename Tests/RunCMake/CPackRPM to CPack and add your tests there -

Re: [cmake-developers] KWSys patches

). Thanks, Domen From 88566a6912e795b435be585a7bf009ba40d1f73c Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Sat, 21 Feb 2015 10:54:34 +0100 Subject: [PATCH 1/4] glob recurse cyclic recursion handling Prevent cyclic recursion of type a/b/c-a when glob recurse is used

Re: [cmake-developers] [PATCH 0/3] CPACK_RPM_PACKAGE_ARCHITECTURE

2015-02-19 9:01 GMT+01:00 Joshua A Clayton stillcompil...@gmail.com: This patch series extends CPackRPM to support cross-built rpms Previously only native and noarch rpms were possible. Other architecture choices resulted in an error from rpmbuild. Also included at no extra charge, is

Re: [cmake-developers] KWSys patches

, Domen From 88566a6912e795b435be585a7bf009ba40d1f73c Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Sat, 21 Feb 2015 10:54:34 +0100 Subject: [PATCH 1/4] glob recurse cyclic recursion handling Prevent cyclic recursion of type a/b/c-a when glob recurse is used with follow

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Is there any other thing you would like to do before I continue working on this? Do you foresee any other change like this? No, go ahead. Regards, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I do not know how you would like to proceed. It should not be any issue in applying the patches in sequence from the changes you made yesterday. Hi, I just started applying and reviewing the patches. It will take me a while to get through them. I'll write to you after I'm done. Thanks, Domen

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Thanks for the explanations. Which raises new questions: How would I create empty lists then (to which I can subsequently append)? Or check that a variable is defined? Or tell the calling function that the output variable is set to an empty string? Those questions should sound very naive,

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Hi, I just installed a virtual machine running Debian 7.8.0, and everything worked like a charm from the first run. I did that in the two following way: - sourced my branch https://github.com/raffienficiaud/CMake/tree/cpack_deb_refactoring - I also applied the cherry-picked from that branch

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Should I rebased on a2d36e3? The patch doesn't contain allot of changes so even if you don't the merge will be trivial so it's up to you. Regards, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Hi, If I am not mistaken, this does not work in the current state of the cmCpackDebGenerator.cxx (I tried of course). I wanted to know by which *magic* this could work, and also why you are suggesting me this, which lead me to this: - CPackRPM: all the RPM creation is driven by the

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I'll write a patch for that today and push it to next. I'll also add link here so that you'll be able to use it before it gets to master. Here's the patch: http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=268e008 Now it should be easy to add support for per component variables. There is

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

On the other hand variables that are set in CPackDEB.cmake for one component are later visible in the other - they don't get reread from CMakeLists.txt for every pass. So setting variables inside CPackDEB.cmake is a bit dangerous. Ok. I do not understand that much the value of this feature,

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Hi, I pushed your first patch to next (I've split it into two separate commits and made some minor cleanup changes): http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=8e0ecf9 Please find attached my last patch that allows the settings of the dependencies per component. I haven't finished

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I recommend git rebase: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i Didn't know about interactive mode for rebase - seems allot simpler than what I described. Thanks. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Please find attached the patch concerning the description per component, with the associated documentation, based on 75b0e1679c39ca824a4c49d9e1a2ae2b5f04ae06. Applied with minor changes - added component text from your other patch - changed CPACK_DEBIAN_PACKAGE_DESCRIPTION documentation to

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-29 18:35 GMT+02:00 Domen Vrankar domen.vran...@gmail.com: Applied with minor changes - added component text from your other patch - changed CPACK_DEBIAN_PACKAGE_DESCRIPTION documentation to more accurately describe fall back options http://www.cmake.org/gitweb?p=cmake.git;a=commit;h

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Hi, Sorry for not replying sooner. Please find attached a patch for the reworked documentation. I tried to make the doc more consistent with the CPackRPM (doc right after the variable declaration and options afterwards). I also put links for the variables and changed the formatting a bit.

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I am having a look now at the changes you made on the first patch (say 75b0e1679c39ca824a4c49d9e1a2ae2b5f04ae06), file RunCPackComponentsDEB/RunCPackVerifyResult-components-lintian-dpkgdeb-checks.cmake Instead of finding lintian and dpkg-deb in the check file find_program(LINTIAN_EXECUTABLE

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Hi, Would you please add set( CPACK_DEBIAN_PACKAGE_DEBUG ON) to the file MyLibCPackConfig-splitted-components-depend2.cmake.in so that we also have the debug logs? I currently don't have access to my computer so I'll send you that in about a week. BTW, I do not know what CPackDEB.cmake

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-05-04 9:53 GMT+02:00 Domen Vrankar domen.vran...@gmail.com: Your test managed to find issues with previous code - automatic dependency detection doesn't work on older versions of dpkg-shlibdeps script. I wrote that a bit unclearly... With previous code I meant code

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

b2ce1fcdd4c003f938dd85491a6d181cb24fc00f Mon Sep 17 00:00:00 2001 From: Domen Vrankar domen.vran...@gmail.com Date: Fri, 8 May 2015 07:51:30 +0200 Subject: [PATCH] CPackDEB: Enabling the settings of the dependencies per component. --- Modules/CPackDeb.cmake | 48 ++-- Tests/CMakeLists.txt

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Thank you Domen! I will send you new patches today or tomorrow for the last points. BTW, in CDash, where are the builds of next? Is it Nightly Expected or Nightly? Use Nightly Expected. Not certain what Nightly section contains. Your test managed to find issues with previous code -

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Your test managed to find issues with previous code - automatic dependency detection doesn't work on older versions of dpkg-shlibdeps script. I wrote that a bit unclearly... With previous code I meant code that was there already before your patch. Regards, Domen -- Powered by

Re: [cmake-developers] [PATCH] CPackRPM Module: output RPMBUILDOUT when intended

The following (and attached) patch outputs RPMBUILDERR and RPMBUILDOUT as advertised Applied: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=1a2a73a Thanks, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Please find attached the reworked patch and the fix (separate file) for the problem you are facing. In separate patches, I also enabled the full debug messages output in a separate patch, + some additional logs. Bitten by my own change... Nice catch. Thanks for finding this. Your changes did

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

It would have been hard to ship a missing binary in the patch :) True :) Apparently in this package https://packages.debian.org/fr/sid/dpkg-dev that comes also with build-essential I actually prefer having one vanilla installation for basic testing so I'll stick with it. BTW, is it the

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I forgot that the previous patch has not yet been merged to master so no need to hurry. Thanks, Domen 2015-05-09 10:58 GMT+02:00, Domen Vrankar domen.vran...@gmail.com: It would have been hard to ship a missing binary in the patch :) True :) Apparently in this package https

Re: [cmake-developers] Missing CPACK_PACKAGE_CONTACT in test for CPackComponentsPrefix

2015-05-07 15:12 GMT+02:00 Kornel Benko kor...@lyx.org: Hi, testing new cmake, I get ctest error for the call # ctest -R CPackComponentsPrefix [snip] Adding line set(CPACK_PACKAGE_CONTACT someContact) in Tests/CPackComponentsPrefix/CMakeLists.txt cures the testcase for me.

Re: [cmake-developers] Missing CPACK_PACKAGE_CONTACT in test for CPackComponentsPrefix

I'll fix this so that tests will run in nightly testing. Applied patch: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=3f300b Thanks, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

Please find attached some rework on the documentation. There is no hurry :) Applied with minor changes: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=efab805 Thanks, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I was wondering if this issue has been addressed so far. As far as I can tell from the bug report I don't think so... If it doesn't work in CMake 3.2 then it definitely wasn't. If the maintainer of the CPackDeb agrees, I can try to resolve this. Go ahead. Could you also provide some automated

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

I confirm this does not work with 3.2. I also would like to disable CPACK_DEBIAN_PACKAGE_SHLIBDEPS on some of the components (dpkg-shlibdeps complains right now for eg. packages containing only documentation). Fine with me as long as you provide the tests. Ok, it was a good excercise to

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

In the member function cmCPackGenerator::WantsComponentInstallation, apparently it is required that groups AND components exist to have the component install: https://github.com/Kitware/CMake/blob/master/Source/CPack/cmCPackGenerator.cxx#L1505 If I change the line to

[cmake-developers] new cpack tests

Hi all, In the past few months some additional semantic checks were added into CPackComponentsForAll test - in particularly into IgnoreGroup test. Now it's becoming harder to add new tests there as each test requires somewhat different package content and variable settings. It is also getting

Re: [cmake-developers] A policy for Policies

A better Policy lifecycle would be 1) Three releases after introducing a Policy, we make OLD the same as WARN for it. That is, the only way to not get the warning will be to fix the code or use -Wno-dev. 2) After some time in years (depending on the impact of the Policy), we change

Re: [cmake-developers] A policy for Policies

And do we really still need version 2.6 as default (we could bump this version to where current policies are still treated as warnings not errors)? To which default do you refer? Where in our code is it set? Likely we cannot update it because it could change behavior of existing scripts

Re: [cmake-developers] CMake Build RPM for Centos/RHEL

2. Is there a way to generate a RPM with standard name: I mean, something like: cmake-3.2.3-1.el6.x86_64.rpm Instead of: cmake-3.2.3-Linux-x86_64.rpm You can add -D CPACK_OUTPUT_FILE_NAME=cmake-${RPM_RELEASE}.el6.x86_64.rpm to your packaging command. This will force package

Re: [cmake-developers] Add command line options for deprecation message control

The branch seems to make the RunCMake.CPack_RPM test fail on my machine. I have not investigated. Missed this thread... I was talking to Brad about this. Failing test is written exactly for testing author warning message (CPackRPM.cmake:560). RPM packages may be relocatable but if relocation

Re: [cmake-developers] [CPackDeb] Configure Debian package name for components

2015-11-08 20:01 GMT+01:00 Markus Rickert : >> This is a long standing issue with related bugs: >> http://public.kitware.com/Bug/view.php?id=12997 >> http://public.kitware.com/Bug/view.php?id=12574 >> http://public.kitware.com/Bug/view.php?id=11050 >>

Re: [cmake-developers] [ANNOUNCE] CMake 3.4.0 Released

2015-11-12 22:52 GMT+01:00 Jean-Michaël Celerier : >> * The "CPackDeb" module now correctly excludes symlinks during > package checksum calculation. > >> * The "CPackDeb" no longer uses fakeroot and system tar program for > packaging. > > Does this mean that the

Re: [cmake-developers] [CPackDEB] handling "Source" field and Launchpad support

> Thanks. There are several .rst documentation updates like: > >> -# CPackDeb is a CPack generator thus it uses the CPACK_XXX variables >> +# CPackDeb is a CPack generator thus it uses the `CPACK_XXX` variables > > This appears to intend to use inline markup for inline literals but > that is

Re: [cmake-developers] CMake 3.4.0-rc2 cpack xz compressed debian packages broken

2015-11-03 10:53 GMT+01:00 Raffi Enficiaud : > Le 23/10/15 17:04, Brad King a écrit : >> >> On 10/23/2015 06:04 AM, Raffi Enficiaud wrote: >>> >>> Fix attached! (based on current master a03c13a) >> >> >> Thanks. I backported it to 'release' and applied: >> >>

Re: [cmake-developers] [CPackDEB] handling "Source" field and Launchpad support

> Please find attached a patch that enables the proper handling of the > "Source" field for binary Debian packages. I've split the patch and applied it to next with minor changes: https://cmake.org/gitweb?p=cmake.git;a=commit;h=0cb1469 https://cmake.org/gitweb?p=cmake.git;a=commit;h=76f0fd0 > I

Re: [cmake-developers] [CPackRPM] Configure RPM package group and name per component

2015-11-15 20:32 GMT+01:00 Markus Rickert : > Hi, > > similar to the previous patch for CPackDeb, the attached patch adds > component-specific settings for group and name of an RPM package. > > CPACK_RPM__PACKAGE_GROUP allows setting the group of the > component with the main

Re: [cmake-developers] [PATCH] Add a test for checking that the CPack module produces correct config files

Hi, I apologise for the late reply. I wasn't at my computer for the past week. 2015-08-19 21:08 GMT+02:00 Роман Донченко d...@corrigendum.ru: Currently, the only case is for simple variable values (not containing any CMake-special characters and not determined by CPack itself). In CPackRPM

Re: [cmake-developers] [CPack] CPackDeb and fakeroot

Hi, I see that I'm a bit late to the party... Wasn't at my computer for the past few days. Now if you find a way to set root ownership in archive created by CPackDeb then every deb package will have those right. Again two solutions: - using system tar with the proper uid/gid options -

Re: [cmake-developers] [PATCH] Add a test for checking that the CPack module produces correct config files

> My motivation is this. I want to submit a few improvements to the way CPack > writes config files, starting with that cpack_set_if_not_set change I > mentioned a while back. This functionality is generator-independent (and > basically unrelated to actual package generation), so I thought >

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

>> I just realized that the permissions for the extra control files should >> be set in a different way than for the md5sum checksum file. >> >> Please find attached the patch correcting this and the corresponding >> test that fires the problem. Thanks, applied the fix:

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

> Thank you. However those two test are not mutually exclusive. I think having > them on lintian is also a good thing. I've tried your test change before but lintian test complained that 775 are invalid permissions (should be 755). Is this caused by a different version of lintian or should I just

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

> I have made the following changes in order to: > - support the UID/GID/UNAME/GNAME and permission on tar files at creation > time > - using directly libarchive in CPackDeb > - removing completely the need of fakeroot Applied to next for testing:

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

2015-09-14 23:49 GMT+02:00 Raffi Enficiaud <raffi.enfici...@mines-paris.org>: > Le 14/09/15 23:34, Domen Vrankar a écrit : >>> >>> Thank you. However those two test are not mutually exclusive. I think >>> having >>> them on lintian is also a good thing

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

> From this (thanks to lintian now I have the proper link :) ) > > https://lintian.debian.org/tags/control-file-has-bad-permissions.html > https://www.debian.org/doc/debian-policy/ch-files.html#s-permissions-owners > > all control files: > - should be owned by root:root (+ I would say uid/gid 0/0,

Re: [cmake-developers] [CPackDeb][libarchive] removing use of fakeroot and supporting UID/GID/UNAME etc in libarchive

> Please find attached the "feature" based onto 68dba7f. I added the variable > CPACK_DEBIAN_PACKAGE_CONTROL_STRICT_PERMISSION and its component counterpart > for controlling strict behaviour on the files added to control.tar.gz . Thanks, applied and squashed patches with some changes to

Re: [cmake-developers] [PATCH] CPack: don't mangle CMake-special characters when applying default settings

2015-09-03 22:00 GMT+02:00 Роман Донченко : > By using a function to do it instead of a macro. Deprecate the old macro, > but keep it for backwards compatibility. Remove existing workarounds for this > problem and add a test. Applied with minor changes to next for testing:

Re: [cmake-developers] [PATCH] CPack: add a new setting, CPACK_VERBATIM_VARIABLES

2015-09-20 20:03 GMT+02:00 Роман Донченко : > If it's set to a true value, CPack will escape all variables for the CMake > parser when writing them out to configuration files. This parallels the > VERBATIM argument to add_custom_command. > > The cpack_encode_variables macro is

Re: [cmake-developers] [CPack][BUG] Fail to package with CPACK_INSTALLED_DIRECTORIES

2015-09-23 17:00 GMT+02:00 CHEVRIER, Marc : > Any comments about this problem? Sorry I've forgotten about this mail... From what you're describing it should work. I'll take a look later today and get back to you then. Thanks, Domen -- Powered by www.kitware.com Please

Re: [cmake-developers] [CPackDeb] empty directories in packages

> I was looking at this issue > http://public.kitware.com/Bug/view.php?id=13009 > > and apparently it is not possible to install empty directories (I just > tested). > > I believe that it should be possible to do that (even if there are better > ways like postinst). > What is your opinion? I

Re: [cmake-developers] [CPackDeb] empty directories in packages

> You left a commented out line in Source/CPack/cmCPackGenerator.cxx. Hm that should not be there. I'll delete it when I get to my PC. Thanks, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers

Re: [cmake-developers] [CPackDeb] use of internal md5sum function

> Please find attached a patch on CPackDeb > - which calls the internal function for md5sum computation > - which prevents the hash of the symlinks > > I believe this fixes the issue (partially or totally) > > https://public.kitware.com/Bug/view.php?id=13386 > Applied with minor changes to

Re: [cmake-developers] [CPack][BUG] Fail to package with CPACK_INSTALLED_DIRECTORIES

2015-09-24 9:06 GMT+02:00 Domen Vrankar <domen.vran...@gmail.com>: > 2015-09-23 17:00 GMT+02:00 CHEVRIER, Marc <marc.chevr...@sap.com>: >> Any comments about this problem? There was a bug in file creation time handling. Fix is in cmake git repository on next branch: http

Re: [cmake-developers] [CPackRPM] Configure RPM package group and name per component

2015-11-17 9:18 GMT+01:00 Domen Vrankar <domen.vran...@gmail.com>: > 2015-11-15 20:32 GMT+01:00 Markus Rickert <rick...@fortiss.org>: >> Hi, >> >> similar to the previous patch for CPackDeb, the attached patch adds >> component-specific settin

Re: [cmake-developers] Productbuild CPack generator

> Does anyone here know if we have test coverage already for some cpack > generators where we create a package, then unpack it to verify the results? > Tests/CPackComponentsDEB (Deb), Tests/CPackComponentsForAll (RPM) and tests in Tests/RunCMake/CPack (at the moment Deb, RPM, TGZ) all verify

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

As a workaround you could set files that you would like to be excluded from symlink relocation with CPACK_RPM_USER_FILELIST or CPACK_RPM__USER_FILELIST. I'll have a look at how this could be solved for later versions of CPack. Do I understand correctly that those errors occur when a symlink is

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

> I just tried, it seems to do the trick. An example source setup that was > breaking the RPM building before, is now functioning seemingly correctly. The > produced RPM gets the symlink, pointing at the location outside of the > package. > > I would actually prefer if the code printed a

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

/atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/nightlies/experimentalWebArea/nicos_web_areaCMAKE64BS6G49AnlOpt/NICOS_Log_rel_4/nicos_rpm_build.html > > Cheers, >Attila > >> On 23 Mar 2016, at 15:57, Domen Vrankar <domen.vran...@gmail.

Re: [cmake-developers] Make CPACK_RPM_PACKAGE_RELEASE match Fedora/RHOS/CentOS recommended behaviour

Sorry for the late reply. Here is another go. I have added a 3rd variable but I think it means that > current behaviour is continued and your input (thanks Dolf and Romen) has > been addressed. > > https://github.com/hm1992/CMake/commit/2f54442388ab767f60fcb8cde1db2236ae535080 > I'm somewhat

  1   2   >