Hi,
I would like to propose two new modules for inclusion in CMake:
FindOpenCL to find OpenCL and FindHg for Mercurial (see attached.)
FindOpenCL is written in similar spirit to FindOpenGL, while FindHg is
basically the equivalent of FindSubversion for Mercurial.
The modules have been tested on
Cheers,
Matthäus
On 08.02.2014 14:59, Rolf Eike Beer wrote:
Am Samstag, 8. Februar 2014, 14:28:37 schrieb Matthäus G. Chajdas:
Hi,
I would like to propose two new modules for inclusion in CMake:
FindOpenCL to find OpenCL and FindHg for Mercurial (see attached.)
FindOpenCL is written in similar
, 8. Februar 2014, 16:38:02 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for taking a look. I've changed the module accordingly. Is there
a recommendation whether to use HG_ or Hg_ as the prefix for the variables?
As I guess there will be a bit back forth here, I've also pushed them
:
Am Samstag, 15. Februar 2014, 18:54:47 schrieb Stephen Kelly:
Rolf Eike Beer wrote:
Matthäus G. Chajdas wrote:
Hi Eike,
all right, then Hg, as it's FindHg, unless there is a naming policy I'm
not aware of. I was just confused a bit due to FindGit, which uses GIT_
as the prefix.
How do I
Hi,
couldn't find it in the documentation either :(
I've changed it to OPENCL_VERSION_STRING. Should I apply for commit
access now?
Cheers,
Matthäus
On 16.02.2014 20:10, Rolf Eike Beer wrote:
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks
Sonntag, 16. Februar 2014, 20:26:22 schrieb Matthäus G. Chajdas:
Hi,
couldn't find it in the documentation either :(
Help/manual/cmake-developer.7.rst
I've changed it to OPENCL_VERSION_STRING.
Should be OpenCL_VERSION_STRING: the variables should follow the casing of
the
module name
ready for acceptance, and if so, who is the person to ask for
commit access, or is there something left to fix?
Cheers,
Matthäus
On 16.02.2014 22:11, Stephen Kelly wrote:
Rolf Eike Beer wrote:
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
Hi Eike,
thanks for reviewing
be definitely helpful for first-time contributers like me to
have a rough indication how fast the process goes. Is there something
else I can do to speed up the process?
Cheers,
Matthäus
On 19.02.2014 16:30, Brad King wrote:
On 02/17/2014 02:27 PM, Matthäus G. Chajdas wrote:
As I said
Hi,
So, I'm very sorry to come up with those things now and not having catched
them earlier. If you now do
no problem, I should have also checked what I was adding with git :/
I think I fixed everything now in my latest commit. At least `git diff
origin/master Modules/FindHg.cmake` looks
Hi Brad,
thanks for splitting the patches the review. I've just pushed the
requested changes to the add-FindOpenCL topic.
If there is still something missing, please drop me a line; I appreciate
your patience with a new contributor!
Cheers,
Matthäus
On 25.02.2014 17:36, Brad King wrote:
Hi
Hi,
I've just tried my FindOpenCL Module in cmake-next, and with 3.0, it
doesn't work as expected (on Windows)
Before I submit the fix, I wanted to check back that I was indeed doing
it wrong before.
In my find_path, I used the following call:
find_path(OpenCL_INCLUDE_DIR
NAMES
CL/cl.h
Hi,
I've pushed an add-FindVulkan topic branch which adds a module to search
for the Vulkan graphics API (https://www.khronos.org/vulkan/).
I'm also happy to maintain this going forward.
The complete diff can be found here:
Thanks a lot! I've pushed a squashed commit which does everything in one
go, and merged it into next.
Cheers,
Matthäus
Am 06.06.2016 um 17:22 schrieb Brad King:
> On 06/06/2016 11:09 AM, Matthäus G. Chajdas wrote:
>> thanks a lot. Is this make test or is there something speci
Hi Brad,
thanks a lot. Is this make test or is there something special needed to
get the ModuleNotices? make test is super-slow, I wonder if there's a
faster way to get to the relevant test.
Cheers,
Matthäus
Am 06.06.2016 um 15:36 schrieb Brad King:
> On 06/04/2016 02:54 PM, Matthäu
Thanks!
Cheers,
Matthäus
Am 02.06.2016 um 15:44 schrieb Brad King:
> On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote:
>> done - I had to squash and force push once more, because I used the
>> wrong author in the first commit.
>>
>> Everything is now in one commit
Hi Brad,
updated to latest master and pushed again (I merged latest master into
this - is that fine or does it have to be a rebase? In that case I'll redo.)
Cheers,
Matthäus
Am 01.06.2016 um 17:18 schrieb Brad King:
> On 05/31/2016 03:17 PM, Matthäus G. Chajdas wrote:
>> I've just pu
,
Matthäus
Am 01.06.2016 um 20:22 schrieb Brad King:
> On 06/01/2016 02:15 PM, Matthäus G. Chajdas wrote:
>> Hopefully done
>
> The revised history looks good. The change itself looks good.
>
> Please also add a `Help/release/dev/FindOpenCL-imported-target.rst`
>
Hopefully done - I'm not the biggest git expert but the history looks
like I'd expect it to look like :)
Cheers,
Matthäus
Am 01.06.2016 um 19:57 schrieb Brad King:
> On 06/01/2016 01:53 PM, Matthäus G. Chajdas wrote:
>> updated to latest master and pushed again (I merged late
Hi,
I've just pushed "add-opencl-imported-target" which adds an imported
target to FindOpenCL. The whole change is rather small:
https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=6c53137a19e482140db3dc97b626af38348f2c71
Good to merge this to next for testing?
Cheers,
Matthäus
--
Hi Jerry,
thanks for giving it a spin :)
I don't have a Mac to test myself - as your changes are confined to
macOS, they look safe to me.
The version is not listed as a required variable, so that's why it
passes through. If you pass in a version into your find_package call, it
should bail out
something on macOS?
> You are right _DIR and _DIRS are working.
> I think I only changed it because for example FindGLUT uses it, for the
> library the singular variant LIBRARY is used and I
> don't understand the difference of _DIR and _DIRS :)
>
> Jerry
>
> On 01.08.2016
Here we go:
https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=48dc6343bba3b3f296d35ab060681c50f0eb8cde
Thanks again for the patch!
Cheers,
Matthäus
Am 05.08.2016 um 22:09 schrieb Matthäus G. Chajdas:
> Hi,
>
> all right. Yes, that sounds like
22 matches
Mail list logo
