Re: [cmake-developers] Moc-test errors

2019-06-06 Thread Sebastian Holtermann
BTW, with todays compilation (master branch) also some qt4-moc-tests are failing. This starts to be itching ... # ctest -R Autogen.Moc ... The following tests FAILED: 577 - Qt5Autogen.MocIncludeRelaxed (Failed) 578 - Qt5Autogen.MocIncludeStrict (Failed) 579 -

Re: [cmake-developers] Moc-test errors

2019-06-06 Thread Sebastian Holtermann
The following tests FAILED: 577 - Qt5Autogen.MocIncludeRelaxed (Failed) 578 - Qt5Autogen.MocIncludeStrict (Failed) 579 - Qt5Autogen.MocSkipSource (Failed) Errors while running CTest Okay, it looks like SKIP_AUTOMOC doesn't work properly. Can you please post the output of - `ctest -R

Re: [cmake-developers] Moc-test errors

2019-06-04 Thread Sebastian Holtermann
Sure, rebuild_cache was the first I tried. The test-errors remain even in the master tree of today. Performing now on a clean build ... #ctest -R Qt5Autogen.Moc Test project /BUILD/BUILDMint18/BuildCmakeGit Guessing configuration NoConfig Start 553: Qt5Autogen.MocOnly 1/8 Test #553:

Re: [cmake-developers] CMake 3.13 - Generated moc files not added to VStudio solution

2019-05-17 Thread Sebastian Holtermann
Am 16.05.19 um 20:43 schrieb Venedict Tchistopolskii: Hey again, just checking in. Has this been solved with a better solution/etc.? .-. VT AFAIK setting source file properties on files that get tagged GENERATED later has been fixed by this commit:

Re: [cmake-developers] No more emails from gitlab.kitware.com

2019-04-15 Thread Sebastian Holtermann
after changing my account (@sebholt) password in gitlab.kitware.com, I don't get any emails from it anymore. Login and everything web based works, but no emails. Did something change there? Verify that your email address is still as expected. Also visit

[cmake-developers] No more emails from gitlab.kitware.com

2019-04-15 Thread Sebastian Holtermann
Hi, after changing my account (@sebholt) password in gitlab.kitware.com, I don't get any emails from it anymore. Login and everything web based works, but no emails. Did something change there? --Sebastian -- Powered by www.kitware.com Please keep messages on-topic and check the CMake

Re: [cmake-developers] Source code ///! comments

2019-03-26 Thread Sebastian Holtermann
Looking through the source code I found various comments starting with "///!" If Doxygen is targeted, the comment should start with either "///" or "//!". It's likely a typo. For reference, I personally prefer `/** */`. Okay, then why not do a cleanup that replaces "///!" with "//!"? I'll

[cmake-developers] Source code ///! comments

2019-03-26 Thread Sebastian Holtermann
Looking through the source code I found various comments starting with "///!" E.g.: ``` ///! myFunction description myFunction() ``` To my blame, I've use it as well. But is this a valid meta notation? If Doxygen is targeted, the comment should start with either "///" or "//!". When the

Re: [cmake-developers] CMake 3.13 - Generated moc files not added to VStudio solution

2019-01-31 Thread Sebastian Holtermann
> Any luck? I can try helping ya trace it if you need it. > I traced this down to some degree. The problem arises from the handling of file path for GENERATED vs non GENERATED files. When the full path for a file is computed in cmSourceFile and the file doesn't exist (mocs_compilation.cpp

Re: [cmake-developers] CMake 3.13 - Generated moc files not added to VStudio solution

2019-01-30 Thread Sebastian Holtermann
Hello Venedict, I took a look at this again, thanks for the additional information. In fact this isn't VS specific. I was able to reproduce the issue using Linux/Makefiles. > Got the fix, hopefully it can be merged in :) >

Re: [cmake-developers] Undocumented CMAKE_AUTOMOC_RELAXED_MODE changes in 3.13

2019-01-28 Thread Sebastian Holtermann
Am Samstag, 26. Januar 2019, 03:27:08 CET schrieb Venedict Tchistopolskii: > Actually, debugged a lot more and found this! > > The first CMake generation pass: Generates but no inclusion > > > > *Forcing a second pass makes it include the newly generated moc'* > It says *"AutoMoc: Generating

Re: [cmake-developers] Undocumented CMAKE_AUTOMOC_RELAXED_MODE changes in 3.13

2019-01-25 Thread Sebastian Holtermann
Am Freitag, 25. Januar 2019, 17:36:22 CET schrieb Venedict Tchistopolskii: > When updating the project CMake from 3.12 to 3.13, > *CMAKE_AUTOMOC_RELAXED_MODE* stops including certain generated moc files. > > Had to switch to *CMAKE_AUTOMOC *to get them included.strange > functionality on the

Re: [cmake-developers] kwsysProcess threadsafety

2018-01-08 Thread Sebastian Holtermann
On Montag, 8. Januar 2018 06:56:57 CET Brad King wrote: > On 01/06/2018 02:31 AM, Sebastian Holtermann wrote: > >>> 2) Use libuv instead > > > > I just saw the libuv library in the CMake sources. > > > >> libuv for process management is on the list. I t

Re: [cmake-developers] kwsysProcess threadsafety

2018-01-05 Thread Sebastian Holtermann
> > 2) Use libuv instead I just saw the libuv library in the CMake sources. > libuv for process management is on the list. I think it is waiting for > porting to all of CMake's platforms to actually happen. Does that mean it's only there for some specific scenarios and shouldn't be used in

Re: [cmake-developers] kwsysProcess threadsafety

2018-01-05 Thread Sebastian Holtermann
On Freitag, 5. Januar 2018 13:00:30 CET clin...@elemtech.com wrote: > Cool. I'd like to have parallel automoc and uic. > > How about this 4th option? > Don't use threads. A single thread is able to spawn multiple processes, and > wait on multiple processes, and react when 1 or more processes

[cmake-developers] kwsysProcess threadsafety

2018-01-05 Thread Sebastian Holtermann
Hello! As you might have noticed I tried to parallelize AUTOMOC/UIC. https://gitlab.kitware.com/cmake/cmake/merge_requests/1632 The issue that's blocking it now is that the kwsysProcess framework isn't thread safe. As a consequence it is not possible for threads to start processes concurrently

Re: [cmake-developers] CMP0071

2017-10-05 Thread Sebastian Holtermann
> I find myself setting SKIP_AUTOUIC on *.h and *.cpp files to silence > CMP0071 warnings. It's an unfortunate situation. In many cases (qt < 5.10) it might work to just let AUTOUIC probe the (moc/uic/rcc) GENERATED files as well by setting `cmake_policy(SET CMP0071 NEW)` -- Powered by

Re: [cmake-developers] CMP0071

2017-10-05 Thread Sebastian Holtermann
On Mittwoch, 4. Oktober 2017 20:01:50 CEST clin...@elemtech.com wrote: > - On Sep 26, 2017, at 9:07 AM, Sebastian Holtermann sebl...@xwmw.org wrote: > >> I updated and I'm getting this: > >> > >> CMake Warning (dev) in claro/navigation5/CMakeLists.txt: >

Re: [cmake-developers] CMP0071

2017-10-02 Thread Sebastian Holtermann
On Montag, 2. Oktober 2017 06:58:31 CEST Brad King wrote: > On 09/26/2017 12:55 PM, clin...@elemtech.com wrote: > > https://bugreports.qt.io/browse/QTBUG-63442 > > Please take a look at the proposed fix: > > https://codereview.qt-project.org/#/c/207327/ I dropped a few comments. -Sebastian

Re: [cmake-developers] CMP0071

2017-09-27 Thread Sebastian Holtermann
On Dienstag, 26. September 2017 11:49:18 CEST Brad King wrote: > On 09/26/2017 11:15 AM, Sebastian Holtermann wrote: > > "cmake --help-policy CMP0071" already mentions SKIP_AUTOMOC. > > Should the warning mention SKIP_AUTOMOC as well? > > Yes, please. It rem

Re: [cmake-developers] CMP0071

2017-09-26 Thread Sebastian Holtermann
On Dienstag, 26. September 2017 11:49:18 CEST Brad King wrote: > On 09/26/2017 11:15 AM, Sebastian Holtermann wrote: > > "cmake --help-policy CMP0071" already mentions SKIP_AUTOMOC. > > Should the warning mention SKIP_AUTOMOC as well? > > Yes, please. It remov

Re: [cmake-developers] CMP0071

2017-09-26 Thread Sebastian Holtermann
On Dienstag, 26. September 2017 09:25:36 CEST clin...@elemtech.com wrote: > - On Sep 26, 2017, at 9:07 AM, Sebastian Holtermann sebl...@xwmw.org wrote: > >> I updated and I'm getting this: > >> > >> CMake Warning (dev) in claro/navigation5/CMakeLists.txt: >

Re: [cmake-developers] CMP0071

2017-09-26 Thread Sebastian Holtermann
On Dienstag, 26. September 2017 11:04:30 CEST Brad King wrote: > On 09/26/2017 09:32 AM, clin...@elemtech.com wrote: > > CMake Warning (dev) in claro/navigation5/CMakeLists.txt: > > Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED > > files. Run "cmake --help-policy CMP0071"

Re: [cmake-developers] CMP0071

2017-09-26 Thread Sebastian Holtermann
> I updated and I'm getting this: > > CMake Warning (dev) in claro/navigation5/CMakeLists.txt: > Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files. > Run "cmake --help-policy CMP0071" for policy details. Use the cmake_policy > command to set the policy and suppress this

Re: [cmake-developers] PRE_BUILD misconception

2017-08-24 Thread Sebastian Holtermann
Am Donnerstag, 24. August 2017, 07:48:48 CEST schrieb Brad King: > On 08/23/2017 05:56 PM, Sebastian Holtermann wrote: > > It seems that in CMake 3.9/AUTOGEN the VS generator uses the *_autogen > > target more often than necessary (it could use PRE_BUILD instead). > > > &g

Re: [cmake-developers] PRE_BUILD misconception

2017-08-23 Thread Sebastian Holtermann
It seems that in CMake 3.9/AUTOGEN the VS generator uses the *_autogen target more often than necessary (it could use PRE_BUILD instead). Let's assume a target `B` that depends on - a *GENERATED* file `FA` - a linked library `LA` - a utility target `TA` (via `add_dependencies()`) Using the VS

Re: [cmake-developers] C++11 all features available?

2017-08-23 Thread Sebastian Holtermann
> > > > it looks like C++11 is now a requirement for CMake itself. > > > > > > Yes. We just merged this: > > > https://gitlab.kitware.com/cmake/cmake/merge_requests/1132 > > > > > > but you beat us to the announcement. > > > > I saw the MR last week and was delighted. The iterator type

Re: [cmake-developers] C++11 all features available?

2017-08-21 Thread Sebastian Holtermann
Am Montag, 21. August 2017, 10:12:26 CEST schrieb Ben Boeckel: > On Mon, Aug 21, 2017 at 15:53:11 +0200, Sebastian Holtermann wrote: > > - std::array > > I don't see why not. > > > - std::basic_regex (and friends) > > Note that we require backwards compat

Re: [cmake-developers] C++11 all features available?

2017-08-21 Thread Sebastian Holtermann
Am Montag, 21. August 2017, 10:04:28 CEST schrieben Sie: > On 08/21/2017 09:53 AM, Sebastian Holtermann wrote: > > it looks like C++11 is now a requirement for CMake itself. > > Yes. We just merged this: > > https://gitlab.kitware.com/cmake/cmake/merge_requests/1132

[cmake-developers] C++11 all features available?

2017-08-21 Thread Sebastian Holtermann
Hi, it looks like C++11 is now a requirement for CMake itself. That's good news. But does this mean *all* the nice features from the std library can be used? I'm especially interested in - std::array - std::basic_regex (and friends) - std::thread (and friends) - std::atomic_flag

Re: [cmake-developers] AUTOGEN per-config sources

2017-07-18 Thread Sebastian Holtermann
Am 17.07.2017 um 16:20 schrieb Brad King: > On 07/15/2017 08:37 PM, comic fans wrote: >> recent commits shows that QtAutogen is moving to create suffixed files >> and folders for different config, but with this commit, >> my generator test failed on Qt5Autogen as following: >> >> Target

Re: [cmake-developers] Making your regular expression engine more reliable

2017-05-19 Thread Sebastian Holtermann
Am 18.05.2017 um 23:07 schrieb Domen Vrankar: > 2017-05-18 21:44 GMT+02:00 Alan W. Irwin >: > > I have just discovered a long-standing regular expression bug (see >

Re: [cmake-developers] source_group and generator expressions

2017-05-16 Thread Sebastian Holtermann
>> Would TARGETNAME_autogen/moc_compilation_$.cpp work with the >> current state of VS and XCode? The file name is pretty much unique. > > Yes, though some work would still be needed to add the right exclusion > code to Xcode. Good, I'll stick with that name then. For the rcc generated files

Re: [cmake-developers] source_group and generator expressions

2017-05-16 Thread Sebastian Holtermann
Am 16.05.2017 um 15:11 schrieb Brad King: > On 05/16/2017 05:52 AM, Sebastian Holtermann wrote: >> There are two ways to achieve this >> 1) Put TARGETNAME_autogen/$/moc_compilation.cpp >>into AUTOGEN_SOURCE_GROUP >>- Requires gen. exp. support in source_grou

[cmake-developers] source_group and generator expressions

2017-05-16 Thread Sebastian Holtermann
Hi, I'm working on a fix for https://gitlab.kitware.com/cmake/cmake/issues/16460 which requires putting a generator expression into a source group, namely $ The background is that TARGETNAME_autogen/$/moc_compilation.cpp (and others) should go into the source_group AUTOGEN_SOURCE_GROUP. There

Re: [cmake-developers] QtAutogen suggestions

2016-11-28 Thread Sebastian Holtermann
Am 28.11.2016 um 17:00 schrieb Brad King: > On 11/28/2016 10:25 AM, Sebastian Holtermann wrote: >> I'm going ahead then. > > Thanks. BTW, please sign up for a gitlab.kitware.com account > (optionally via GitHub OAuth) so that we can include you in > discussion of related

Re: [cmake-developers] QtAutogen suggestions

2016-11-28 Thread Sebastian Holtermann
Am 28.11.2016 um 15:57 schrieb Brad King: > On 11/25/2016 05:37 PM, Sebastian Holtermann wrote: >> There are some issues with QtAutogen that still bother me and >> that I would like to change. > > Great! We currently have no dedicated maintainer for it and I have &

[cmake-developers] QtAutogen suggestions

2016-11-25 Thread Sebastian Holtermann
Hi. There are some issues with QtAutogen that still bother me and that I would like to change. 1) Most files get generated in ${CMAKE_CURRENT_BINARY_DIR}/${TARGETNAME}_automoc.dir Is the ".dir" suffix neccessary? I think is should be removed. 2) Moc files that are manually included by a

Re: [cmake-developers] Current deficiencies of automoc

2016-11-14 Thread Sebastian Holtermann
Am 14.11.2016 um 12:41 schrieb Alan W. Irwin: > On 2016-11-14 09:06+0100 Sebastian Holtermann wrote: > >> What probably could be done is to add >> ${CMAKE_BINARY_DIR}/${TARGETNAME}_automoc.dir >> to the INCLUDE_DIRECTORIES of the target and then generate all >> #incl

Re: [cmake-developers] Current deficiencies of automoc

2016-11-14 Thread Sebastian Holtermann
Am 13.11.2016 um 07:48 schrieb Alan W. Irwin: > On 2016-10-22 19:49+0200 Sebastian Holtermann wrote: > > [...] >> Actually I made an implementation in 3.6.0 that generated the moc files >> in the a build tree subdirectory correspoding to the header path. >> But th

Re: [cmake-developers] Current deficiencies of automoc

2016-10-22 Thread Sebastian Holtermann
Am 21.10.2016 um 13:39 schrieb Alan W. Irwin: On 2016-10-21 09:42+0200 Sebastian Holtermann wrote: [...] Hi! I tried your example. It isn't complete, test_q_object.h needs an #include and a constructor/destructor definition, e.g.: MyClass(QObject *parent = 0) {;} ~MyClass(){;} Hi

Re: [cmake-developers] Current deficiencies of automoc

2016-10-21 Thread Sebastian Holtermann
Am 21.10.2016 um 01:29 schrieb Alan W. Irwin: On 2016-10-20 15:08-0400 Brad King wrote: Please construct a minimal/complete example source tree/tarball that demonstrate the layout you'd like to have work. That will be helpful in constructing such a bug report. OK. I have attached the

Re: [cmake-developers] QtAutogen: Patches to allow empty .qrc files

2016-09-30 Thread Sebastian Holtermann
Am 30.09.2016 um 16:17 schrieb Brad King: On 09/30/2016 05:38 AM, Sebastian Holtermann wrote: Here are some small patches that fix the issue and add a test case. Thanks. I've applied the patches with minor tweaks: QtAutogen: Allow .qrc files that do not contain any file reference https

Re: [cmake-developers] QtAutogen: Use Base32 instead of Base64 for file names

2016-09-01 Thread Sebastian Holtermann
Am 30.08.2016 um 16:53 schrieb Brad King: On 08/28/2016 10:00 AM, Sebastian Holtermann wrote: Base32 is a better choice IMO because it is single case and does not generate disruptive characters like '_', '-' or '/'. Here are two patches that replace Base64 with Base32. Thanks. Please revise

[cmake-developers] QtAutogen: Use Base32 instead of Base64 for file names

2016-08-28 Thread Sebastian Holtermann
Hello again. I think there are some issues when using Base64 checksum for filenames. - They look weird/ugly with random cases an '_' and '-' characters mixed in - On cases insensitive filesystems mixed case names may cause problems (e.g. undetected name collisions) Base32 is a better

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-15 Thread Sebastian Holtermann
Am 10.08.2016 um 19:33 schrieb Brad King: On 08/10/2016 06:15 AM, Sebastian Holtermann wrote: These patches change the private abstract interface of cmCryptoHash to return std::vector instead of std::string. Conversion to std::string is handled by a static public method. Nice. I've added

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-10 Thread Sebastian Holtermann
Okay. Please look at extending cmCryptoHash to offer access to the _Final functions to get the binary digests directly as `std::vector` or something like that. That will avoid the binary->hex->binary conversion sequence before going to Base64. Also, please explain the motivation in comments.

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-09 Thread Sebastian Holtermann
Am 09.08.2016 um 17:52 schrieb Brad King: On 08/09/2016 11:45 AM, Sebastian Holtermann wrote: In the non-unique-qrc-name case the checksum is hard to reproduce for a user. In this case I'd say CMake does not make any guaratees for - the actual symbol name - the symbol name to not change

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-09 Thread Sebastian Holtermann
Am 09.08.2016 um 16:11 schrieb Brad King: On 08/08/2016 04:19 PM, Sebastian Holtermann wrote: It is back to what it was in 3.5 for the all-qrc-names-unique case. So yes, existing projects get the same symbol name they used to get. Good, thanks. New projects that now can use non unique file

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-08 Thread Sebastian Holtermann
Am 08.08.2016 um 19:40 schrieb Brad King: On 08/06/2016 09:42 AM, Sebastian Holtermann wrote: Ok, here is a new set of patches based on the current git master branch. Thanks! +outStream << "#include \"" + << cmsys::SystemTools::Con

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-08-06 Thread Sebastian Holtermann
Am 02.08.2016 um 19:09 schrieb Brad King: On 07/31/2016 03:56 PM, Sebastian Holtermann wrote: I have updated the patch for CMake 3.6.0 to fix https://gitlab.kitware.com/cmake/cmake/issues/16209 Here is an updated patch. Thanks. However, it is too late to restore this change for the 3.6

Re: [cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-07-31 Thread Sebastian Holtermann
Am 31.07.2016 um 18:49 schrieb Sebastian Holtermann: Hi, I have updated the patch for CMake 3.6.0 to fix https://gitlab.kitware.com/cmake/cmake/issues/16209 This patch introduces a new class cmFilePathUuid which is used in QtAutogen to generated unique filenames. The name generation algorithm

[cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

2016-07-31 Thread Sebastian Holtermann
rom ccdfb4f132ed3a1ddbbff466d885b4f63a178a2e Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Tue, 26 Jul 2016 16:39:12 +0200 Subject: [PATCH] QtAutogen fix for too deep nested directory generation. Instead of generating moc_* and qrc_* files in subdirectories tha

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Am 27.07.2016 um 19:31 schrieb Ben Boeckel: On Wed, Jul 27, 2016 at 17:49:40 +0200, Sebastian Holtermann wrote: Is there an error exit function in CMake? Or just exit(-1); Here's an example I found: this->Makefile->IssueMessage( cmake::INTERNAL_ERROR, "fileFo

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Am 27.07.2016 um 17:49 schrieb Sebastian Holtermann: Doing so I found that Base64 allows '+' and '/' as characters which is bad for directory names obviously. For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why they are used

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Doing so I found that Base64 allows '+' and '/' as characters which is bad for directory names obviously. For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why they are used) since 'A' and 'B' are already characters in Base64.

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Sebastian Holtermann
gets wider use using Base58 might be a better choice. But it is not available in CMake, yet. -Sebastian >From 21c8b1f478c598c244cebab8f6f60956ecc51de0 Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Tue, 26 Jul 2016 16:39:12 +0200 Subject: [PATCH] QtAutogen fix fo

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Sebastian Holtermann
>From 3cdb41e57e45ae145066b18a00aac53c9801b332 Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Tue, 26 Jul 2016 16:39:12 +0200 Subject: [PATCH] QtAutogen fix for too deep nested directory generation. Instead of generating moc_* and qrc_* files in subdi

Re: [cmake-developers] Autogen subdirectories patches

2016-07-21 Thread Sebastian Holtermann
Am 21.07.2016 um 17:40 schrieb Brad King: On 04/22/2016 09:37 AM, Brad King wrote: The rest of the changes are now in 'master'. Thanks for working on this! Unfortunately I've had to revert some of these changes due to regressions they cause. See issue here:

[cmake-developers] Autogen message cleanups

2016-04-24 Thread Sebastian Holtermann
Two more autogen patches with message cleanups/tweaks. -Sebastian >From 0c044ee28d3c27c380e7c9bf6ab3978746ed4049 Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Sun, 24 Apr 2016 15:00:26 +0200 Subject: [PATCH 1/2] Autogen: Message cleanups: Compose message

Re: [cmake-developers] Autogen subdirectories patches

2016-04-23 Thread Sebastian Holtermann
Am 22.04.2016 um 15:37 schrieb Brad King: On 04/21/2016 03:14 AM, Sebastian Holtermann wrote: Thanks! I've applied them locally and merged the cleanup/refactoring commits to 'next' for testing first. Once those test cleanly I'll move on to the rest. It is good too see the patches made

Re: [cmake-developers] Autogen subdirectories patches

2016-04-21 Thread Sebastian Holtermann
Am 19.04.2016 um 19:28 schrieb Brad King: On 04/19/2016 11:09 AM, Sebastian Holtermann wrote: https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories

Re: [cmake-developers] Autogen subdirectories patches

2016-04-19 Thread Sebastian Holtermann
Am 19.04.2016 um 19:28 schrieb Brad King: On 04/19/2016 11:09 AM, Sebastian Holtermann wrote: https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories

[cmake-developers] Autogen subdirectories patches

2016-04-19 Thread Sebastian Holtermann
Hello again, I've prepared a set of patches that address https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories to support sources with the name in

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-16 Thread Sebastian Holtermann
Am 14.04.2016 um 23:06 schrieb Sebastian Holtermann: These two hunks look like error checks added to the existing logic. Please split these out into preceding commits with their own messages explaining the new errors. Please also include a Help/release/dev/automoc-diagnostics.rst file

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-14 Thread Sebastian Holtermann
. Wow, this turned into a git learning session for me. Git is as awesome as it is hard. I've split the patch into three as suggested. -Sebastian >From 22f5af6aef69adc784287fb20357a98558966443 Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Thu, 14 Apr 2016 18:30

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-14 Thread Sebastian Holtermann
Am 13.04.2016 um 16:40 schrieb Brad King: On 04/13/2016 10:08 AM, Sebastian Holtermann wrote: Well, looking into the sources and there is already Tests/QtAutogen. It covers various #include "moc_..." cases. Perhaps, but as pointed out in the issue tracker entry I linked those test

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-13 Thread Sebastian Holtermann
Am 13.04.2016 um 16:40 schrieb Brad King: On 04/13/2016 10:08 AM, Sebastian Holtermann wrote: Well, looking into the sources and there is already Tests/QtAutogen. It covers various #include "moc_..." cases. Perhaps, but as pointed out in the issue tracker entry I linked those test

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-13 Thread Sebastian Holtermann
Am 13.04.2016 um 16:40 schrieb Brad King: On 04/13/2016 10:08 AM, Sebastian Holtermann wrote: Well, looking into the sources and there is already Tests/QtAutogen. It covers various #include "moc_..." cases. Perhaps, but as pointed out in the issue tracker entry I linked those test

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-13 Thread Sebastian Holtermann
Am 12.04.2016 um 21:26 schrieb Brad King: On 04/12/2016 03:12 PM, Sebastian Holtermann wrote: Here it is. Please review/commit. To test it insert #include "moc_item.cpp" in any or many of the item.cpp files of the attached test project. Thanks for working on this! As requested in

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-12 Thread Sebastian Holtermann
Am 12.04.2016 um 17:40 schrieb Sebastian Holtermann: Am 12.04.2016 um 13:43 schrieb Sebastian Holtermann: Sorry for the noise. I've stumbled over bug https://cmake.org/Bug/view.php?id=12873 a few times now since I like to use same named data/view classes. I've prepared a fix that generates

Re: [cmake-developers] Automoc same source - More thoughts

2016-04-12 Thread Sebastian Holtermann
Am 12.04.2016 um 13:43 schrieb Sebastian Holtermann: Sorry for the noise. I've stumbled over bug https://cmake.org/Bug/view.php?id=12873 a few times now since I like to use same named data/view classes. I've prepared a fix that generates all moc_xxx.cpp files in the foo_automoc.dir

Re: [cmake-developers] Automoc same source name fix (proposal)

2016-04-12 Thread Sebastian Holtermann
Am 12.04.2016 um 11:57 schrieb Sebastian Holtermann: Oops, moc_item.cpp it is. For the attached test case you end up with foo_automoc.cpp -- As before but includes sources below foo_automoc.dir/data/moc_item.cpp foo_automoc.dir/view/moc_item.cpp foo_automoc.dir/moc_item.cpp -- Powered

[cmake-developers] Automoc same source name fix (proposal)

2016-04-12 Thread Sebastian Holtermann
Sebastian Holtermann >From cf51dcf0af4744fbb40e3bb5ad253d2514325148 Mon Sep 17 00:00:00 2001 From: Sebastian Holtermann <sebh...@xwmw.org> Date: Tue, 12 Apr 2016 10:47:49 +0200 Subject: [PATCH] Automoc: Create moc files below foo_automoc.dir with respect to the source header pr