On 11/03/14 14:51, Brad King wrote:
Please add test cases for the FindPkgConfig interface and argument
parsing errors. The test can just fake the location of pkg-config
with a dummy if necessary.
I added some unit test. I'm not done yet, but I would like to see if it
works on all the
On 03/13/2014 02:54 PM, Daniele E. Domenichelli wrote:
I added some unit test. I'm not done yet, but I would like to see if it
works on all the architectures... Can I merge it to next to check the
results on the dashboard? I will obviously take care to fix the errors
tomorrow...
Yes. It
On 03/10/2014 10:38 AM, Brad King wrote:
Thanks. Now the docs look good too. Please rebase on master
and merge to 'next' for testing.
Please add test cases for the FindPkgConfig interface and argument
parsing errors. The test can just fake the location of pkg-config
with a dummy if
On 11/03/14 14:51, Brad King wrote:
Also the hunks:
+if(UNIX)
+ string(REPLACE \\: ; _path ${_path})
+endif()
should not be necessary because TO_CMAKE_PATH already does that.
It looks like TO_NATIVE_PATH does not do the reveres though so that
explicit
On 03/11/2014 10:43 AM, Daniele E. Domenichelli wrote:
It is a quite common use case to get and set path environment
It is not very common within CMake's own modules:
$ git grep TO_NATIVE_PATH v3.0.0-rc1 -- Modules |wc -l
2
$ git grep TO_CMAKE_PATH v3.0.0-rc1 -- Modules |wc -l
24
# (and 6
On 03/06/2014 08:15 PM, Daniele E. Domenichelli wrote:
I pushed a doc-osx-path-variables topic to the stage to document
these variables. You may rebase on that to reference them.
Rebased.
Thanks. Now the docs look good too. Please rebase on master
and merge to 'next' for testing.
Thanks,
On 03/05/2014 07:47 PM, Daniele E. Domenichelli wrote:
I noticed that the CMAKE_FRAMEWORK_PATH and CMAKE_APPBUNDLE_PATH don't
have documentation
Just leave them as inline-literals for now if there is no doc to link.
They can be added later.
Am I supposed to add documentation for the variable
On 06/03/14 17:25, Brad King wrote:
Am I supposed to add documentation for the variable
PKG_CONFIG_USE_CMAKE_PREFIX_PATH, that is checked by this patch?
It looks like you've updated the docs further to use the variable
directive. Good. Do you mind flipping the order of the patches
to
On 03/06/2014 01:22 PM, Daniele E. Domenichelli wrote:
For now I reverted the order, but I'm still using the same checks and
logic from GNUInstallDirs. Should I change it and use
FIND_LIBRARY_USE_LIB64_PATHS instead?
Yes, I think so, because GNUInstallDirs is about install destinations
and
On 03/06/2014 01:22 PM, Daniele E. Domenichelli wrote:
On 06/03/14 17:25, Brad King wrote:
revise the documentation formatting first
Done.
Thanks. Here are a couple comments:
+.. command:: pkg_check_modules
+
+Checks for all the given modules.
The text defining the command needs to be
On 03/06/2014 11:25 AM, Brad King wrote:
On 03/05/2014 07:47 PM, Daniele E. Domenichelli wrote:
I noticed that the CMAKE_FRAMEWORK_PATH and CMAKE_APPBUNDLE_PATH don't
have documentation
Just leave them as inline-literals for now if there is no doc to link.
They can be added later.
I pushed
if (debian) add lib/arch
elseif (64 bit or unknown) add lib64
add lib
That looks good except for FIND_LIBRARY_USE_LIB64_PATHS.
Fixed. Now the logic is
if (debian) add lib/arch
elseif (FIND_LIBRARY_USE_LIB64_PATHS) add lib64
add lib
The text defining the command needs to be
On 03/04/2014 10:07 PM, Daniele E. Domenichelli wrote:
Follow up to this thread:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8369
Please review the topic FindPkgConfig_Extend-PKG_CONFIG_PATH.
Nice! Please revise the documentation to use proper cross-reference
syntax
Dear CMake developers,
Follow up to this thread:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8369
Please review the topic FindPkgConfig_Extend-PKG_CONFIG_PATH.
FindPkgConfig: Extend PKG_CONFIG_PATH using CMake variables
Use CMAKE_PREFIX_PATH, CMAKE_FRAMEWORK_PATH, and
14 matches
Mail list logo
