Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-22 Thread Brad King
On 05/21/2014 02:43 PM, Rolf Eike Beer wrote: FindQt4 already only searches QT_BINARY_DIR for the other tools, and that is all this patch is about. Okay, I've revised the commit message a bit: FindQt[34]: Prefer matching versioned tool names

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-21 Thread Stephen Kelly
Rolf Eike Beer wrote: Clinton, Stephen, inspired by what OpenBSD currently does downstream I did a patch that always searches for the plain executable names (like moc) after all versioned executable names (e.g. moc4) have been tried. I recall discussion about this kind of thing before, but

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-21 Thread Stephen Kelly
Brad King wrote: On 05/21/2014 09:18 AM, Stephen Kelly wrote: I recall discussion about this kind of thing before, but I think relating to qmake-qt4 and other versioned names. Currently qmake is preferred over qmake-qt4, but I do not know why. I found what I was remembering/referring to

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-21 Thread Clinton Stimpson
On Wednesday, May 21, 2014 10:50:42 AM Brad King wrote: On 05/21/2014 09:18 AM, Stephen Kelly wrote: I recall discussion about this kind of thing before, but I think relating to qmake-qt4 and other versioned names. Currently qmake is preferred over qmake-qt4, but I do not know why.

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-21 Thread Brad King
On 05/21/2014 11:21 AM, Stephen Kelly wrote: I found what I was remembering/referring to here: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6313/focus=6314 [snip] On 05/21/2014 11:24 AM, Clinton Stimpson wrote: Should we change FindQt4.cmake to loop over paths first,

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-21 Thread Rolf Eike Beer
Am Mittwoch, 21. Mai 2014, 09:24:34 schrieb Clinton Stimpson: On Wednesday, May 21, 2014 10:50:42 AM Brad King wrote: On 05/21/2014 09:18 AM, Stephen Kelly wrote: I recall discussion about this kind of thing before, but I think relating to qmake-qt4 and other versioned names.

Re: [cmake-developers] Please review FindQt_versioned_tools

2014-05-20 Thread Clinton Stimpson
On Tuesday, May 20, 2014 05:53:16 PM Rolf Eike Beer wrote: Clinton, Stephen, inspired by what OpenBSD currently does downstream I did a patch that always searches for the plain executable names (like moc) after all versioned executable names (e.g. moc4) have been tried. Since those tools are