Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-08 Thread Stephen Kelly
Nils Gladitz wrote: Does that work if the direct preprocessor flag -Wp,-isystem, I can't find -Wp or an equivalent in the documentation Great, thanks for checking! Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at

Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-08 Thread Nils Gladitz
On 08.02.2014 12:10, Stephen Kelly wrote: Nils Gladitz wrote: Does that work if the direct preprocessor flag -Wp,-isystem, I can't find -Wp or an equivalent in the documentation I did find /Qoption,cpp, by looking through the command line help but it doesn't seem to like -isystem either :/

[cmake-developers] Request for review of topic intel-visibility

2014-02-07 Thread Nils Gladitz
CMAKE_LANG_COMPILE_OPTIONS_VISIBILITY is being set up for the Intel compiler in general but the -fvisibility option is not supported on Windows and will result in compiler warnings. I set up the intel-visibility topic which moves the option into the Windows and Darwin specific Platform files.

Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-07 Thread Brad King
On 02/07/2014 06:05 AM, Nils Gladitz wrote: CMAKE_LANG_COMPILE_OPTIONS_VISIBILITY is being set up for the Intel compiler in general but the -fvisibility option is not supported on Windows and will result in compiler warnings. I set up the intel-visibility topic which moves the option into

Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-07 Thread Stephen Kelly
Nils Gladitz wrote: On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could use to try this task? I currently only have access to Intel on

Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-07 Thread Alexander Neundorf
On Friday, February 07, 2014 05:33:47 PM Stephen Kelly wrote: Nils Gladitz wrote: On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could

Re: [cmake-developers] Request for review of topic intel-visibility

2014-02-07 Thread Nils Gladitz
On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could use to try this task? I currently only have access to Intel on Windows which is why I