Re: [cmake-developers] Request review of new topic gcc-binutil-wrappers
On 01/04/2014 12:09 PM, Nils Gladitz wrote:
GCC (I think since about 4.7) provides wrappers for ar, nm and ranlib
with a gcc- name prefix (e.g. gcc-ar-4.7).
I created a topic to pick these up for CMAKE_AR, CMAKE_RANLIB and
CMAKE_NM per default if used with GCC.
These wrappers pass the --plugin option to the actual tools which is
required for link time optimization (LTO).
I haven't merged it to next yet since I am not sure if this might
break anything in existing setups.
Please wait until after Clinton's unicode topics have settled so
that you can get more isolated feedback from the dashboard.
Does anyone else have any insight or suggestions?
This hunk looks strange:
+set(COMPILER ${CMAKE_CXX_COMPILER}${CMAKE_C_COMPILER})
+get_filename_component(COMPILER_DIR ${COMPILER} DIRECTORY)
I don't think both compilers should be used at the same time :)
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request review of new topic gcc-binutil-wrappers
On 01/06/2014 04:44 PM, Brad King wrote:
Please wait until after Clinton's unicode topics have settled so that
you can get more isolated feedback from the dashboard.
Will do.
This hunk looks strange:
+set(COMPILER ${CMAKE_CXX_COMPILER}${CMAKE_C_COMPILER})
+get_filename_component(COMPILER_DIR ${COMPILER} DIRECTORY)
I don't think both compilers should be used at the same time :)
Yeah, I assumed only one is set at a time but I'll have to check that.
CMakeFindBinUtils is included by CMakeDetermineLANGCompiler.cmake.
Perhaps they could pass their language into CMakeFindBinUtils so this
and similar constructs that check variables for both languages can be
removed.
Thanks!
Nils
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Request review of new topic gcc-binutil-wrappers
GCC (I think since about 4.7) provides wrappers for ar, nm and ranlib with a gcc- name prefix (e.g. gcc-ar-4.7). I created a topic to pick these up for CMAKE_AR, CMAKE_RANLIB and CMAKE_NM per default if used with GCC. These wrappers pass the --plugin option to the actual tools which is required for link time optimization (LTO). I haven't merged it to next yet since I am not sure if this might break anything in existing setups. Does anyone else have any insight or suggestions? Nils -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
