[cmake-developers] The Borland compiler dashboard errors
I've got a fix locally in the ninja normal target generator:
std::string flags = (targetType == cmTarget::EXECUTABLE
? vars[FLAGS]
: vars[ARCH_FLAGS]);
locGtor-AddArchitectureFlags(flags,
this-GetTarget(),
this-TargetLinkLanguage,
this-GetConfigName());
if (targetType == cmTarget::EXECUTABLE) {
vars[FLAGS] = flags;
} else {
vars[ARCH_FLAGS] = flags;
}
That should fix the Borland compilers.
OK with you if I push it on top of the stage/ninja-cldeps branch? Or do you
already have something similar planned?
Thanks,
David C.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] The Borland compiler dashboard errors
On 14.06.2012 19:43, David Cole wrote:
I've got a fix locally in the ninja normal target generator:
std::string flags = (targetType == cmTarget::EXECUTABLE
? vars[FLAGS]
: vars[ARCH_FLAGS]);
locGtor-AddArchitectureFlags(flags,
this-GetTarget(),
this-TargetLinkLanguage,
this-GetConfigName());
if (targetType == cmTarget::EXECUTABLE) {
vars[FLAGS] = flags;
} else {
vars[ARCH_FLAGS] = flags;
}
That should fix the Borland compilers.
OK with you if I push it on top of the stage/ninja-cldeps branch? Or do you
already have something similar planned?
No problem. I have also looked at this, but I wasn't sure about the line number.
Which branch does the build server use?
Thanks,
David C.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] The Borland compiler dashboard errors
The Continuous dashboards check 'next' -- the Nightly dashboards snap to
'nightly' which is a snapshot of 'next' created at the nightly start time
each night...
So, after a merge to 'next' on the stage, the dashboards will pick up those
changes next time they run.
On Thu, Jun 14, 2012 at 2:39 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 14.06.2012 19:43, David Cole wrote:
I've got a fix locally in the ninja normal target generator:
std::string flags = (targetType == cmTarget::EXECUTABLE
? vars[FLAGS]
: vars[ARCH_FLAGS]);
locGtor-AddArchitectureFlags(**flags,
this-GetTarget(),
this-TargetLinkLanguage,
this-GetConfigName());
if (targetType == cmTarget::EXECUTABLE) {
vars[FLAGS] = flags;
} else {
vars[ARCH_FLAGS] = flags;
}
That should fix the Borland compilers.
OK with you if I push it on top of the stage/ninja-cldeps branch? Or do
you already have something similar planned?
No problem. I have also looked at this, but I wasn't sure about the line
number.
Which branch does the build server use?
Thanks,
David C.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/**
opensource/opensource.htmlhttp://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/**CMake_FAQhttp://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-**developershttp://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] The Borland compiler dashboard errors
OK -- I merged the change to next at the tip of the stage/ninja-cldeps
branch:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=555bda4e436435c37690aa5f31f4d254793d5b4e
On Thu, Jun 14, 2012 at 3:17 PM, David Cole david.c...@kitware.com wrote:
The Continuous dashboards check 'next' -- the Nightly dashboards snap to
'nightly' which is a snapshot of 'next' created at the nightly start time
each night...
So, after a merge to 'next' on the stage, the dashboards will pick up
those changes next time they run.
On Thu, Jun 14, 2012 at 2:39 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 14.06.2012 19:43, David Cole wrote:
I've got a fix locally in the ninja normal target generator:
std::string flags = (targetType == cmTarget::EXECUTABLE
? vars[FLAGS]
: vars[ARCH_FLAGS]);
locGtor-AddArchitectureFlags(**flags,
this-GetTarget(),
this-TargetLinkLanguage,
this-GetConfigName());
if (targetType == cmTarget::EXECUTABLE) {
vars[FLAGS] = flags;
} else {
vars[ARCH_FLAGS] = flags;
}
That should fix the Borland compilers.
OK with you if I push it on top of the stage/ninja-cldeps branch? Or do
you already have something similar planned?
No problem. I have also looked at this, but I wasn't sure about the line
number.
Which branch does the build server use?
Thanks,
David C.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/**
opensource/opensource.htmlhttp://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/**CMake_FAQhttp://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-**developershttp://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
