[cmake-developers] [CMake 0014325]: Cmake parser rejects empty items list in target_include_directories

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14325 == Reported By:Gregor Jasny Assigned To:

Re: [cmake-developers] Introducing the ${Foo_TARGETS} variable (IntroduceTARGETSVariable branch)

2013-07-31 Thread Stephen Kelly
Alexander Neundorf wrote: Comments ? If possible, I'd like to get that into 2.8.12. Note that even in KDE there isn't consensus on whether to rely on this in the non-short term: http://thread.gmane.org/gmane.comp.kde.devel.core/80233/focus=80241 I don't see any particular reason to get it

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Stephen Kelly
Brad King wrote: On 07/30/2013 09:46 AM, Stephen Kelly wrote: That is, parameters to install(TARGETS) are evaluated at export time, and otherwise the contents of the property are reproduced verbatim. Yes, I think this makes sense. The install rules run as part of the current project's

[cmake-developers] [CMake 0014326]: VS2012 generator ignores /SUBSYSTEM:WNDOWS

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14326 == Reported By:Soeren Freudiger Assigned To:

Re: [cmake-developers] Introducing the ${Foo_TARGETS} variable (IntroduceTARGETSVariable branch)

2013-07-31 Thread Brad King
On 07/31/2013 06:44 AM, Stephen Kelly wrote: Note that even in KDE there isn't consensus on whether to rely on this in the non-short term: http://thread.gmane.org/gmane.comp.kde.devel.core/80233/focus=80241 I don't see any particular reason to get it into 2.8.12. From the KDE

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Brad King
On 07/31/2013 07:53 AM, Stephen Kelly wrote: I think two things are being confused here. One is the DESTINATION for things that are installed by the current command. Eg: install(TARGETS foo RUNTIME DESTINATION bin LIBRARY DESTINATION lib ARCHIVE DESTINATION lib )

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Stephen Kelly
Brad King wrote: I've pushed a INCLUDES-DESTINATION-partial-eval topic to my clone with some ideas for it. Please let me know what you think. Are you proposing this for inclusion in 2.8.12? Yes. IMO it can wait along with the rest. As INCLUDES DESTINATION is already in master, that would

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Stephen Kelly
Brad King wrote: The bug report is about adding genex support to those destinations. Yes, it's also the one that started this thread. Do we agree that full generate-time evaluation is appropriate for these? If so then the implementation will require BUILD_TYPE conditional blocks in

[cmake-developers] target_include_directories and empty lists

2013-07-31 Thread Brad King
On 07/31/2013 09:17 AM, Stephen Kelly wrote: On 07/31/2013 03:13 PM, Brad King wrote: On 07/31/2013 09:11 AM, Stephen Kelly wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=452e58525bb1656df0a169c8a047c25837caa4cf [snip] Docs: Document that target property commands require at

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Brad King
On 07/31/2013 09:25 AM, Stephen Kelly wrote: As INCLUDES DESTINATION is already in master, that would be a behavior change, and probably need a policy. Technically that will be true for the real DESTINATION values too but I doubt anyone has installed to a path with $ in it. Since INCLUDES

Re: [cmake-developers] target_include_directories and empty lists

2013-07-31 Thread Stephen Kelly
Brad King wrote: What about the tll() version? target_link_libraries(foo PRIVATE ) seems to not be an error with master already. Changing that behavior is something I'd recommend deferring to after 2.8.12 if you want to change it. I don't feel extremely strongly about keeping it strict.

Re: [cmake-developers] FindBacktrace.cmake

2013-07-31 Thread Brad King
On 07/29/2013 12:38 PM, Vadim Zhukov wrote: 2013/7/29 Brad King brad.k...@kitware.com: Let's complete the add-cmake_reset_check_state topic first and then you can rebase the find_backtrace topic on it to use the feature. The former looks good but we'll let it run through the dashboards

Re: [cmake-developers] target_include_directories and empty lists

2013-07-31 Thread Brad King
On 07/31/2013 10:01 AM, Stephen Kelly wrote: Ok, I'll add a test for the above patch and submit that. Great, thanks! -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Stephen Kelly
Brad King wrote: So, I think for the case of INCLUDES DESTINATION, we can either decide and fix it now, or revert the change adding it for 2.8.12. Let's try to decide now and revert as a last resort. So the only reason we need partial evaluation is to leave configuration-dependent

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Brad King
On 07/31/2013 11:05 AM, Stephen Kelly wrote: Config sensitive dirs are likely more common for libraries than includes, so actually I think it would be fine to make that an error and always do full evaluation. To clarify, the no-config rule is for INCLUDES DESTINATION only, but full

Re: [cmake-developers] [CMake 0014317]: Configuration dependent install EXPORT

2013-07-31 Thread Stephen Kelly
Brad King wrote: On 07/31/2013 11:05 AM, Stephen Kelly wrote: Config sensitive dirs are likely more common for libraries than includes, so actually I think it would be fine to make that an error and always do full evaluation. To clarify, the no-config rule is for INCLUDES DESTINATION only,

[cmake-developers] [CMake 0014327]: CMAKE_CONFIG_POSTFIX For Executables

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14327 == Reported By:Ryan H. Kawicki Assigned To:

[cmake-developers] [CMake 0014328]: CMAKE_NO_BUILTIN_CHRPATH and Ninja fails

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14328 == Reported By:RolandSchulz Assigned To:

[cmake-developers] [CMake 0014329]: COMPONENT ignored when appearing after DESTINATION's

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14329 == Reported By:Andreas Pakulat Assigned To:

[cmake-developers] [CMake 0014330]: ExternalProject download error misleading if MD5 check is used

2013-07-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14330 == Reported By:RolandSchulz Assigned To: