Re: [cmake-developers] FastBuild Generator

2016-10-11 Thread Brad King
On 10/11/2016 04:27 AM, Charles Huet wrote: > CMake Error at CheckSourceTreeTest.cmake:355 (message): >test fails: local source tree non-additions: use git add before committing, >or remove the files from the source tree The purpose of the test is to fail if there are any local modificati

Re: [cmake-developers] FastBuild Generator

2016-10-11 Thread Charles Huet
> It works with Ninja for me. Are you building CMake out-of-source? Yes. The complete list of commands I used is (from a clean build dir): cmake ..\CMake -G Ninja -DCMAKE_BUILD_TYPE=Debug ninja ctest -V -R CheckSourceTree In a MSVC2012 x64 command prompt. I used the installed CMake to both config

Re: [cmake-developers] FastBuild Generator

2016-10-10 Thread Brad King
On 10/10/2016 09:39 AM, Charles Huet wrote: > * the test CMake.CheckSourceTree does not work with Fastbuild, > but I could not get it to work with Ninja either, maybe I > have an environment problem ? It works with Ninja for me. Are you building CMake out-of-source? > * the test SimpleInstal

Re: [cmake-developers] FastBuild Generator

2016-10-10 Thread Charles Huet
Hi again. I performed all the aforementioned actions, please check everything is OK for you. I have a few questions: * the test CMake.CheckSourceTree does not work with Fastbuild, but I could not get it to work with Ninja either, maybe I have an environment problem ? * the test SimpleInstall requ

Re: [cmake-developers] FastBuild Generator

2016-10-06 Thread Charles Huet
>* Please use Utilities/Scripts/clang-format.bash for > code style. This is easy to apply automatically later > so don't worry about it too much. I'll get on this soon, I like to have proper style. > * For final integration I'd like the commits to be squashed > and arranged in an organized wa

Re: [cmake-developers] FastBuild Generator

2016-10-06 Thread Brad King
On 10/06/2016 08:32 AM, Charles Huet wrote: > Do you think it is time to start the review, or should it wait > until I have 100% of the tests passing ? Thanks for the update. Generally my reviews for new features mostly look at documentation, tests, style, etc. rather than at implementation detai

Re: [cmake-developers] FastBuild Generator

2016-10-06 Thread Charles Huet
Hi, I rebased the Fastbuild generator on the latest master, and pushed my work to fastbuild-master. There are still some test fail, a few are due to an arror in manifest management, where multiple binarie's build try to write to the same manifest file at the same time (e.g. ObjectLibrary). Some i

Re: [cmake-developers] FastBuild Generator

2016-09-23 Thread Charles Huet
Sorry I pushed on fastbuild-rebase, as the rebase on master fails evento self host. I did not expect this to be merged for 3.7, as I'm not sure I'll have time to polish it enough for release. On Fri, Sep 23, 2016, 16:52 Brad King wrote: > On 09/23/2016 10:30 AM, Charles Huet wrote: > > If you w

Re: [cmake-developers] FastBuild Generator

2016-09-23 Thread Brad King
On 09/23/2016 10:30 AM, Charles Huet wrote: > If you want to take a quick glance it should be close to what you want Did you push an update to the fastbuild-master branch? It looks the same. FYI, I'd like to wait until after the Oct 3 branch for the 3.7 release before introducing changes toward

Re: [cmake-developers] FastBuild Generator

2016-09-23 Thread Charles Huet
Ok, so I will focus on windows support for now. I squashed the commits correctly, to not lose the correct authors names, and I started moving all that I could from the global generator to a target generator, and simplified a few things along the way. If you want to take a quick glance it should b

Re: [cmake-developers] FastBuild Generator

2016-09-22 Thread Brad King
On 09/22/2016 03:02 PM, Charles Huet wrote: > is linux/mac support mandatory also ? > Fastbuild does support those platforms, but the generator so far does > not work as well (or at all) on those platforms. I think it is okay to support only a subset of platforms at first. Please just make the gen

Re: [cmake-developers] FastBuild Generator

2016-09-22 Thread Charles Huet
> IIUC this refers to: > * http://fastbuild.org > * https://github.com/fastbuild/fastbuild Yes, exactly. >From a quick glance the main problem I see is that it doesn't follow the Makefile/Ninja generator model of organizing the generator code into a per-target generator. OK, so I need to make us

Re: [cmake-developers] FastBuild Generator

2016-09-22 Thread Brad King
On 09/22/2016 10:41 AM, Charles Huet wrote: > a Fastbuild generator in the works, whose development started on CMake 3.2, > and was pretty much abandonned for the past 5 months. > > I took the time to rebase it on master Thanks for reviving it. IIUC this refers to: * http://fastbuild.org * http

[cmake-developers] FastBuild Generator

2016-09-22 Thread Charles Huet
Hi, As some of you may know, there is a Fastbuild generator in the works, whose development started on CMake 3.2, and was pretty much abandonned for the past 5 months. I took the time to rebase it on master, and while there is a lot to clean up (and some stuff works worse that it used to because