Re: [cmake-developers] Request for review of topic intel-visibility
Nils Gladitz wrote: Does that work if the direct preprocessor flag -Wp,-isystem, I can't find -Wp or an equivalent in the documentation Great, thanks for checking! Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request for review of topic intel-visibility
On 08.02.2014 12:10, Stephen Kelly wrote: Nils Gladitz wrote: Does that work if the direct preprocessor flag -Wp,-isystem, I can't find -Wp or an equivalent in the documentation I did find /Qoption,cpp, by looking through the command line help but it doesn't seem to like -isystem either :/ Nils -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request for review of topic intel-visibility
On 02/07/2014 06:05 AM, Nils Gladitz wrote: CMAKE_LANG_COMPILE_OPTIONS_VISIBILITY is being set up for the Intel compiler in general but the -fvisibility option is not supported on Windows and will result in compiler warnings. I set up the intel-visibility topic which moves the option into the Windows and Darwin specific Platform files. This looks correct to me and is a good bug fix. Please merge to 'next' for testing. BTW, the Darwin-icc.cmake file needs to be refactored into modern Darwin-Intel-lang.cmake modules with a Darwin-Intel.cmake helper. Do you have access to Intel C/C++ on OS X that you could use to try this task? Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request for review of topic intel-visibility
Nils Gladitz wrote: On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could use to try this task? I currently only have access to Intel on Windows which is why I thought it safer to put the topic up for review first too. Does intel on windows have separate gcc-like and msvc-like modes? Alex also adjusted the intel handling of -isystem today. Does that work if the direct preprocessor flag -Wp,-isystem, is used, if there's some equivalent with the intel compiler? See e00db59d which uses that for the QCC driver. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request for review of topic intel-visibility
On Friday, February 07, 2014 05:33:47 PM Stephen Kelly wrote: Nils Gladitz wrote: On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could use to try this task? I currently only have access to Intel on Windows which is why I thought it safer to put the topic up for review first too. Does intel on windows have separate gcc-like and msvc-like modes? Alex also adjusted the intel handling of -isystem today. Does that work if the direct preprocessor flag -Wp,-isystem, is used, if there's some Would there be an advantage compared to using -isystem ? AFAIK -isystem is not supported by icpc under Windows, and from looking at other files in cmake -isystem seems in general not to be supported under OSX. But I have access only to icpc under Linux, so I can't check. Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Request for review of topic intel-visibility
On 02/07/2014 04:24 PM, Brad King wrote: This looks correct to me and is a good bug fix. Please merge to 'next' for testing. Thanks, will do! Do you have access to Intel C/C++ on OS X that you could use to try this task? I currently only have access to Intel on Windows which is why I thought it safer to put the topic up for review first too. Nils -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
