RE: [PATCH] Key filter (was: [PATCH] MRUMemoryStore and fellows fixes)

2001-11-21 Thread Gerhard Froehlich
ritics) how the store concept works and which peaces we can improve. Cheers Gerhard >> -Original Message- >> From: Gerhard Froehlich [mailto:[EMAIL PROTECTED]] >> Sent: Wednesday, November 21, 2001 2:15 PM >> To: cocoon-Dev >> Subject: [PATCH] Key filter (was

RE: [PATCH] Key filter (was: [PATCH] MRUMemoryStore and fellows fixes)

2001-11-21 Thread Carsten Ziegeler
ev > Subject: [PATCH] Key filter (was: [PATCH] MRUMemoryStore and fellows > fixes) > > > Hi Carsten, > as you proposed I implemented a filter to get > the cache files from FilesystemStore.keys() > method. > > I

[PATCH] Key filter (was: [PATCH] MRUMemoryStore and fellows fixes)

2001-11-21 Thread Gerhard Froehlich
Hi Carsten, as you proposed I implemented a filter to get the cache files from FilesystemStore.keys() method. It's a little hack... Cheers Gerhard black holes are when GOD is dividing by zero 23 49 43 51 3A 20 31 32 33 35 33 34 38 31 31

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Gerhard Froehlich
>> >I'm currently incorporating your patches (Startable interface). >> >For this I have to change some component handling. >> >I will finish this in 1h (aprox) and then you can add >> >your filtering easily. >> >> Was it wrong, the way I implemented it? >> >The implementation of the MRUMemorySto

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Carsten Ziegeler
Gerhard Froehlich wrote: > > > >I'm currently incorporating your patches (Startable interface). > >For this I have to change some component handling. > >I will finish this in 1h (aprox) and then you can add > >your filtering easily. > > Was it wrong, the way I implemented it? > The implementat

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Gerhard Froehlich
>I'm currently incorporating your patches (Startable interface). >For this I have to change some component handling. >I will finish this in 1h (aprox) and then you can add >your filtering easily. Was it wrong, the way I implemented it? >> >> >thanks for your patch! But - sorry for this pain - >

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Carsten Ziegeler
ilto:[EMAIL PROTECTED]] > Sent: Wednesday, November 21, 2001 11:33 AM > To: [EMAIL PROTECTED] > Subject: RE: [PATCH] MRUMemoryStore and fellows fixes > > > >thanks for your patch! But - sorry for this pain - > > autsch ;) > > >I think we should not change existing

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Gerhard Froehlich
>thanks for your patch! But - sorry for this pain - autsch ;) >I think we should not change existing interfaces >like the Store interface. I know you would say, that. For my defence I didn't wanted to change the FilesystemStore. I did it once and got - well - in trouble. >The MRUMemoryStore ca

RE: [PATCH] MRUMemoryStore and fellows fixes

2001-11-21 Thread Carsten Ziegeler
Hi Gerhard, thanks for your patch! But - sorry for this pain - I think we should not change existing interfaces like the Store interface. The MRUMemoryStore calls the keys() method of the FilesystemStore. The fsstore returns all keys, but only those contained in a special directory are of interes

[PATCH] MRUMemoryStore and fellows fixes

2001-11-20 Thread Gerhard Froehlich
Hi, as promised this patch contains serveral fixes in the store implementation: MRUMemoryStore: - added Disposable interface and implemented the initialize() and dispose() method to init- ialize/dispose the StoreJanitor and the FilesystemQueue thread. - completed the methods containsKey() and ke