Re: [code-quality] Two attribute usage checkers I'd like to see

2013-06-19 Thread Martin Pool
On 19 June 2013 17:37, Sylvain Thénault wrote: > > Hey guys, today is your last chance to contribute this to the pylint 10th > anniversary sprint ;) > And to get it in forthcoming 1.0... > > Monday and tuesday reports: > https://www.logilab.org/blogentry/146924 > https://www.logilab.org/blogentry

Re: [code-quality] Two attribute usage checkers I'd like to see

2013-06-19 Thread Skip Montanaro
On Wed, Jun 19, 2013 at 2:37 AM, Sylvain Thénault wrote: > On 07 juin 09:18, Martin Pool wrote: >> On 7 June 2013 06:49, Skip Montanaro wrote: >> >> > If I never refer to self.x or self.y within the class's methods it >> > would be nice to be alerted. >> > >> >> +1, and that seems feasible to add

Re: [code-quality] Two attribute usage checkers I'd like to see

2013-06-19 Thread Sylvain Thénault
On 19 juin 06:59, Ned Batchelder wrote: > I don't think I can make an actual patch, but can I suggest a very > simple change? This message: > > Invalid name "f" for type variable (should match > [a-z_][a-z0-9_]{2,30}$) > > would be simpler and clearer without the word "type". I always read

Re: [code-quality] Two attribute usage checkers I'd like to see

2013-06-19 Thread Ned Batchelder
I don't think I can make an actual patch, but can I suggest a very simple change? This message: Invalid name "f" for type variable (should match [a-z_][a-z0-9_]{2,30}$) would be simpler and clearer without the word "type". I always read it first as "f is not a valid name for a type".

Re: [code-quality] Two attribute usage checkers I'd like to see

2013-06-19 Thread Sylvain Thénault
On 07 juin 09:18, Martin Pool wrote: > On 7 June 2013 06:49, Skip Montanaro wrote: > > > If I never refer to self.x or self.y within the class's methods it > > would be nice to be alerted. > > > > +1, and that seems feasible to add to pylint. Hey guys, today is your last chance to contribute th