Re: [collectd] AIX: WPAR and cpu patchs.

[Florian Forster]

Hi Manuel,

On Wed, Aug 25, 2010 at 04:07:31PM +0200, Manuel Luis Sanmartín Rozada wrote:
 cc1: warnings being treated as errors
 cpu.c: In function 'cpu_read':
 cpu.c:566: warning: unused variable 'temp'

fixed that, thanks :)

 In the wpar plugin I change some strings, and the wpar cpu code.
 The cpu part was wrong, I send an old version.
 I need to do some calculations to convert the physical tics to
 something like cpu total from 0 to 100.

I've applied the changes that fix your typos, too.

I'm having reservations regarding the mangling of the CPU counters,
though. The basic unit here *is* ticks and I think it should be left to
front-ends to convert this to a percentage if the users wishes so. Also,
submitting the raw ticks would be consistent with the CPU and LPAR
plugins.

Best regards,
—octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x0C705A15
http://octo.it/


signature.asc
Description: Digital signature
___
collectd mailing list
collectd@verplant.org
http://mailman.verplant.org/listinfo/collectd

Re: [collectd] AIX: WPAR and cpu patchs.

[Florian Forster]

Hi Manuel,

On Tue, Jul 20, 2010 at 08:18:12PM +0200, Manuel Luis Sanmartín Rozada wrote:
 The wpar patches are for a plugin to collect cpu, load and memory from
 Workload Partitioning in AIX. It was tested with system WPAR in
 aix 6.1.

thank you very much for your patches :) I pulled them into my Git
repository and pushed them to Github [0].

I did some changes to the code, but couldn't test them because I don't
have an AIX machine around. It'd be great if you could tell me whether
it still works or not, so I can pull the changes into the master branch.

Regards,
—octo

[0] http://github.com/octo/collectd/commits/ms/wpar
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/


signature.asc
Description: Digital signature
___
collectd mailing list
collectd@verplant.org
http://mailman.verplant.org/listinfo/collectd